From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Luca Weiss <luca.weiss@fairphone.com>
Cc: Bryan O'Donoghue <bod@kernel.org>, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: media: camss: Add qcom,sm6350-camss
Date: Tue, 28 Oct 2025 11:39:43 +0100 [thread overview]
Message-ID: <b8550097-76c5-4843-9b05-0802f3a4e3e6@kernel.org> (raw)
In-Reply-To: <936ecaf4-8b48-4c93-a666-153a13ee9e16@linaro.org>
On 28/10/2025 11:24, Bryan O'Donoghue wrote:
> On 28/10/2025 09:46, Krzysztof Kozlowski wrote:
>>>>> + power-domain-names:
>>>>> + items:
>>>>> + - const: ife0
>>>>> + - const: ife1
>>>>> + - const: ife2
>>>>> + - const: top
>>>> Uh, not your fault, but who came with this list in previous generations?
>>>> Instead of simple and obvious "top+ifeX" which allows growing/shrinking,
>>>> someone put "top" at the end which means this cannot follow same order
>>>> as X1E for example... Heh, it follows at least sm8550.
>>> Shall we put top as first power-domain? I don't think it's an issue to
>>> change the order.
>> Well, it matches sm8550, so I am just grumpy complaining. It's fine.
>
> The provenance here is "top" was required to be added last because the
> code depended on magic indexing in dtb to know which was the TOP GDSC.
That's silly, because if it was first element would be much easier.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-28 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 12:23 [PATCH 0/3] Add CAMSS support for SM6350 Luca Weiss
2025-10-24 12:23 ` [PATCH 1/3] dt-bindings: media: camss: Add qcom,sm6350-camss Luca Weiss
2025-10-28 8:54 ` Krzysztof Kozlowski
2025-10-28 9:24 ` Luca Weiss
2025-10-28 9:46 ` Krzysztof Kozlowski
2025-10-28 10:24 ` Bryan O'Donoghue
2025-10-28 10:39 ` Krzysztof Kozlowski [this message]
2025-10-28 10:50 ` Bryan O'Donoghue
2025-10-28 10:28 ` Luca Weiss
2025-10-28 12:08 ` Bryan O'Donoghue
2025-10-28 9:47 ` Konrad Dybcio
2025-10-24 12:24 ` [PATCH 2/3] media: qcom: camss: Add SM6350 support Luca Weiss
2025-10-28 9:26 ` Bryan O'Donoghue
2025-10-28 11:24 ` Luca Weiss
2025-10-24 12:24 ` [PATCH 3/3] arm64: dts: qcom: sm6350: Add CAMSS node Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8550097-76c5-4843-9b05-0802f3a4e3e6@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox