public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: kishon@ti.com, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, andriy.shevchenko@intel.com,
	cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
	peter.harliman.liem@intel.com
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY
Date: Wed, 18 Sep 2019 10:26:11 +0800	[thread overview]
Message-ID: <b860d369-fda4-4a20-bba5-4ced420de8aa@linux.intel.com> (raw)
In-Reply-To: <20190917202410.GA6574@bogus>

Hi Rob,

     Thank you for the review comments.

On 18/9/2019 4:24 AM, Rob Herring wrote:
> On Wed, Sep 04, 2019 at 02:27:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add a YAML schema to use the host controller driver with the
>> SDXC PHY on Intel's Lightning Mountain SoC.
> Same issues on this one as emmc phy.

Agreed!, once clarified the emmc phy comments, let me update further. 
Thanks!

Best Regards
Vadivel
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> ---
>>   changes in v3:
>>     - Rob's review comments addressed and updated the patch
>>     - merged syscon and sdxc yaml file as single file after discussion
>>
>>   changes in v2:
>>     - As per Rob's review comment syscon node entry added instead of reference
>>     - splitted two patches one for syscon and another for sdxc phy
>> ---
>>   .../bindings/phy/intel,lgm-sdxc-phy.yaml           | 69 ++++++++++++++++++++++
>>   1 file changed, 69 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-sdxc-phy.yaml

      reply	other threads:[~2019-09-18  2:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04  6:27 [PATCH v3 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY Ramuthevar,Vadivel MuruganX
2019-09-04  6:27 ` [PATCH v3 2/2] phy: intel-lgm-sdxc: Add support for " Ramuthevar,Vadivel MuruganX
2019-09-04 12:39   ` Andy Shevchenko
2019-09-04 13:38     ` Ramuthevar, Vadivel MuruganX
2019-09-17 20:24 ` [PATCH v3 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM " Rob Herring
2019-09-18  2:26   ` Ramuthevar, Vadivel MuruganX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b860d369-fda4-4a20-bba5-4ced420de8aa@linux.intel.com \
    --to=vadivel.muruganx.ramuthevar@linux.intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.harliman.liem@intel.com \
    --cc=qi-ming.wu@intel.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox