From: Jiri Slaby <jirislaby@kernel.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Haowei Zheng <zhenghaowei@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 2/3] serial: 8250: Add Loongson uart driver support
Date: Mon, 29 Sep 2025 08:19:29 +0200 [thread overview]
Message-ID: <b862846d-fb2a-4df4-8457-d858aa63031d@kernel.org> (raw)
In-Reply-To: <CAMpQs4JgR=iG6LAuYeVxOpE31S6n=dC4+FGUJczOYDVfWHDuFw@mail.gmail.com>
Hi,
On 28. 09. 25, 4:48, Binbin Zhou wrote:
> Hi Greg:
>
> Thanks for your reply.
>
> On Wed, Sep 24, 2025 at 6:22 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> On Wed, Sep 24, 2025 at 02:29:37PM +0800, Binbin Zhou wrote:
>>> --- a/include/uapi/linux/serial_core.h
>>> +++ b/include/uapi/linux/serial_core.h
>>> @@ -31,6 +31,7 @@
>>> #define PORT_ALTR_16550_F128 28 /* Altera 16550 UART with 128 FIFOs */
>>> #define PORT_RT2880 29 /* Ralink RT2880 internal UART */
>>> #define PORT_16550A_FSL64 30 /* Freescale 16550 UART with 64 FIFOs */
>>> +#define PORT_LOONGSON 31 /* Loongson 16550 UART */
>>
>> Why does userspace need to have this value exported?
>
> Sorry, this was a cheap mistake.
> It should follow the existing latest macro definition as follows:
That was not the point. The point was why do you need that at all?
--
js
suse labs
next prev parent reply other threads:[~2025-09-29 6:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 6:29 [PATCH v5 0/3] uart: Introduce uart driver for the Loongson family Binbin Zhou
2025-09-24 6:29 ` [PATCH v5 1/3] dt-bindings: serial: 8250: Add Loongson uart compatible Binbin Zhou
2025-09-24 19:19 ` Conor Dooley
2025-09-24 6:29 ` [PATCH v5 2/3] serial: 8250: Add Loongson uart driver support Binbin Zhou
2025-09-24 10:22 ` Greg Kroah-Hartman
2025-09-28 2:48 ` Binbin Zhou
2025-09-29 6:19 ` Jiri Slaby [this message]
2025-09-30 3:03 ` Binbin Zhou
2025-10-08 12:16 ` Greg Kroah-Hartman
2025-09-29 6:26 ` Jiri Slaby
2025-09-30 3:07 ` Binbin Zhou
2025-09-30 12:01 ` Ilpo Järvinen
2025-09-30 11:58 ` Ilpo Järvinen
2025-10-09 2:52 ` Binbin Zhou
2025-10-09 11:46 ` Ilpo Järvinen
2025-09-24 6:29 ` [PATCH v5 3/3] LoongArch: dts: Add uart new compatible string Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b862846d-fb2a-4df4-8457-d858aa63031d@kernel.org \
--to=jirislaby@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=zhenghaowei@loongson.cn \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).