From: Krzysztof Kozlowski <krzk@kernel.org>
To: Baojun Xu <baojun.xu@ti.com>, broonie@kernel.org, tiwai@suse.de
Cc: andriy.shevchenko@linux.intel.com, 13916275206@139.com,
shenghao-ding@ti.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, k-yi@ti.com, henry.lo@ti.com,
robinchen@ti.com, will-wang@ti.com, jim.shil@goertek.com,
toastcheng@google.com, chinkaiting@google.com
Subject: Re: [PATCH v2 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/2574/5806M/5806MD/5830 support
Date: Fri, 14 Nov 2025 08:41:08 +0100 [thread overview]
Message-ID: <b863a8f1-22e6-4a52-be8b-9eb83b999937@kernel.org> (raw)
In-Reply-To: <20251114073358.23046-2-baojun.xu@ti.com>
On 14/11/2025 08:33, Baojun Xu wrote:
> TAS5806M, TAS5806MD and TAS5830 is in same family with TAS58XX.
> TAS2568, TAS2574 is in family with TAS257X.
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
>
> ---
> v2:
> - Add TAS2574 support.
> - Re-organize the patch, put compatible in front.
> - Combined some chips as the reg setting is same (0x48-0x4b).
You need to provide reasons for dropping tags.
> ---
> .../devicetree/bindings/sound/ti,tas2781.yaml | 103 ++++++++++++------
> 1 file changed, 69 insertions(+), 34 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> index f0bb5faf55c8..224999ed6529 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -34,15 +34,61 @@ description: |
> https://www.ti.com/lit/gpn/tas2320
> https://www.ti.com/lit/gpn/tas2563
> https://www.ti.com/lit/gpn/tas2572
> + https://www.ti.com/lit/gpn/tas2574
> https://www.ti.com/lit/gpn/tas2781
> + https://www.ti.com/lit/gpn/tas5806m
> + https://www.ti.com/lit/gpn/tas5806md
> https://www.ti.com/lit/gpn/tas5815
> https://www.ti.com/lit/gpn/tas5822m
> https://www.ti.com/lit/gpn/tas5825m
> https://www.ti.com/lit/gpn/tas5827
> https://www.ti.com/lit/gpn/tas5828m
> + https://www.ti.com/lit/gpn/tas5830
>
> properties:
> compatible:
> + oneOf:
> + - enum:
> + - ti,tas2020
> + - ti,tas2118
> + - ti,tas2120
> + - ti,tas2320
> + - ti,tas2563
> + - ti,tas2568
> + - ti,tas2570
> + - ti,tas2572
> + - ti,tas2574
> + - ti,tas2781
> + - ti,tas5802
> + - ti,tas5806m
> + - ti,tas5806md
> + - ti,tas5815
> + - ti,tas5822
> + - ti,tas5825
> + - ti,tas5827
> + - ti,tas5828
> + - ti,tas5830
> + - items:
> + - enum:
> + - ti,tas2020
No, this makes no sense. Device is not both - compatible and not
compatible - at the same time.
Also, rest of my comments were not implemented.
Go back to previous version and read the feedback again. You can reach
to more experienced colleagues in TI who should explain you basics of
upstreaming process. Or listen to one of many speeches/presentations on
upstreaming from conferences or trainings. Or read Linaro's guide on
their blog. It is your homework.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-11-14 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 7:33 [PATCH v2 1/2] ASoC: tas2781: Add tas2568/2574/5806m/5806md/5830 support Baojun Xu
2025-11-14 7:33 ` [PATCH v2 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/2574/5806M/5806MD/5830 support Baojun Xu
2025-11-14 7:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b863a8f1-22e6-4a52-be8b-9eb83b999937@kernel.org \
--to=krzk@kernel.org \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=chinkaiting@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henry.lo@ti.com \
--cc=jim.shil@goertek.com \
--cc=k-yi@ti.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
--cc=toastcheng@google.com \
--cc=will-wang@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).