From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: meson-gx: support specifying cd interrupt
Date: Thu, 16 Feb 2023 10:18:06 +0100 [thread overview]
Message-ID: <b87003f6-02a8-64fc-80fb-b90ca6bec37c@linaro.org> (raw)
In-Reply-To: <1c5996a5-491f-39d6-b120-bbef86473729@gmail.com>
On 14/02/2023 22:42, Heiner Kallweit wrote:
> Support passing a second interrupt as card detect interrupt.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> index 46e235bf2..c8c30300d 100644
> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> @@ -28,7 +28,7 @@ properties:
> maxItems: 1
>
> interrupts:
> - maxItems: 1
> + maxItems: 2
Wait, you now *require* (not support) cd interrupt, so this looks like
ABI break.
Second, you must describe the items.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-16 9:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 21:39 [PATCH v2 0/3] mmc: support setting card detect interrupt from drivers and use it in meson-gx Heiner Kallweit
2023-02-14 21:41 ` [PATCH v2 1/3] mmc: core: support setting card detect interrupt from drivers Heiner Kallweit
2023-02-14 21:42 ` [PATCH v2 2/3] dt-bindings: mmc: meson-gx: support specifying cd interrupt Heiner Kallweit
2023-02-16 9:18 ` Krzysztof Kozlowski [this message]
2023-02-16 9:29 ` Heiner Kallweit
2023-02-16 9:34 ` Krzysztof Kozlowski
2023-02-16 9:41 ` Heiner Kallweit
2023-02-16 9:49 ` Heiner Kallweit
2023-02-16 11:12 ` Ulf Hansson
2023-02-14 21:44 ` [PATCH v2 3/3] mmc: meson-gx: support platform interrupt as card detect interrupt Heiner Kallweit
2023-02-15 12:48 ` [PATCH v2 0/3] mmc: support setting card detect interrupt from drivers and use it in meson-gx Ulf Hansson
2023-02-16 9:18 ` Krzysztof Kozlowski
2023-02-16 11:14 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b87003f6-02a8-64fc-80fb-b90ca6bec37c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).