From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50387ECAAA1 for ; Tue, 30 Aug 2022 19:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiH3TTU (ORCPT ); Tue, 30 Aug 2022 15:19:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231428AbiH3TTR (ORCPT ); Tue, 30 Aug 2022 15:19:17 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F8C786CB for ; Tue, 30 Aug 2022 12:19:12 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id bx38so12390965ljb.10 for ; Tue, 30 Aug 2022 12:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=/6LyHTH38BgY0ADcdGBfZVTBqdZgfLuEbTGF5dLunuo=; b=hO62t4GV1LIJ8G8QoUwW8V2/xBSvQhASIkjPuucMOlEmS69QhTSItRIwJNp0cvysTH QQcWYZ6Ju9ckQiXoigOFbXCNApCr8BpaeCnLmud2OV0Egl6ip9uYJDbfzOIy7g+7x+15 t+p7GjKmXxt51yTWqHw9GALpa9u2Af+2s25v5YHHu7AmdP0EDcKlv9ovddd0HwehL6iV OWCsU4+kaL8xL/t1ADgowuzgU0gtwit9Mcf8dCd9B8qnpW2whzAy1TDg+DezQnD1hGmY +pTWB6/kY3T88JUEvjMgr+8HdKCj5kYpbKQSH+NSa7V3hYJhW1qu/oIfeCO15XvOhUuI AThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=/6LyHTH38BgY0ADcdGBfZVTBqdZgfLuEbTGF5dLunuo=; b=F0dnn4jd+mQrWUH9/lMmYD77sxAOKy50fqs9fcqRivn1DNyXutDrY2Yc6h0+6cd74s TKNd8s3C/+JOiogM7z8bZLuojeYgf8Bhl2yOIR0YWsnmLD6klZfG/U0ZXklgCrUO2O9z 4fGters5XCL7TDT2s3OTYn2h9WieQfl2BGCoudQxphUkmCaIgvwucHQ0bKaDWvusSLQJ +mfFf6SrYjoRQnlISYaO4zJgIjYu0Zt0/nnlPa1elPqcDmFiqXea+tvek80FtcxB7dFH STyKgRPY/cCd8tyoLy7tMABOI769XwjuTDf971yQOrZPkcPpkfaQ7tGkN6cXxBnaCgaj ImBA== X-Gm-Message-State: ACgBeo3rPxEIoPqIJHsNZJbq+USPL1D2eQICLB7I30RcNxS0UArR7bgk c/SI0+sndbh4Qn32P429qrhCEw== X-Google-Smtp-Source: AA6agR7145igvHGfdZHSgAoxdGPymGfhempqbzQL8ie7cg1cpL7s/xcLE5T2BWNxethJ3rFwI9FUSg== X-Received: by 2002:a05:651c:154b:b0:261:d6f3:5550 with SMTP id y11-20020a05651c154b00b00261d6f35550mr7607592ljp.528.1661887151106; Tue, 30 Aug 2022 12:19:11 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id i23-20020a2e8097000000b00261bfa93f55sm1879969ljg.11.2022.08.30.12.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 12:19:10 -0700 (PDT) Message-ID: Date: Tue, 30 Aug 2022 22:19:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH net-next v2 1/5] dt-bindings: net: Convert Altera TSE bindings to yaml Content-Language: en-US To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20220830095549.120625-1-maxime.chevallier@bootlin.com> <20220830095549.120625-2-maxime.chevallier@bootlin.com> <4a37d318-8c83-148b-89b3-9729bc7c9761@linaro.org> <20220830211617.54d2abc9@pc-10.home> From: Krzysztof Kozlowski In-Reply-To: <20220830211617.54d2abc9@pc-10.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/08/2022 22:16, Maxime Chevallier wrote: >>> Signed-off-by: Maxime Chevallier >> >> Rebase your changes on some decent kernel and use >> get_maintainers.pl... > > I'm rebased against net-next, so I don't understand how I'm supposed to > do for this series, should I sent binding patches separately and based > on another tree ? > > I'll cc you next time, sorry about that. net-next is correct, I just assumed it is some older tree since you did not Cc me. > >>> --- >>> V1->V2: >>> - Removed unnedded maxItems >>> - Added missing minItems >>> - Fixed typos in some properties names >>> - Fixed the mdio subnode definition >>> >>> .../devicetree/bindings/net/altera_tse.txt | 113 ------------- >>> .../devicetree/bindings/net/altr,tse.yaml | 156 >>> ++++++++++++++++++ 2 files changed, 156 insertions(+), 113 >>> deletions(-) delete mode 100644 >>> Documentation/devicetree/bindings/net/altera_tse.txt create mode >>> 100644 Documentation/devicetree/bindings/net/altr,tse.yaml >> >> (...) >> >>> diff --git a/Documentation/devicetree/bindings/net/altr,tse.yaml >>> b/Documentation/devicetree/bindings/net/altr,tse.yaml new file mode >>> 100644 index 000000000000..1676e13b8c64 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/altr,tse.yaml >>> @@ -0,0 +1,156 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/altr,tse.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Altera Triple Speed Ethernet MAC driver (TSE) >>> + >>> +maintainers: >>> + - Maxime Chevallier >>> + >>> +allOf: >> >> Put allOf below "required". > > Ack > >>> + - $ref: "ethernet-controller.yaml#" >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - altr,tse-1.0 >>> + - ALTR,tse-1.0 >>> + then: >>> + properties: >>> + reg: >>> + minItems: 4 >>> + reg-names: >>> + items: >>> + - const: control_port >>> + - const: rx_csr >>> + - const: tx_csr >>> + - const: s1 >>> + >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - altr,tse-msgdma-1.0 >>> + then: >>> + properties: >>> + reg: >>> + minItems: 6 >>> + reg-names: >>> + minItems: 6 >> >> No need for minItems. > > Ok I'll remove it > >>> + items: >>> + - const: control_port >>> + - const: rx_csr >>> + - const: rx_desc >>> + - const: rx_resp >>> + - const: tx_csr >>> + - const: tx_desc >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - altr,tse-1.0 >>> + - ALTR,tse-1.0 >> >> This is deprecated compatible. You need oneOf and then deprecated: >> true. > > Ok thanks for the tip > >>> + - altr,tse-msgdma-1.0 >>> + >>> + reg: >>> + minItems: 4 >>> + maxItems: 6 >>> + >>> + reg-names: >>> + minItems: 4 >>> + items: >>> + - const: control_port >>> + - const: rx_csr >>> + - const: rx_desc >>> + - const: rx_resp >>> + - const: tx_csr >>> + - const: tx_desc >>> + - const: s1 >> >> This is messed up. You allow only 6 items maximum, but list 7. It >> contradicts your other variants in allOf:if:then. > > I'll remove that part then, apparently it's not needed at all if the > allOf:if:then cover all cases. Right. The typical pattern is like clocks/clock-names here: https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L57 Best regards, Krzysztof