From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34BB6C54EED for ; Tue, 24 Jan 2023 07:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232717AbjAXHwu (ORCPT ); Tue, 24 Jan 2023 02:52:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232431AbjAXHwt (ORCPT ); Tue, 24 Jan 2023 02:52:49 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D4B83D094 for ; Mon, 23 Jan 2023 23:52:42 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id d4-20020a05600c3ac400b003db1de2aef0so10257720wms.2 for ; Mon, 23 Jan 2023 23:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BAe2WJH+upW322dDk1bEGZ4cZcCC0V7GrzqFfjdJrMg=; b=hGPTxpSwZUv2ubxuT/5nHbDe+A30AqGBmtvji/Iv7jd9BR1eURErdOE+Ld8kUkcKcV KBpMd+yZB0HVRMSv788IXaCQQxdg9P9UVfVih3M/pen+O2tI+hvtR5R6cbWPe7F48Hqb ExACdlVSsYE6TI+k3v/pOyJomrx6/HBSc4EsF3l9xMz8Uj2+xwf7DVxSUixIp9lITiFV 6yOGgpOTV+n/yLZlsoLSx3vLvV/ml+6ZI023vAbywjGDGOjFDrxp+r82czeY0Jb8dexv CP5uWx6pW85Lp7lztlLRVLu4x+/zCR5SutP5JmJbQ2uCG/SEL2XnmQFMRKINlPjQweee wnsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BAe2WJH+upW322dDk1bEGZ4cZcCC0V7GrzqFfjdJrMg=; b=ywLKbrXSinW87wtVcDaJTVhKqdJPAa5Kg6FnYV/Mrqg7b2oJbRtkqINKe4cu30Vcf0 WS4zs3CncaJyNGSAHR7JDmnTapLwJGzINyg1Q+NA+H5Q8catamQSq+1HY9ql+JqrQv/u wnuSGwvI83hh5OyhnE87UXC6FdW+SnELJ3JLocIFNxluE6G137Io0LJTIhnHEk2etLag 3XC7m6vhGHNTHjvePUTGnBgoarmPqaDLAL6040A6muA6uiR3voTqWTzek4eq8hjmLz2t 4ju0d3LV5C72+7+4Nx5NZakVEYVM8JNJj/q0l4SpkxCNvUOKTrpkqJ61bfOK0bk8GL/H 6PkQ== X-Gm-Message-State: AFqh2koglGTu5op9kPUF3F09BnHq0NInIL9DaS6nFdk11nMg55Qpe6UE o5g2pD4/Xi3ulfHIDGuxdbfGtA== X-Google-Smtp-Source: AMrXdXtUIbnTklwYfp0Ur7d3WG5zlOuPOMpIoOKsMyOMySKmH3lI7Ra+GFxs1Sh1FysqHT0LgtpI4A== X-Received: by 2002:a05:600c:3488:b0:3d2:370b:97f4 with SMTP id a8-20020a05600c348800b003d2370b97f4mr34735239wmq.16.1674546760714; Mon, 23 Jan 2023 23:52:40 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id m26-20020a7bcb9a000000b003db2dede1a2sm12401412wmi.26.2023.01.23.23.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 23:52:40 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 08:52:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/2] dt-bindings: dma: cleanup examples - indentation, lowercase hex Content-Language: en-US To: Rob Herring Cc: Vinod Koul , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Olivier Dautricourt , Stefan Roese , Hector Martin , Sven Peter , Alyssa Rosenzweig , Thierry Reding , Jonathan Hunter , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Konrad Dybcio , Viresh Kumar , Andy Shevchenko , Green Wan , Paul Walmsley , Palmer Dabbelt , Eugeniy Paltsev , Kunihiko Hayashi , Masami Hiramatsu , Maxime Coquelin , Alexandre Torgue , Matthias Brugger , Maxime Ripard , =?UTF-8?B?77+9ZXI=?= , Peng Fan , Paul Cercueil , - , Long Cheng , Rajesh Gumasta , Yoshihiro Shimoda , Biju Das , Miquel Raynal , Palmer Debbelt , Masahiro Yamada , Amelie Delaunay , Linus Walleij , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-mediatek@lists.infradead.org References: <20230118180144.364756-1-krzysztof.kozlowski@linaro.org> <20230118180144.364756-2-krzysztof.kozlowski@linaro.org> <20230123202010.GA2455859-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20230123202010.GA2455859-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/01/2023 21:20, Rob Herring wrote: > On Wed, Jan 18, 2023 at 07:01:44PM +0100, Krzysztof Kozlowski wrote: >> Cleanup examples: >> - use 4-space indentation (for cases when it is neither 4 not 2 space), >> - use lowercase hex. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/dma/snps,dw-axi-dmac.yaml | 36 +++++++++---------- >> .../bindings/dma/stericsson,dma40.yaml | 4 +-- >> 2 files changed, 20 insertions(+), 20 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml >> index 2bedab1f74e0..d34d0fa62ab5 100644 >> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml >> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml >> @@ -113,21 +113,21 @@ additionalProperties: false >> >> examples: >> - | >> - #include >> - #include >> - /* example with snps,dw-axi-dmac */ >> - dmac: dma-controller@80000 { >> - compatible = "snps,axi-dma-1.01a"; >> - reg = <0x80000 0x400>; >> - clocks = <&core_clk>, <&cfgr_clk>; >> - clock-names = "core-clk", "cfgr-clk"; >> - interrupt-parent = <&intc>; >> - interrupts = <27>; >> - #dma-cells = <1>; >> - dma-channels = <4>; >> - snps,dma-masters = <2>; >> - snps,data-width = <3>; >> - snps,block-size = <4096 4096 4096 4096>; >> - snps,priority = <0 1 2 3>; >> - snps,axi-max-burst-len = <16>; >> - }; >> + #include >> + #include >> + /* example with snps,dw-axi-dmac */ >> + dmac: dma-controller@80000 { > > Drop unused labels while you are here. Ack > >> + compatible = "snps,axi-dma-1.01a"; >> + reg = <0x80000 0x400>; >> + clocks = <&core_clk>, <&cfgr_clk>; >> + clock-names = "core-clk", "cfgr-clk"; >> + interrupt-parent = <&intc>; >> + interrupts = <27>; >> + #dma-cells = <1>; >> + dma-channels = <4>; >> + snps,dma-masters = <2>; >> + snps,data-width = <3>; >> + snps,block-size = <4096 4096 4096 4096>; >> + snps,priority = <0 1 2 3>; >> + snps,axi-max-burst-len = <16>; >> + }; >> diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml >> index 664ee61a00d8..57395a810719 100644 >> --- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml >> +++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml >> @@ -147,9 +147,9 @@ examples: >> #include >> #include >> #include >> - dma-controller@801C0000 { >> + dma-controller@801c0000 { >> compatible = "stericsson,db8500-dma40", "stericsson,dma40"; >> - reg = <0x801C0000 0x1000>, <0x40010000 0x800>; >> + reg = <0x801c0000 0x1000>, <0x40010000 0x800>; >> reg-names = "base", "lcpa"; >> interrupts = ; >> #dma-cells = <3>; > > Indentation? Ack Best regards, Krzysztof