Re: [PATCH] arm64: dts: rockchip: add rfkill node for M.2 E wifi on orangepi-5-plus

[Dragan Simic <dsimic@manjaro.org>]

Hello Florian,

On 2024-08-07 18:20, Florian Klink wrote:
> This follows the same logic as 82d40b141a4c7ab66, which did the same
> for rock-5b.

Please use the standard format for referencing commits, i.e. 
82d40b141a4c
("arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b").

> The GPIO pin connecting the WiFi enable signal inside the M.2 Key E 
> slot
> is the same as there.
> 
> This can be validated in
> arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtsi from Armbian
> rk-5.10-rkr4 kernel, which contains a `wifi_disable` node with that 
> same
> GPIO pin.

This might be used as a reference, but please provide a permanent link
to the actual source code in the referenced downstream repository.

> Signed-off-by: Florian Klink <flokli@flokli.de>
> Tested-by: Florian Klink <flokli@flokli.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> index e74871491ef5..c3a6812cc93a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> @@ -105,6 +105,13 @@ led {
>  		};
>  	};
> 
> +	rfkill {
> +		compatible = "rfkill-gpio";
> +		label = "rfkill-pcie-wlan";
> +		radio-type = "wlan";
> +		shutdown-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>;
> +	};
> +
>  	sound {
>  		compatible = "simple-audio-card";
>  		pinctrl-names = "default";