* [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
@ 2022-05-05 18:43 Biju Das
2022-05-10 8:18 ` Sergei Shtylyov
2022-05-17 8:14 ` Geert Uytterhoeven
0 siblings, 2 replies; 8+ messages in thread
From: Biju Das @ 2022-05-05 18:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
index b31fb713ae4d..40201a16d653 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
@@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
};
adc: adc@10059000 {
+ compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-adc";
reg = <0 0x10059000 0 0x400>;
- /* place holder */
+ interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
+ <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
+ clock-names = "adclk", "pclk";
+ resets = <&cpg R9A07G043_ADC_PRESETN>,
+ <&cpg R9A07G043_ADC_ADRST_N>;
+ reset-names = "presetn", "adrst-n";
+ power-domains = <&cpg>;
+ status = "disabled";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ channel@0 {
+ reg = <0>;
+ };
+ channel@1 {
+ reg = <1>;
+ };
};
tsu: thermal@10059400 {
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
2022-05-05 18:43 [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node Biju Das
@ 2022-05-10 8:18 ` Sergei Shtylyov
2022-05-10 8:24 ` Biju Das
2022-05-17 8:14 ` Geert Uytterhoeven
1 sibling, 1 reply; 8+ messages in thread
From: Sergei Shtylyov @ 2022-05-10 8:18 UTC (permalink / raw)
To: Biju Das, Rob Herring, Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Magnus Damm, linux-renesas-soc, devicetree,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Hello!
On 5/5/22 9:43 PM, Biju Das wrote:
> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> index b31fb713ae4d..40201a16d653 100644
> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
> };
>
> adc: adc@10059000 {
> + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-adc";
> reg = <0 0x10059000 0 0x400>;
> - /* place holder */
> + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
> + clock-names = "adclk", "pclk";
> + resets = <&cpg R9A07G043_ADC_PRESETN>,
> + <&cpg R9A07G043_ADC_ADRST_N>;
> + reset-names = "presetn", "adrst-n";
Not "adrst_n"?
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
2022-05-10 8:18 ` Sergei Shtylyov
@ 2022-05-10 8:24 ` Biju Das
2022-05-10 9:09 ` Sergey Shtylyov
0 siblings, 1 reply; 8+ messages in thread
From: Biju Das @ 2022-05-10 8:24 UTC (permalink / raw)
To: Sergei Shtylyov, Rob Herring, Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Magnus Damm,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Hi Sergei,
> Subject: Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
>
> Hello!
>
> On 5/5/22 9:43 PM, Biju Das wrote:
>
> > Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
> > 1 file changed, 20 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> > index b31fb713ae4d..40201a16d653 100644
> > --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> > @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
> > };
> >
> > adc: adc@10059000 {
> > + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-
> adc";
> > reg = <0 0x10059000 0 0x400>;
> > - /* place holder */
> > + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
> > + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
> > + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
> > + clock-names = "adclk", "pclk";
> > + resets = <&cpg R9A07G043_ADC_PRESETN>,
> > + <&cpg R9A07G043_ADC_ADRST_N>;
> > + reset-names = "presetn", "adrst-n";
>
> Not "adrst_n"?
As per bindings[1], it is correct ie, "adrst-n"
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml?h=next-20220509#n51
Cheers,
Biju
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
2022-05-10 8:24 ` Biju Das
@ 2022-05-10 9:09 ` Sergey Shtylyov
2022-05-10 9:15 ` Biju Das
0 siblings, 1 reply; 8+ messages in thread
From: Sergey Shtylyov @ 2022-05-10 9:09 UTC (permalink / raw)
To: Biju Das, Rob Herring, Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Magnus Damm,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
On 5/10/22 11:24 AM, Biju Das wrote:
[...]
>>> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
>>>
>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>> ---
>>> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
>>> 1 file changed, 20 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>> index b31fb713ae4d..40201a16d653 100644
>>> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
>>> };
>>>
>>> adc: adc@10059000 {
>>> + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-
>> adc";
>>> reg = <0 0x10059000 0 0x400>;
>>> - /* place holder */
>>> + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
>>> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
>>> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
>>> + clock-names = "adclk", "pclk";
>>> + resets = <&cpg R9A07G043_ADC_PRESETN>,
>>> + <&cpg R9A07G043_ADC_ADRST_N>;
>>> + reset-names = "presetn", "adrst-n";
>>
>> Not "adrst_n"?
>
> As per bindings[1], it is correct ie, "adrst-n"
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml?h=next-20220509#n51
Then I think the bindings aren't actually correct. But nevermind... :-)
> Cheers,
> Biju
MBR, Sergey
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
2022-05-10 9:09 ` Sergey Shtylyov
@ 2022-05-10 9:15 ` Biju Das
2022-05-10 18:36 ` Sergey Shtylyov
0 siblings, 1 reply; 8+ messages in thread
From: Biju Das @ 2022-05-10 9:15 UTC (permalink / raw)
To: Sergey Shtylyov, Rob Herring, Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Magnus Damm,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Hi Sergei,
Thanks for the feedback.
> Subject: Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
>
> On 5/10/22 11:24 AM, Biju Das wrote:
> [...]
>
> >>> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
> >>>
> >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>> ---
> >>> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
> >>> 1 file changed, 20 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>> index b31fb713ae4d..40201a16d653 100644
> >>> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
> >>> };
> >>>
> >>> adc: adc@10059000 {
> >>> + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-
> >> adc";
> >>> reg = <0 0x10059000 0 0x400>;
> >>> - /* place holder */
> >>> + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
> >>> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
> >>> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
> >>> + clock-names = "adclk", "pclk";
> >>> + resets = <&cpg R9A07G043_ADC_PRESETN>,
> >>> + <&cpg R9A07G043_ADC_ADRST_N>;
> >>> + reset-names = "presetn", "adrst-n";
> >>
> >> Not "adrst_n"?
> >
> > As per bindings[1], it is correct ie, "adrst-n"
> >
> >
>
> Then I think the bindings aren't actually correct. But nevermind... :-)
Why do you think it is not correct? What difference it make, changing from
adrst-n->adrst_n? Is it violating any DT specification?
Please clarify.
Regards,
Biju
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
2022-05-10 9:15 ` Biju Das
@ 2022-05-10 18:36 ` Sergey Shtylyov
2022-05-11 5:52 ` Biju Das
0 siblings, 1 reply; 8+ messages in thread
From: Sergey Shtylyov @ 2022-05-10 18:36 UTC (permalink / raw)
To: Biju Das, Rob Herring, Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Magnus Damm,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
On 5/10/22 12:15 PM, Biju Das wrote:
[...]
>>>>> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
>>>>>
>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>>>> ---
>>>>> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
>>>>> 1 file changed, 20 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>>> index b31fb713ae4d..40201a16d653 100644
>>>>> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>>> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
>>>>> };
>>>>>
>>>>> adc: adc@10059000 {
>>>>> + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-
>>>> adc";
>>>>> reg = <0 0x10059000 0 0x400>;
>>>>> - /* place holder */
>>>>> + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
>>>>> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
>>>>> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
>>>>> + clock-names = "adclk", "pclk";
>>>>> + resets = <&cpg R9A07G043_ADC_PRESETN>,
>>>>> + <&cpg R9A07G043_ADC_ADRST_N>;
>>>>> + reset-names = "presetn", "adrst-n";
>>>>
>>>> Not "adrst_n"?
>>>
>>> As per bindings[1], it is correct ie, "adrst-n"
>>
>> Then I think the bindings aren't actually correct. But nevermind... :-)
>
> Why do you think it is not correct? What difference it make, changing from
> adrst-n->adrst_n? Is it violating any DT specification?
>
> Please clarify.
No, I don't think this violates the DT spec. It just doesn't feel right to
convert underscores to hyphens in the "reset-names" prop...
> Regards,
> Biju
MBR, Sergey
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
2022-05-10 18:36 ` Sergey Shtylyov
@ 2022-05-11 5:52 ` Biju Das
0 siblings, 0 replies; 8+ messages in thread
From: Biju Das @ 2022-05-11 5:52 UTC (permalink / raw)
To: Sergey Shtylyov, Rob Herring, Krzysztof Kozlowski
Cc: Geert Uytterhoeven, Magnus Damm,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Hi Sergei,
> Subject: Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
>
> On 5/10/22 12:15 PM, Biju Das wrote:
> [...]
>
> >>>>> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
> >>>>>
> >>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>>>> ---
> >>>>> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21
> >>>>> ++++++++++++++++++++-
> >>>>> 1 file changed, 20 insertions(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>>> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>>>> index b31fb713ae4d..40201a16d653 100644
> >>>>> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
> >>>>> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
> >>>>> };
> >>>>>
> >>>>> adc: adc@10059000 {
> >>>>> + compatible = "renesas,r9a07g043-adc",
> "renesas,rzg2l-
> >>>> adc";
> >>>>> reg = <0 0x10059000 0 0x400>;
> >>>>> - /* place holder */
> >>>>> + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
> >>>>> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
> >>>>> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
> >>>>> + clock-names = "adclk", "pclk";
> >>>>> + resets = <&cpg R9A07G043_ADC_PRESETN>,
> >>>>> + <&cpg R9A07G043_ADC_ADRST_N>;
> >>>>> + reset-names = "presetn", "adrst-n";
> >>>>
> >>>> Not "adrst_n"?
> >>>
> >>> As per bindings[1], it is correct ie, "adrst-n"
> >>
> >> Then I think the bindings aren't actually correct. But
> >> nevermind... :-)
> >
> > Why do you think it is not correct? What difference it make, changing
> > from
> > adrst-n->adrst_n? Is it violating any DT specification?
> >
> > Please clarify.
>
> No, I don't think this violates the DT spec. It just doesn't feel right
> to convert underscores to hyphens in the "reset-names" prop...
Ok, Thanks for clarification, since it is not violating any Spec,
It is just matter of personal taste.
Cheers,
BIju
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
2022-05-05 18:43 [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node Biju Das
2022-05-10 8:18 ` Sergei Shtylyov
@ 2022-05-17 8:14 ` Geert Uytterhoeven
1 sibling, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2022-05-17 8:14 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Krzysztof Kozlowski, Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
On Thu, May 5, 2022 at 8:44 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-05-17 8:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-05 18:43 [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node Biju Das
2022-05-10 8:18 ` Sergei Shtylyov
2022-05-10 8:24 ` Biju Das
2022-05-10 9:09 ` Sergey Shtylyov
2022-05-10 9:15 ` Biju Das
2022-05-10 18:36 ` Sergey Shtylyov
2022-05-11 5:52 ` Biju Das
2022-05-17 8:14 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox