From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Yong Wu <yong.wu@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
anan.sun@mediatek.com, lc.kan@mediatek.com, yi.kuo@mediatek.com,
anthony.huang@mediatek.com,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning
Date: Wed, 12 Jan 2022 11:18:04 +0100 [thread overview]
Message-ID: <b8b8fe77-2ea8-d05c-5fa2-d4cae01baba5@canonical.com> (raw)
In-Reply-To: <20220111063904.7583-3-yong.wu@mediatek.com>
On 11/01/2022 07:39, Yong Wu wrote:
> Mute the warning from "make dtbs_check":
>
> larb@14017000: clock-names: ['apb', 'smi'] is too short
> arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml
> ...
>
> larb@16010000: clock-names: ['apb', 'smi'] is too short
> arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml
>
> larb@17010000: clock-names: ['apb', 'smi'] is too short
> arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml
>
> If a platform's larb supports gals, there will be some larbs have one
> more "gals" clock while the others still only need "apb"/"smi" clocks,
> then the minItems for clock and clock-names are 2.
>
> Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> index 80907e357892..884c0c74e5e4 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> @@ -80,10 +80,10 @@ allOf:
> then:
> properties:
> clock:
Separate patch:
This should be clocks. The same in second if. Now it is simply not
working...
> - items:
Putting min/maxItems under items is wrong. The second if also needs the
fixing. Please make it a separate patch before this one.
The schema was clearly not tested before...
> - minItems: 3
> - maxItems: 3
> + minItems: 2
> + maxItems: 3
> clock-names:
> + minItems: 2
> items:
> - const: apb
> - const: smi
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-01-12 10:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 6:38 [PATCH v2 0/6] MT8186 SMI SUPPORT Yong Wu
2022-01-11 6:38 ` [PATCH v2 1/6] dt-bindings: memory: mtk-smi: Fix larb-id dtbs_check warning Yong Wu
2022-01-12 10:11 ` Krzysztof Kozlowski
2022-01-11 6:39 ` [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning Yong Wu
2022-01-12 10:18 ` Krzysztof Kozlowski [this message]
2022-01-13 6:06 ` Yong Wu
2022-01-11 6:39 ` [PATCH v2 3/6] dt-bindings: memory: mediatek: Add mt8186 support Yong Wu
2022-01-11 6:39 ` [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable Yong Wu
2022-01-11 9:10 ` AngeloGioacchino Del Regno
2022-01-13 6:05 ` Yong Wu
2022-01-12 10:20 ` Krzysztof Kozlowski
2022-01-11 6:39 ` [PATCH v2 5/6] memory: mtk-smi: Add sleep ctrl function Yong Wu
2022-01-11 9:14 ` AngeloGioacchino Del Regno
2022-01-12 10:27 ` Krzysztof Kozlowski
2022-01-13 6:02 ` Yong Wu
2022-01-11 6:39 ` [PATCH v2 6/6] memory: mtk-smi: mt8186: Add smi support Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b8fe77-2ea8-d05c-5fa2-d4cae01baba5@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=lc.kan@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).