From: David Veenstra <davidjulianveenstra@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, pmeerw@pmeerw.net
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
robh+dt@kernel.org, knaack.h@gmx.de, daniel.baluta@nxp.com
Subject: [PATCH v3 4/9] staging: iio: ad2s1200: Replace platform data with dt bindings
Date: Mon, 23 Apr 2018 00:03:32 +0200 [thread overview]
Message-ID: <b8cfea845842947415b5da44b59ed305c93cceda.1524432236.git.davidjulianveenstra@gmail.com> (raw)
In-Reply-To: <cover.1524432236.git.davidjulianveenstra@gmail.com>
Remove usage of platform data, and replace it with device tree
facilities.
Signed-off-by: David Veenstra <davidjulianveenstra@gmail.com>
---
Changes in v3:
- Introduced in this version.
drivers/staging/iio/resolver/ad2s1200.c | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c
index e7bfe5aa4c45..3c7163610ff6 100644
--- a/drivers/staging/iio/resolver/ad2s1200.c
+++ b/drivers/staging/iio/resolver/ad2s1200.c
@@ -26,9 +26,6 @@
#define DRV_NAME "ad2s1200"
-/* input pin sample and rdvel is controlled by driver */
-#define AD2S1200_PN 2
-
/* input clock on serial interface */
#define AD2S1200_HZ 8192000
/* clock period in nano second */
@@ -113,20 +110,9 @@ static const struct iio_info ad2s1200_info = {
static int ad2s1200_probe(struct spi_device *spi)
{
- unsigned short *pins = spi->dev.platform_data;
struct ad2s1200_state *st;
struct iio_dev *indio_dev;
- int pn, ret = 0;
-
- for (pn = 0; pn < AD2S1200_PN; pn++) {
- ret = devm_gpio_request_one(&spi->dev, pins[pn], GPIOF_DIR_OUT,
- DRV_NAME);
- if (ret) {
- dev_err(&spi->dev, "request gpio pin %d failed\n",
- pins[pn]);
- return ret;
- }
- }
+ int ret = 0;
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
if (!indio_dev)
@@ -136,8 +122,20 @@ static int ad2s1200_probe(struct spi_device *spi)
st = iio_priv(indio_dev);
mutex_init(&st->lock);
st->sdev = spi;
- st->sample = gpio_to_desc(pins[0]);
- st->rdvel = gpio_to_desc(pins[1]);
+
+ st->sample = devm_gpiod_get(&spi->dev, "sample", GPIOD_OUT_LOW);
+ if (IS_ERR(st->sample)) {
+ dev_err(&spi->dev, "Failed to claim SAMPLE gpio: err=%ld\n",
+ PTR_ERR(st->sample));
+ return PTR_ERR(st->sample);
+ }
+
+ st->rdvel = devm_gpiod_get(&spi->dev, "rdvel", GPIOD_OUT_LOW);
+ if (IS_ERR(st->rdvel)) {
+ dev_err(&spi->dev, "Failed to claim RDVEL gpio: err=%ld\n",
+ PTR_ERR(st->rdvel));
+ return PTR_ERR(st->rdvel);
+ }
indio_dev->dev.parent = &spi->dev;
indio_dev->info = &ad2s1200_info;
--
2.16.2
next prev parent reply other threads:[~2018-04-22 22:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 22:02 [PATCH v3 0/9] staging: iio: ad2s1200: Driver clean up David Veenstra
2018-04-22 22:02 ` [PATCH v3 1/9] staging: iio: ad2s1200: Add kernel docs to driver state David Veenstra
2018-04-28 17:11 ` Jonathan Cameron
2018-05-18 12:57 ` David Julian Veenstra
2018-04-22 22:03 ` [PATCH v3 2/9] staging: iio: ad2s1200: Improve readability with be16_to_cpup David Veenstra
2018-04-28 17:12 ` Jonathan Cameron
2018-04-22 22:03 ` [PATCH v3 3/9] staging: iio: ad2s1200: Replace legacy gpio API with modern API David Veenstra
2018-04-28 17:17 ` Jonathan Cameron
2018-04-22 22:03 ` David Veenstra [this message]
2018-04-28 17:20 ` [PATCH v3 4/9] staging: iio: ad2s1200: Replace platform data with dt bindings Jonathan Cameron
2018-04-22 22:03 ` [PATCH v3 5/9] staging: iio: ad2s1200: Add documentation for device tree binding David Veenstra
2018-04-27 14:48 ` Rob Herring
2018-04-28 15:27 ` Jonathan Cameron
2018-05-18 13:00 ` David Julian Veenstra
2018-04-27 14:49 ` Rob Herring
2018-04-22 22:03 ` [PATCH v3 6/9] staging: iio: ad2s1200: Add scaling factor for angular velocity channel David Veenstra
2018-04-28 17:23 ` Jonathan Cameron
2018-04-28 17:35 ` Jonathan Cameron
2018-05-18 13:10 ` David Julian Veenstra
2018-04-22 22:04 ` [PATCH v3 7/9] staging: iio: Documentation: Add missing sysfs docs for angle channel David Veenstra
2018-04-28 17:36 ` Jonathan Cameron
2018-04-22 22:04 ` [PATCH v3 8/9] staging: iio: ad2s1200: Add scaling factor " David Veenstra
2018-04-28 17:37 ` Jonathan Cameron
2018-04-22 22:04 ` [PATCH v3 9/9] staging: iio: ad2s1200: Move driver out of staging David Veenstra
2018-04-28 17:46 ` Jonathan Cameron
2018-05-18 13:17 ` David Julian Veenstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8cfea845842947415b5da44b59ed305c93cceda.1524432236.git.davidjulianveenstra@gmail.com \
--to=davidjulianveenstra@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).