From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683D536680F for ; Fri, 19 Jun 2026 09:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781862716; cv=none; b=DaWnO5izIDPhWgSWMS2IdwoYPl0Gj6Nwry1Z42R2dfPWOcQ43ULBa703AJ1bLscxcdCf1YciWWhFXmNAF+7rNbwIKjnyVcwSw/SXu8e6OSeXn7MymDhMBMknRCDBBbEw2wE+D/j+g5BjyTkB+AzX5zZmdumjQSllLgXVlX6Rne4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781862716; c=relaxed/simple; bh=/kWU03eUjVye6hhg9NUKgjZ45aHcq/mzn3B0UlaFXtg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UKVYywcUUS9Wy7rdT12K/GT5TGxdhHIuxGUNmFbvmu5Xc7Ttv9THOT7WxSroR5i0XyTrI1Pfhpdn70GwbxCq7KWlmWCJJ1cPjwXx1YdwzL9rlkPvs2RXE+WHtNdbiT9Y2gGMYcWhZhAEK+jHLuzQlJQKamH7ZMFRunIyu4hRb4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dTeWe7Q9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ko1pNhJR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dTeWe7Q9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ko1pNhJR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65J7PpQO006979 for ; Fri, 19 Jun 2026 09:51:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2h6bbHMCKo8QBg0xCoQbI1gK6dLPx7ToSsyB1dQ41Lo=; b=dTeWe7Q992PCmQNw hydDFe4n7/Yo6D2UA/JrjX3/IhxUSmsZVVbk5i1ysZYlHqaCPF3EZ9dMKSL4T1MG HJN27oz+qa7jBkUSXofWGEI1FJjmvfcYjn5YM0UjyzKRXZVVCy3aosCS+JRrK4o3 afPUf9NjyWPv5iey0fT+oUBXfqJReZ+SNAj39a81jlfetUwSOkdU0M2kSyQoz9AA BOwMkQ7FjmKgkSdhmlP0KI06EYCtjGyNqEebk85hffhLSPekLwzmm0wMgg7kN1jQ j9B+r3lVZgqukv3PBezzIdvanCwccxLXVqrW3/eCKsTqPjVGi2KwHF3bbyHSqega Co7BwQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4evm20kfbc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Jun 2026 09:51:47 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c0c32faa62so43776405ad.2 for ; Fri, 19 Jun 2026 02:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781862707; x=1782467507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2h6bbHMCKo8QBg0xCoQbI1gK6dLPx7ToSsyB1dQ41Lo=; b=ko1pNhJRcisz7BTkGVwOMiGhEWfFvCaQvxOn0uLegM6lQzWStCsOVFNtZeYseYSZMr IspjEeYMylq4/Dv850al36//Fu/3Y5xrpFlhr/chn6c1uU2ha6FJG+1r2Cwox4u7iM7i m6ObkQfRUme+z6jCkGykPkUpovX8Gx+qPcpjMCmOafjI8jPRZtzniPr9rBtGnMIoGGHr MQVDc+WygML8nR5bncWuFYCqDaKlnmG+Lbj8EyzJkFWMfZnwwyXVmk1RxN8Qn5m2Bs/n zeBRAGrGNZaOK3vZA2mwiJ+laY6AVWTzLMeAZwoRVvQN9OuGzu6wnRdxzyQchNiB0ZBz O4MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781862707; x=1782467507; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2h6bbHMCKo8QBg0xCoQbI1gK6dLPx7ToSsyB1dQ41Lo=; b=UwVTNz7bqlskjgrA0zX8cysqHzkyRISn1uqq23Ol8pgye1DEn4SuyV8Wy7uLXN6wgP WUAXAau4c99LWDayYzE8auHgrEwI6OXk/NPxB98syskuzI6mUuDdvhvWeDEVitEWa2IZ cyqWKVM1VWxqqXCpU/gLavQd+Fc/wDWj9eCaH9caEQG9Nn0jB+8fMwVfayz7ES74IOar HgBgdXDfLOY8Otw2t768bO4k60wnzekUuQn7WwhlRKd48+TzM1HMSWMRTHGNYRry/ZsD Qryk2OWJ5ziB1mvPtWVng6IRrEptS5Ouc7vRCQSxNAMU88ptAQzvB4hwpXQSxbrhGQWh ulgg== X-Forwarded-Encrypted: i=1; AFNElJ9abKcWeGPklBC8xNuPFDFfZPQtPOteX07jemX5XzjPHDdrfk1rfg8HzrzRRLRxFS0qmaobeFRTVluw@vger.kernel.org X-Gm-Message-State: AOJu0Yy3eXM9eam3TB/fVXkCRKmPMNG6AUUU7SlpS2keDumA7CGx+VKq rzCPl1faZILC0BXVqijB8PDzPcaJleoL3j2sXoodcyeF94HRYwwQBDo9jhbj2cpVlKKU4ZtMkIV 46XToRRKghlFaIvmNtTe78s5PNj+4gFgCae7cj6LBjnZem+1vJdGiN4kY7tGvqqbm X-Gm-Gg: AfdE7cn9Si3nh3rHSYy8uNPMCRTQNx8vOV4sACx5UwWDdBkYQMgSFFiFHIYAhu3bh0A Tj+8fc03sXRaPncUKI3cHyv2aYWFVCUxEft4y1k/2OprlfAg3TCmyi4HLGMSjP3Usjav6BpkSJi CA88ErbpcSdJRr5h+ZvNlmeWfdslmEZ3TAuwQYJzRQ4/3wQTibOEWxh2cQNPl3fLsYoSbcM6ob8 /e9pZA378XMznLudAxPE5mikV+ctdI0jr+4InpzoCh4usLBSJfR/wFaHGqmTZLsKfY/btP6QwYx aojkSuNzeAWv+0HIKPEi01q6vbWwjhW/AEhPtbWM6arVfoZisS2bvVEBZn+hqiHZhcyOmGKrwzE JNpFnG392CTqvZasGilhQfdFaLzP15wu1I6BAvQ== X-Received: by 2002:a17:902:ec82:b0:2c0:cf44:3b3b with SMTP id d9443c01a7336-2c725d7c843mr21063565ad.24.1781862706873; Fri, 19 Jun 2026 02:51:46 -0700 (PDT) X-Received: by 2002:a17:902:ec82:b0:2c0:cf44:3b3b with SMTP id d9443c01a7336-2c725d7c843mr21063035ad.24.1781862706405; Fri, 19 Jun 2026 02:51:46 -0700 (PDT) Received: from [10.219.56.41] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c720c23b8bsm17913045ad.80.2026.06.19.02.51.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 02:51:45 -0700 (PDT) Message-ID: Date: Fri, 19 Jun 2026 15:21:40 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU To: Konrad Dybcio , Dmitry Baryshkov Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com> <20260526-smmu_interconnect_addition-v2-3-2a6d8ca30d63@oss.qualcomm.com> <26d51cbb-2d87-4564-b3c6-cc61ab900e19@oss.qualcomm.com> <3384ecdf-599f-4862-a3c4-9f54b4ddfe63@oss.qualcomm.com> Content-Language: en-US From: Bibek Kumar Patro In-Reply-To: <3384ecdf-599f-4862-a3c4-9f54b4ddfe63@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE5MDA5MSBTYWx0ZWRfX9t7OrLHwnhgl UKXtqr9VUEwW/ekPkJgkCLiSdABKq9fvGfWTqE1yyZiBsqfgMCPLmOpFKfjPerGJ4zt6KhkGvIP h2eS8eQ0uBKqhyjQ3Vhl3rDxGghbFrrKVWj4WVUGMtAtO5MeSBApnPpEIxnFYlkUJCOPYI4iGks ojcBSLlKkCLD+QMsUwqAiDDiAR7p4aUyERvKoYkYoH1BHyvnptnQ5XcCkM5jLUbl2z7eOs7bN0V Huy5JsTnYKm2gTLvCB8nF7nTYVYTUTw0AwhNngT5Kk3Bb/CPHJa9quxUA87sfBIBlqM6od/D3pG AET5pw6fVFxAUONfVSr4maJIKHKRjyusKsAx6IYgqMisN9VHwVYVT8YZ3g4rrvEM2LVqAxVsGvx sq6v1Or7TYMuiKpaKiNTH9PRSjqSNzki233SqXkegxFCMH/YOnZU/f57oVAPXRNFj/w7NyIIHFN 0gz6G7zq0JmsVCQn4tA== X-Authority-Analysis: v=2.4 cv=GKw41ONK c=1 sm=1 tr=0 ts=6a351133 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=u9O3v9hlqvzur-BCVJ8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE5MDA5MSBTYWx0ZWRfX2jPVa+H6imJ6 CtsfjqNYlbYoXzgDSh5Y9eOjwRbVDYONDuwYNdkx+sH5i5UwgNrXgJjzCxG3CN/qLlRHUJ4iFo8 ihLW2ltLyOQoJJoJpIq1PYSgY2KHXRc= X-Proofpoint-GUID: OXrX7DCxPfi9Mq_j1zZqNnaV3PYixti6 X-Proofpoint-ORIG-GUID: OXrX7DCxPfi9Mq_j1zZqNnaV3PYixti6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-19_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606190091 On 6/18/2026 2:56 PM, Konrad Dybcio wrote: > On 6/8/26 4:37 PM, Bibek Kumar Patro wrote: >> >> >> On 6/8/2026 7:27 PM, Dmitry Baryshkov wrote: >>> On Tue, May 26, 2026 at 08:12:04PM +0530, Bibek Kumar Patro wrote: >>>> On Kodiak platforms, the Adreno SMMU requires a bandwidth vote on >>>> the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers >>>> are accessible. Without this vote, the SMMU may become unreachable, >>>> leading to intermittent probe failures and runtime issues. >>>> >>>> Add the required interconnect to ensure reliable register access. >>> >>> Does it only concern the GPU SMMU? What about the APPS SMMU? Should it >>> be voting on other interconnects too? I guess so, because currently I >>> see that TBUs vote for various interconnects. BTW: should apps_smmu also >>> vote on the power domains? >>> >> >> This race mainly occurs in GPU SMMU, where the GDSC can have an > > Mainly or exclusively? > It is exclusively in GPU SMMU as of now. We haven't seen any instance on other SMMU, e.g pcie AMMU, APPS SMMU. Also as per my understanding of the architecture which i mentioned earlier [1], this issue will only arise in GPU SMMU. Thanks & regards, Bibek > Konrad > >> independent vote on the Adreno SMMU. However, the GEM_NOC vote may >> already have been removed by the GPU (or any consumer of adreno_smmu, >> e.g gmu), unless it is explicitly voted by the GPU SMMU (which acts as a >> supplier for the GPU). This mismatch can lead to SHUB timeouts or NoC >> errors. >> >> Mostly this race reported in suspend/resume cycle (when gpu/gmu devices moves to slumber/suspend state before adreno_smmu powers down >> and the later doesn't have explicit interconnect voting). >> >> In the case of APPS SMMU, such a race is not expected for any known >> use case. APPS SMMU is part of a shared infrastructure block, and its >> power is typically kept enabled as long as attached master devices are >> active. Therefore, explicit power-domain voting from APPS SMMU may not >> be required. >> [1] >> Thanks, >> Bibek >> >> >>>> >>>> Signed-off-by: Bibek Kumar Patro >>>> --- >>>>   arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 ++ >>>>   1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> index fa540d8c2615dc02d941eb16bc7253204c2750bd..eefa4b836a81374ff437ab4bbcbc3fecc1590ab6 100644 >>>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> @@ -3386,6 +3386,8 @@ adreno_smmu: iommu@3da0000 { >>>>                 power-domains = <&gpucc GPU_CC_CX_GDSC>; >>>>               dma-coherent; >>>> +            interconnects = <&gem_noc MASTER_GPU_TCU QCOM_ICC_TAG_ALWAYS >>>> +                     &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; >>>>           }; >>>>             gfx_0_tbu: tbu@3dd9000 { >>>> >>>> -- >>>> 2.34.1 >>>> >>> >> >>