From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09E2E48551F; Fri, 18 Sep 2026 06:22:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789712540; cv=none; b=Njg+acyX4Z3D6ynfMsmB65Rj/sZq+3ntT68LTOP33ZxdPK9agOtWRCtaYPXYtETdLshNutVeYD7Uvxpy1hVKi0LWNPZCveL0IP5G5/Jtq91LdEp48k+WJ0P0WOgO4ns7LQk2CA2F+scxaT2IlJJmUiJaC584q56ypUjvvGLtHjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789712540; c=relaxed/simple; bh=rNMK1oveRj5l3CUKdcVnFNQ6+pbzm/NbL31Ljykro28=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eCKIoYLpmDwGnnUrk+XOUXTT0wRaKpaeXh299Z2LzsGOpsHSBIrWDctFsQaITfcbrWPU1VCstTt/WZXkwzmsOylfQLeEFSdsvqhR2nkR8VihjvMmj8IMQmM5AfdeMKJDWTTbOafn+58D2k7552Hyu9PkAeiANb6h2V16FBKpnVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from edelgard.fodlan.icenowy.me (unknown [112.94.103.44]) by APP-01 (Coremail) with SMTP id qwCowADnuu5y2KxqkbJICA--.14966S2; Fri, 18 Sep 2026 14:21:41 +0800 (CST) Message-ID: Subject: Re: [PATCH v4 01/20] dt-bindings: phy: Add starfive,jh7110-inno-hdmi-phy From: Icenowy Zheng To: Krzysztof Kozlowski , Joshua Peisach Cc: Michal Wilczynski , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lee Jones , Andy Yan , Philipp Zabel , Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Heiko Stuebner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Dominique Belhachemi , Brian Masney , Jerome Brunet , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, Marek Szyprowski , Maud Spierings , Graham Markall , Chaoyi Chen , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Date: Fri, 18 Sep 2026 14:21:37 +0800 In-Reply-To: <20260918-futuristic-mindful-waxbill-21fa2d@quoll> References: <20260915-jh7110-clean-send-v4-0-f0e4fd6f2cc8@samsung.com> <20260915-jh7110-clean-send-v4-1-f0e4fd6f2cc8@samsung.com> <20260917-mutant-chamois-of-competence-46ca77@quoll> <20260918-futuristic-mindful-waxbill-21fa2d@quoll> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID:qwCowADnuu5y2KxqkbJICA--.14966S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tw4xKF13WFyUCw1UKF1rWFg_yoW5Jr18pF WDK3ZIkr4DJr1xAwn293WjgryF9w47A34Yqry5Wryjvr98tF1rtr4xGr45u3WDKr4fWr42 vF1jk34fu3sYyaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvGb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwV C2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7 MxkF7I0En4kS14v26rWY6Fy7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWrXVW8Jr1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6x IIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvE x4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa 73UjIFyTuYvjxU9PfHDUUUU X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ =E5=9C=A8 2026-09-18=E4=BA=94=E7=9A=84 08:16 +0200=EF=BC=8CKrzysztof Kozlow= ski=E5=86=99=E9=81=93=EF=BC=9A > On Thu, Sep 17, 2026 at 08:34:18PM -0400, Joshua Peisach wrote: > > On Thu Sep 17, 2026 at 2:51 AM EDT, Krzysztof Kozlowski wrote: > > > On Tue, Sep 15, 2026 at 05:32:09PM +0200, Michal Wilczynski > > > wrote: > > > > Add the dt-binding for the StarFive JH7110 Innosilicon HDMI > > > > PHY. > > > >=20 > > > > This device is a child of the starfive,jh7110-hdmi-subsystem > > > > node. It > > > > functions as both a PHY provider for the controller and as a > > > > clock > > > > provider for the variable pixel clock (hdmi_pclk), which it > > > > generates > > > > from its refoclk. > > > >=20 > > > > Reviewed-by: Joshua Peisach > > >=20 > > > While I appreciate other people looking at this, I don't think > > > review > > > here applies. It was a blanket tag, given to the entire series, > > > with > > > exception that it is from newbie, thus I want to ask: was this > > > binding > > > REALLY reviewed by Joshua? > > >=20 > > > Are the rest of the patches actually reviewed or just "looks good > > > to > > > me"? I see no comments from Joshua on v3, v2 and v1, which is > > > usual sign > > > of doing review. > > >=20 > > >=20 > > I commented on v3 saying that I would test if I could. I don't just >=20 > Testing has nothing to do with reviewing. >=20 > > throw "Reviewed-by" on everything I look at. > >=20 > > If anything, I've been trying to be more honest in reviews, and > > only > > review ones that I actually care about[1]. >=20 > You gave blanket tag for entire series, so I do not get this > argument. >=20 > >=20 > > If reviewing patches isn't a good way for newbies to start getting > > familiar with the kernel code (especially a NEW driver), then I > > don't > > know what is. >=20 > Writing code and receiving review is something for newbies to start > with. If you do not know kernel code or bindings, why do you think > your review is applicable? If I try to review design of a post- > tension > concrete bridge, I would probably learn something. Would my > review apply? No. My personal thoughts: everyone should be able to send R-b, but the effect of the R-b depends on who sent it. In this case, I am okay about adding Joshua's R-b, but I don't necessarily think the patchset is reviewed enough because of this R-b. Thanks, Icenowy >=20 > Best regards, > Krzysztof >=20 >=20 > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv