From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bhavin Sharma <bhavin.sharma@siliconsignals.io>, sre@kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] power: supply: Add STC3117 fuel gauge unit driver
Date: Sat, 6 Jan 2024 17:53:31 +0100 [thread overview]
Message-ID: <b8f417a0-14b1-4d02-92d1-bf9469d38eb1@linaro.org> (raw)
In-Reply-To: <20240106133546.936261-1-bhavin.sharma@siliconsignals.io>
On 06/01/2024 14:35, Bhavin Sharma wrote:
> Adding support for stc3117 fuel gauge driver with
> minimal functionality to read voltage level currently
>
> Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io>
> ---
> drivers/power/supply/Kconfig | 7 ++
> drivers/power/supply/Makefile | 1 +
> drivers/power/supply/stc3117_fuel_gauge.c | 136 ++++++++++++++++++++++
> 3 files changed, 144 insertions(+)
> create mode 100644 drivers/power/supply/stc3117_fuel_gauge.c
>
I see now that you got review for your v1. You must implement it fully.
Second, don't send patchsets more often than one per day to allow people
to actually review your code. Especially if you do not test it (neither
v1 nor v2!).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-06 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 13:35 [PATCH v2 1/2] power: supply: Add STC3117 fuel gauge unit driver Bhavin Sharma
2024-01-06 13:35 ` [PATCH v2 2/2] dt-bindings: power: supply: stc3117: Convert to DT schema format Bhavin Sharma
2024-01-06 14:36 ` Rob Herring
2024-01-06 16:48 ` Krzysztof Kozlowski
2024-01-06 16:52 ` [PATCH v2 1/2] power: supply: Add STC3117 fuel gauge unit driver Krzysztof Kozlowski
2024-01-06 16:53 ` Krzysztof Kozlowski [this message]
2024-01-07 22:11 ` kernel test robot
2024-01-11 15:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f417a0-14b1-4d02-92d1-bf9469d38eb1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bhavin.sharma@siliconsignals.io \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).