devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Kelly <mkelly@xevo.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	Jonathan Cameron <jic23@kernel.org>,
	Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
Subject: Re: [PATCH v4 2/2] dt-bindings: iio:imu:mpu6050: support more interrupt types
Date: Tue, 10 Apr 2018 11:11:05 -0700	[thread overview]
Message-ID: <b90d4517-3eee-546d-db6c-2f7a7416a943@xevo.com> (raw)
In-Reply-To: <20180410141237.4jozljz6d5okwo2r@rob-hp-laptop>

On 04/10/2018 07:12 AM, Rob Herring wrote:
> On Fri, Apr 06, 2018 at 03:00:48PM -0700, Martin Kelly wrote:
>> Document that the inv_mpu6050 driver now supports falling edge, rising
> 
> It's really about what the h/w supports for bindings.
> 

I understand that about devicetree in general, though in this case the 
device supports all these types but the driver did not and would 
silently fail if you gave the wrong type. I wanted to document that it's 
now safe to use the other interrupt types, while before the 
documentation told you (correctly) to use only rising edge.

If you think it's a good idea, I will change the description to 
"Document that the MPU9250 supports ..." to clarify.

>> edge, level low, and level high interrupt types, rather than just rising
>> edge.
>>
>> The language used is the same as that in st_lsm6dsx.txt.
>>
>> Signed-off-by: Martin Kelly <mkelly@xevo.com>
>> ---
>>   Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt | 11 ++++++++---
>>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

  reply	other threads:[~2018-04-10 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 22:00 [PATCH v4 1/2] iio:imu: inv_mpu6050: support more interrupt types Martin Kelly
2018-04-06 22:00 ` [PATCH v4 2/2] dt-bindings: iio:imu:mpu6050: " Martin Kelly
2018-04-10 14:12   ` Rob Herring
2018-04-10 18:11     ` Martin Kelly [this message]
2018-04-09 19:08 ` [PATCH v4 1/2] iio:imu: inv_mpu6050: " Jean-Baptiste Maneyrol
2018-04-09 20:23   ` Martin Kelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b90d4517-3eee-546d-db6c-2f7a7416a943@xevo.com \
    --to=mkelly@xevo.com \
    --cc=JManeyrol@invensense.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).