From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bl2nam02on0066.outbound.protection.outlook.com ([104.47.38.66]:35616 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751803AbeDJSLP (ORCPT ); Tue, 10 Apr 2018 14:11:15 -0400 Subject: Re: [PATCH v4 2/2] dt-bindings: iio:imu:mpu6050: support more interrupt types References: <20180406220048.29498-1-mkelly@xevo.com> <20180406220048.29498-2-mkelly@xevo.com> <20180410141237.4jozljz6d5okwo2r@rob-hp-laptop> From: Martin Kelly Message-ID: Date: Tue, 10 Apr 2018 11:11:05 -0700 MIME-Version: 1.0 In-Reply-To: <20180410141237.4jozljz6d5okwo2r@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Rob Herring Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Jonathan Cameron , Jean-Baptiste Maneyrol List-ID: On 04/10/2018 07:12 AM, Rob Herring wrote: > On Fri, Apr 06, 2018 at 03:00:48PM -0700, Martin Kelly wrote: >> Document that the inv_mpu6050 driver now supports falling edge, rising > > It's really about what the h/w supports for bindings. > I understand that about devicetree in general, though in this case the device supports all these types but the driver did not and would silently fail if you gave the wrong type. I wanted to document that it's now safe to use the other interrupt types, while before the documentation told you (correctly) to use only rising edge. If you think it's a good idea, I will change the description to "Document that the MPU9250 supports ..." to clarify. >> edge, level low, and level high interrupt types, rather than just rising >> edge. >> >> The language used is the same as that in st_lsm6dsx.txt. >> >> Signed-off-by: Martin Kelly >> --- >> Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) > > Reviewed-by: Rob Herring >