From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: jic23@kernel.org, lars@metafoo.de, lgirdwood@gmail.com,
broonie@kernel.org, Michael.Hennerich@analog.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings:iio:adc: add max14001
Date: Fri, 9 Jun 2023 17:33:01 +0200 [thread overview]
Message-ID: <b913e3a3-bc32-8d2f-c2a9-9c7e860b7b15@linaro.org> (raw)
In-Reply-To: <20230608175517.40217-2-kimseer.paller@analog.com>
On 08/06/2023 19:55, Kim Seer Paller wrote:
> The MAX14001 is configurable, isolated 10-bit ADCs for multi-range
> binary inputs.
Subject: still missing spaces, no improvements.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
With subject fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you do not know the process, here is a short
explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for acks received on the version
they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-09 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 17:55 [PATCH v3 0/2] Add max14001 support Kim Seer Paller
2023-06-08 17:55 ` [PATCH v3 1/2] dt-bindings:iio:adc: add max14001 Kim Seer Paller
2023-06-09 15:33 ` Krzysztof Kozlowski [this message]
2023-06-08 17:55 ` [PATCH v3 2/2] iio: adc: max14001: New driver Kim Seer Paller
2023-06-10 18:17 ` Jonathan Cameron
[not found] <20230608174413.39959-1-kimseer.paller@analog.com>
2023-06-08 17:44 ` [PATCH v3 1/2] dt-bindings:iio:adc: add max14001 Kim Seer Paller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b913e3a3-bc32-8d2f-c2a9-9c7e860b7b15@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kimseer.paller@analog.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).