From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FCC83AF66C for ; Sun, 30 Aug 2026 13:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788095205; cv=none; b=T9o2QNjdZmH3jY634TDXQ7uDTB+SW7fHbhQlsn50B2ygUEGL9TD6PxPtQjPLbK7ug2IlEJ+al+wg9AiRmXfzAzzPULqxlpScg2XCOhc7XtZJt40Z3NKXYPQLjTMWKO0sLfiZMGpY1EP8bWA25+NAuSgNTNjvNUaF5CCtrnlsSvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788095205; c=relaxed/simple; bh=WjEdZj/N+aOfZRtaHCBCBk/U7+N/dXvDf3LoxLpJh4Y=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=R9kRp5B3QlyGvWRc7hbpaCx4NVZb0VrF0yFMr5aDt9GkP9IHj/IkKvNE9rA4tqr/HCZakNeNuZcXDG3XFPCGRgiHdaDNciLWaBA6lVecSqNrvjFs1rgrftGDufUcRettosudMnKvnRT1V4RbRkyJ3KRT05TZACPvWXAsmC7xswU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aK1cIaHn; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aK1cIaHn" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49b9320423cso25047035e9.0 for ; Sun, 30 Aug 2026 06:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1788095201; x=1788700001; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jq+ZfaXrZvTkZsYgTJsjcj34MHFpmYRP4Z0eWcu7sE0=; b=aK1cIaHnG0w75USItbRI0E+X1hYDgQkdqMGGamw3fzLpFXI9NNq9tz2gWRiNE97lCY 0vGhj10NtHt/ZRD7ghLbtHcz7qnv+LnOWkFuGKhWV/pU5HoiadiGNGvYA3PHAuUZTg/I aJhIQoo70Mq73/XciZzdxvRcVjg7XCmD1qfJMwKcx2x/ibD9j5vMLpYU2EFj/4FivuA8 k+UPaw2m29qvE+AFj3MKpJ2wi4AjRA3BbwiuPdfR+EPffzk2YBo0HXUVXEfPVdRBb4RG ilDcuj+5bJq4+85d24mkR9I6Yu+GzfRf6i9rZE+rYlTYbBknM6Q04+Z7nABv7joWzith yDDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788095201; x=1788700001; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=jq+ZfaXrZvTkZsYgTJsjcj34MHFpmYRP4Z0eWcu7sE0=; b=W3HVcP/BzFfaEVldoasDePUqEdMFdD+ioQLIP+Kqi7FOkTq8gdCW3GVds8N4zihV9N 4w3PdCEZdBqWw/cSAjQv9gyuipw1Mkjly3pJkg3XBdUDWROPA0nRJ7pxSyeQ6AOx5rGA gEctU1ZVi+MOfzWtvtHJ5TMaB0h5hvwhCqUxiGgIqsSz2EDVxGYD+erSRrXWa8wrNohm ineQO8yz/IhJ7UglarZyhR9v9btmADOZNhFK1uOojFg+BCY4WczsHW4rPWNg31J16gF2 KWHeeOX75v0eg9X3hleYUWX9Fvy+DWMRy2VeDn+gQI6JpDylH0vUt3XD6az9padV7gH/ /91Q== X-Forwarded-Encrypted: i=1; AHgh+Rr+b6FilePCM+VjcXN5QNzwGYj3nN++/auZmeteF9ymozfhOZP+dSP/4BokbtIDhJtbDFwB+9fWhdqN@vger.kernel.org X-Gm-Message-State: AFuF++m7ZPzThe2gVf3Q2OZ1UCk/T6zYA0NTUDA9DRkSPRAGwylNKogj H0MvFQ7AmY4wKXeIlJnxWFAA4wOeOVjDboXwgH3BlDsik2xFJKa98GzL4FkGU6bElB4= X-Gm-Gg: AR+sD12vRhR4yWapIaL5vcdgqr+6ofTi73o1ivc5Hg1tDu7yg8vE+LJKAQ3SnJI/dIZ fRTdbKylFJPf0Gfipm1Md5dICudLhjYyN+QO1AJLH81701Il2xzxaNQCsh7I4urA0BlvCh45JG+ m9xjii1tyxyn2S76YLuMqNjz+PNsynTiG8wrnv4vGM88dAiHoxdkrVCOpnBSffGd9HJHJccogXV q1ZYoeOfdqEsKW4wBt21jNc5P5ebndAE9F8BAReaHKP2qeqWQOvHJfzM4Irmlzh3QsmQJ2kBEyq T57Ji0ALAkZJESteYaio34Gb3uo2OcochKm3o885mp9qwGH3nbNQexonCDJiuPtVmH/vwUn1Knu XtLJynHa58Exi6xRXaIP3Ll07iimhnPVOHLDoVRlMrVHBUWeLofv92QF/QJcHsaDC1bI6JWuRQ0 uYhugkY07x5oyeCJjS10jEAIxHdsI4Ol4vU2gz94OJrnE6nnSd/fjWsqtzupQbsrDEhEhIE4xe X-Received: by 2002:a05:600c:19ca:b0:495:52a5:8829 with SMTP id 5b1f17b1804b1-49b91c47b3dmr274079255e9.11.1788095201493; Sun, 30 Aug 2026 06:06:41 -0700 (PDT) Received: from [192.168.1.36] ([83.214.235.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482fbb20713sm15406915f8f.21.2026.08.30.06.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Aug 2026 06:06:41 -0700 (PDT) Message-ID: Date: Sun, 30 Aug 2026 15:06:34 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 2/4] arm64: dts: amlogic: t7: fix the pin groups of two PWM outputs To: Lucas Tanure , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephen Boyd Cc: Jian Hu , Ronald Claveau , Brian Masney , Chuan Liu , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20260829094758.23248-1-tanure@linux.com> <20260829094758.23248-3-tanure@linux.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260829094758.23248-3-tanure@linux.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/29/26 11:47, Lucas Tanure wrote: > Two of the PWM outputs can each appear on more than one pin, but the > description named a single group that does not exist, so anything using > it refused to start. > > Name the real groups instead, one entry per pin, the same way the other > multi-pin PWM output is already described. > > Fixes: 2a2a7b9701a7 ("arm64: dts: amlogic: t7: Add PWM pinctrl nodes") > Assisted-by: Claude:claude-opus-5 > Signed-off-by: Lucas Tanure > --- > arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 32 ++++++++++++++++++--- > 1 file changed, 28 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi > index c3dc479b137d..8c4bd683cce0 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi > @@ -458,9 +458,25 @@ mux { > }; > }; > > - pwm_ao_g_pins: pwm-ao-g { > + pwm_ao_g_d11_pins: pwm-ao-g-d11 { > mux { > - groups = "pwm_ao_g"; > + groups = "pwm_ao_g_d11"; > + function = "pwm_ao_g"; > + bias-disable; > + }; > + }; > + > + pwm_ao_g_d7_pins: pwm-ao-g-d7 { > + mux { > + groups = "pwm_ao_g_d7"; > + function = "pwm_ao_g"; > + bias-disable; > + }; > + }; > + > + pwm_ao_g_e_pins: pwm-ao-g-e { > + mux { > + groups = "pwm_ao_g_e"; > function = "pwm_ao_g"; > bias-disable; > }; > @@ -474,9 +490,17 @@ mux { > }; > }; > > - pwm_ao_h_pins: pwm-ao-h { > + pwm_ao_h_d5_pins: pwm-ao-h-d5 { > + mux { > + groups = "pwm_ao_h_d5"; > + function = "pwm_ao_h"; > + bias-disable; > + }; > + }; > + > + pwm_ao_h_d10_pins: pwm-ao-h-d10 { > mux { > - groups = "pwm_ao_h"; > + groups = "pwm_ao_h_d10"; > function = "pwm_ao_h"; > bias-disable; > }; Reviewed-by: Neil Armstrong Thanks, Neil