devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Matthias Brugger <mbrugger@suse.com>,
	matthias.bgg@kernel.org, rafael@kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>
Cc: devicetree@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	Zhang Rui <rui.zhang@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml
Date: Wed, 31 May 2023 15:08:01 +0200	[thread overview]
Message-ID: <b93b6804-64f9-f9eb-418e-dd4d03d61240@linaro.org> (raw)
In-Reply-To: <31f25021-aaf5-a6ca-049d-bb47f62936b4@suse.com>

On 31/05/2023 14:42, Matthias Brugger wrote:
>>> +    soc {
>>> +      #address-cells = <2>;
>>> +      #size-cells = <2>;
>>> +
>>> +      auxadc: auxadc@11001000 {
>>> +        compatible = "mediatek,mt8173-auxadc";
>>> +        reg = <0 0x11001000 0 0x1000>;
>>> +        clocks = <&pericfg CLK_PERI_AUXADC>;
>>> +        clock-names = "main";
>>> +        #io-channel-cells = <1>;
>>> +      };
>>> +
>>> +      apmixedsys: clock-controller@10209000 {
>>> +        compatible = "mediatek,mt8173-apmixedsys";
>>> +        reg = <0 0x10209000 0 0x1000>;
>>> +        #clock-cells = <1>;
>>> +      };
>>
>> Drop both examples, not really relevant to thermal. It grows the example
>> with code already documented somewhere else.
>>
> 
> auxadc and apmixedsys are no examples. They are referenced by the thermal node 
> as described in the binding. Without them the example won't be complete.
> 

The example is complete, because you have phandles and that's enough.
the auxadc and apmixedsys have their own examples in their own bindings
- no need to duplicate them here.

Best regards,
Krzysztof


      reply	other threads:[~2023-05-31 13:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 15:04 [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml matthias.bgg
2023-05-30 15:04 ` [PATCH 2/2] arm64: dts: mt8173: Update thermal node matthias.bgg
2023-05-30 22:02 ` [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml Conor Dooley
2023-05-31  7:53   ` Krzysztof Kozlowski
2023-05-31  7:57 ` Krzysztof Kozlowski
2023-05-31 12:42   ` Matthias Brugger
2023-05-31 13:08     ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b93b6804-64f9-f9eb-418e-dd4d03d61240@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=amitk@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=matthias.bgg@kernel.org \
    --cc=mbrugger@suse.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).