Devicetree
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: Conor Dooley <conor@kernel.org>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Ahmed Naseef <naseefkm@gmail.com>,
	Benjamin Larsson <benjamin.larsson@genexis.eu>,
	Christian Marangi <ansuelsmth@gmail.com>,
	devicetree@vger.kernel.org, lei.dong@airoha.com,
	Linqi.zhang@airoha.com, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	mfd@lists.linux.dev,
	Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
	Rajeev.kumar@airoha.com, upstream@airoha.com,
	Weifeng.xu@airoha.com, zhengping.zhang@airoha.com
Subject: Re: [PATCH v2 5/7] dt-bindings: pinctrl: airoha: add AN7589
Date: Mon, 16 Nov 2026 18:47:27 +0100	[thread overview]
Message-ID: <b94ed5e4-cb80-4e05-9964-bb08a61aa1fd@phrozen.org> (raw)
In-Reply-To: <20261113-fame-smock-6ea3b8fadcd0@spud>

On Fri, Nov 13, 2026 at 05:40:42PM +0000, Conor Dooley wrote:
> As Lee requested, please split this out. Two patches, maybe even three.

Agreed. v3 splits it into three patches.

> Do we even need a child node here? If all this node does is
> gpio/pinctrl, why can the driver not bind directly to this node?
>
> What else does it do that warrants being a syscon?

The block also holds the PWM controller. Its registers interleave with
the GPIO ones. The PWM series adds it as a second child, as on the
EN7581. That series has a depency on this one so I have not posted it yet.

> Otherwise, there should only be one. uart1 and uart2 should have
> different nodes.

Agreed. v3 sets maxItems to 1. Only pcm_spi and pcie keep more, as
their groups carry different signals of one device.

> So here, maxItems should be 1 for similar reasons.

Agreed, v3 does this for i2c too.

> I'm also curious about why this goes up to 74. None of the functions
> have 74 pins, surely?

A conf node can set the same config on any set of pins. 74 is all the
pins. The EN7581 binding does the same with 58.

v3 will follow shortly.

        John



  reply	other threads:[~2026-11-16 17:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 18:59 [PATCH v2 0/7] pinctrl: airoha: add AN7589 support John Crispin
2026-11-12 18:59 ` [PATCH v2 1/7] pinctrl: airoha: make gpio register layout per SoC John Crispin
2026-11-12 18:59 ` [PATCH v2 2/7] pinctrl: airoha: add per pin mode field mux John Crispin
2026-11-12 18:59 ` [PATCH v2 3/7] pinctrl: airoha: make the chip SCU optional John Crispin
2026-11-13  8:12   ` Lorenzo Bianconi
2026-11-12 18:59 ` [PATCH v2 4/7] pinctrl: airoha: mux a requested GPIO through the IOMUX John Crispin
2026-11-12 18:59 ` [PATCH v2 5/7] dt-bindings: pinctrl: airoha: add AN7589 John Crispin
2026-11-13  9:45   ` Lee Jones
2026-11-13 17:40   ` Conor Dooley
2026-11-16 17:47     ` John Crispin [this message]
2026-11-16 18:15       ` Conor Dooley
2026-11-12 18:59 ` [PATCH v2 6/7] pinctrl: airoha: move the GPIO register offsets to the common header John Crispin
2026-11-12 18:59 ` [PATCH v2 7/7] pinctrl: airoha: add support of an7589 SoC John Crispin
2026-11-13  8:14   ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b94ed5e4-cb80-4e05-9964-bb08a61aa1fd@phrozen.org \
    --to=john@phrozen.org \
    --cc=Linqi.zhang@airoha.com \
    --cc=Rajeev.kumar@airoha.com \
    --cc=Weifeng.xu@airoha.com \
    --cc=ansuelsmth@gmail.com \
    --cc=benjamin.larsson@genexis.eu \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lei.dong@airoha.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=mikhail.kshevetskiy@iopsys.eu \
    --cc=naseefkm@gmail.com \
    --cc=robh@kernel.org \
    --cc=upstream@airoha.com \
    --cc=zhengping.zhang@airoha.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox