From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 08/10] dt-bindings: media: qcom: Add Qualcomm MIPI C-/D-PHY schema for CSIPHY IPs
Date: Fri, 13 Jun 2025 08:28:35 +0200 [thread overview]
Message-ID: <b96f9cca-cdd4-4456-8ced-f4a8fd810ff1@kernel.org> (raw)
In-Reply-To: <e9afdd0f-7842-4780-9044-d5afa6a09d7f@linaro.org>
On 12/06/2025 19:13, Vladimir Zapolskiy wrote:
> On 6/12/25 10:38, Krzysztof Kozlowski wrote:
>> On 12/06/2025 03:15, Vladimir Zapolskiy wrote:
>>> Add dt-binding schema for Qualcomm CAMSS CSIPHY IP, which provides
>>> MIPI C-PHY/D-PHY interfaces on Qualcomm SoCs.
>>>
>>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>> ---
>
> <snip>
>
>>> +
>>> + clocks:
>>> + maxItems: 2
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: csiphy
>>> + - const: csiphy_timer
>>
>> Drop csiphy from both, redundant. And this points to the first clock
>> name not having any useful name. Name equal to device name is not useful.
>>
>
> I got the rationale, but I have no idea how to correct it, since it's
> literally the case, the first clock name on the list in 'csiphy'.
What do you mean by "list"? You can point me also to internal
documentation if that helps.
>
> What could be an alternative name then?..
The real clock input name, signal name. You can also drop the names.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-13 6:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 1:15 [PATCH 00/10] media: qcom: camss: add support for csiphy devices Vladimir Zapolskiy
2025-06-12 1:15 ` [PATCH 01/10] media: qcom: camss: remove never used camss_vfe_get()/camss_vfe_put() Vladimir Zapolskiy
2025-06-12 7:31 ` Bryan O'Donoghue
2025-06-12 1:15 ` [PATCH 02/10] media: qcom: camss: remove subdev resource argument from msm_csiphy_subdev_init() Vladimir Zapolskiy
2025-06-12 7:37 ` Bryan O'Donoghue
2025-06-12 1:15 ` [PATCH 03/10] media: qcom: camss: csiphy: simplify arguments of lanes_enable and lanes_disable Vladimir Zapolskiy
2025-06-12 8:02 ` Bryan O'Donoghue
2025-06-12 1:15 ` [PATCH 04/10] media: qcom: camss: populate CAMSS children subdevices of CSIPHY IPs Vladimir Zapolskiy
2025-06-12 1:15 ` [PATCH 05/10] media: qcom: camss: unwrap platform driver registration Vladimir Zapolskiy
2025-06-12 1:15 ` [PATCH 06/10] media: qcom: camss: export camss_parse_endpoint_node() to csiphy Vladimir Zapolskiy
2025-06-12 1:15 ` [PATCH 07/10] media: qcom: camss: csiphy: probe any present children CSIPHY subdevices Vladimir Zapolskiy
2025-06-12 1:15 ` [PATCH 08/10] dt-bindings: media: qcom: Add Qualcomm MIPI C-/D-PHY schema for CSIPHY IPs Vladimir Zapolskiy
2025-06-12 7:25 ` Krzysztof Kozlowski
2025-06-12 7:38 ` Krzysztof Kozlowski
2025-06-12 7:39 ` Krzysztof Kozlowski
2025-06-12 7:57 ` Vladimir Zapolskiy
2025-06-12 11:02 ` Krzysztof Kozlowski
2025-06-12 11:27 ` Vladimir Zapolskiy
2025-06-12 11:36 ` Krzysztof Kozlowski
2025-06-12 16:17 ` Konrad Dybcio
2025-06-12 16:44 ` Vladimir Zapolskiy
2025-06-14 19:29 ` Konrad Dybcio
2025-06-12 17:13 ` Vladimir Zapolskiy
2025-06-13 6:28 ` Krzysztof Kozlowski [this message]
2025-06-14 19:31 ` Konrad Dybcio
2025-06-17 6:32 ` Krzysztof Kozlowski
2025-06-17 9:51 ` Vladimir Zapolskiy
2025-06-17 19:20 ` Konrad Dybcio
2025-06-17 21:30 ` Vladimir Zapolskiy
2025-08-11 10:53 ` Dmitry Baryshkov
2025-06-12 1:15 ` [PATCH 09/10] [RFT] arm64: dts: qcom: sm8250: extend CAMSS with new CSIPHY subdevices Vladimir Zapolskiy
2025-06-12 7:43 ` Krzysztof Kozlowski
2025-06-12 16:25 ` Konrad Dybcio
2025-06-12 17:03 ` Vladimir Zapolskiy
2025-06-23 9:31 ` Neil Armstrong
2025-06-23 13:06 ` Vladimir Zapolskiy
2025-08-07 12:37 ` Bryan O'Donoghue
2025-08-07 14:17 ` Neil Armstrong
2025-08-07 15:07 ` Bryan O'Donoghue
2025-08-09 9:26 ` Dmitry Baryshkov
2025-08-09 11:51 ` Bryan O'Donoghue
2025-06-12 1:15 ` [PATCH 10/10] [RFT] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: switch to new CSIPHY scheme Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96f9cca-cdd4-4456-8ced-f4a8fd810ff1@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).