From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3D4C4332F for ; Thu, 17 Nov 2022 12:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240046AbiKQMOH (ORCPT ); Thu, 17 Nov 2022 07:14:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240032AbiKQMOF (ORCPT ); Thu, 17 Nov 2022 07:14:05 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08928697FC for ; Thu, 17 Nov 2022 04:14:04 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id l12so2477834lfp.6 for ; Thu, 17 Nov 2022 04:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ASBsFKuEewNKcc6V+qvTiKWEIdGA8lGcj9oKMILA6C4=; b=OizyyH6jpymDfxwhYPY1ZjQFuGm0wI/ZDUGRXv1NCePlEDzBGbsF41N4kxwKCwOR/2 e5GmFmlcmmGQpgpJBo3/cTLMniH9hKGI4XD2tJQEoqZGDiU7TXlbdrTgDxqbaqR7/DQ6 EBgJwlEKOv2902yamK5JTxU6rPh5xvfL/sY8uq+as8YQK5d2wmjlzqETCctnfvl5Kng+ NM2VmNfUdNxxOskq0jtSjtqClKKGm1Yg+aSa8DBCUbMXwyS8YgGroYDEKJsDMDuMIHW4 vYfgu43ba+XoKO6nSq5Q7Qp2YJr4l59hK5cbYN4TSYVDK9/Z+iHiT4EE+OFus1YuXgeW nf+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ASBsFKuEewNKcc6V+qvTiKWEIdGA8lGcj9oKMILA6C4=; b=FCSGJ4ov9QMmeo+Od8kCYd6q0l/7tL5f1AInzx1GQb+C/cHU744AgN93P06gWe8yxi eUY5SO9vJ4IPIh7APcFzkN70pGzrwfwCDvyGM6kCWIJfsI4NutNxVlan7dKjlp/FaxKg 2AUHJy31jSXYF9nRl6MOmCP6M54Kl4z1xAY1tlida29gGEuSTh40VjSUIy4VtL1HuUZE 4pNUZX2Y9i44dTt4iGrc/arFX/RYr937VKrwrjtVXDuipri+/Map3Ukf0fizDJB9snvO kuiX/FVxLJ8ll+vPjnF856ztZxCVqWzf34Fe48VNNk2R+Z6/O3OEF8D16z67WtehUY3n 9fIg== X-Gm-Message-State: ANoB5pkiGodVRxBACDY6TvefAzrsGe6fFLy4QZSM4k5ATZTc25aaR9t/ jQdVYaaKC9wqZT4QvT1Rftxrjw== X-Google-Smtp-Source: AA0mqf5NZECC0LuCmmfm6KLExVXnB+sUDNzVGLvI44r5THoEJgGAEx5Ir3NqDp6WOQ93SDt85//lEw== X-Received: by 2002:a05:6512:a93:b0:4a2:6337:872d with SMTP id m19-20020a0565120a9300b004a26337872dmr801504lfu.35.1668687242409; Thu, 17 Nov 2022 04:14:02 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m12-20020ac24acc000000b004a240eb0217sm118535lfp.251.2022.11.17.04.14.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 04:14:01 -0800 (PST) Message-ID: Date: Thu, 17 Nov 2022 13:14:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 01/12] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Content-Language: en-US To: Manivannan Sadhasivam Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, Dmitry Baryshkov , Rob Herring , andersson@kernel.org References: <20221103095810.64606-1-manivannan.sadhasivam@linaro.org> <20221103095810.64606-2-manivannan.sadhasivam@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221103095810.64606-2-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/11/2022 10:57, Manivannan Sadhasivam wrote: > As per the new ADC7 architecture used by the Qualcomm PMICs, each PMIC > has the static Slave ID (SID) assigned by default. The primary PMIC > PMK8350 is responsible for collecting the temperature/voltage data from > the slave PMICs and exposing them via it's registers. > > For getting the measurements from the slave PMICs, PMK8350 uses the > channel ID encoded with the SID of the relevant PMIC. So far, the > dt-binding for the slave PMIC PM8350 assumed that there will be only > one PM8350 in a system. So it harcoded SID 1 with channel IDs. > > But this got changed in platforms such as Lenovo X13s where there are a > couple of PM8350 PMICs available. So to address multiple PM8350s, change > the binding to accept the SID specified by the user and use it for > encoding the channel ID. > > It should be noted that, even though the SID is static it is not > globally unique. Only the primary PMIC has the unique SID id 0. > > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Krzysztof Kozlowski > Acked-by: Rob Herring > Signed-off-by: Manivannan Sadhasivam > --- This was never sent to IIO maintainers, so now next is failing. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Best regards, Krzysztof