From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
Vladimir Oltean <olteanv@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver
Date: Mon, 24 Oct 2022 16:04:05 -0700 [thread overview]
Message-ID: <b98e3074-e29c-df7e-f429-cc114f360370@gmail.com> (raw)
In-Reply-To: <Y1FXHDHxD4w7v3d1@lunn.ch>
On 10/20/22 07:11, Andrew Lunn wrote:
> On Wed, Oct 19, 2022 at 07:23:26PM -0700, Florian Fainelli wrote:
>>
>>
>> On 10/19/2022 1:35 AM, Yoshihiro Shimoda wrote:
>>> Add Renesas Ethernet Switch driver for R-Car S4-8 to be used as an
>>> ethernet controller.
>>>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>
>> How can this be a switch driver when it does not include any switchdev
>> header files nor does it attempt to be using the DSA framework? You are
>> certainly duplicating a lot of things that DSA would do for you like
>> managing PHYs and registering per-port nework devices. Why?
>
> Hi Florian
>
> It is not clear yet if this is actually a DSA switch. I asked these
> questions a few revisions ago and it actually looks like it is a pure
> switchdev switch. It might be possible to make it a DSA switch. It is
> a bit fuzzy, since it is all internal and integrated.
We were dealing with an integrated Ethernet MAC and switch back in 2014
when DSA was resurrected to support bcm_sf2 + bcmsysport, also, we are
about to get support for in-band DSA tags with Maxime's patch series.
I suppose that as long as the binding is conforming, we can always make
the driver evolve, it would be good to see all of the pieces now though.
--
Florian
next prev parent reply other threads:[~2022-10-25 0:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 8:35 [PATCH v4 0/3] net: ethernet: renesas: Add Ethernet Switch driver Yoshihiro Shimoda
2022-10-19 8:35 ` [PATCH v4 1/3] dt-bindings: net: renesas: Document Renesas Ethernet Switch Yoshihiro Shimoda
2022-10-19 12:37 ` Krzysztof Kozlowski
2022-10-20 1:31 ` Yoshihiro Shimoda
2022-10-20 12:30 ` Krzysztof Kozlowski
2022-10-19 8:35 ` [PATCH v4 2/3] net: ethernet: renesas: Add Ethernet Switch driver Yoshihiro Shimoda
2022-10-19 10:28 ` kernel test robot
2022-10-24 15:27 ` Geert Uytterhoeven
2022-10-24 19:55 ` Arnd Bergmann
2022-10-24 20:35 ` Geert Uytterhoeven
2022-10-24 20:47 ` Arnd Bergmann
2022-10-25 4:39 ` Yoshihiro Shimoda
2022-10-25 6:48 ` Geert Uytterhoeven
2022-10-25 11:24 ` Yoshihiro Shimoda
2022-10-20 2:23 ` Florian Fainelli
2022-10-20 7:35 ` Yoshihiro Shimoda
2022-10-20 14:11 ` Andrew Lunn
2022-10-24 23:04 ` Florian Fainelli [this message]
2022-10-20 20:26 ` kernel test robot
2022-10-19 8:35 ` [PATCH v4 3/3] net: ethernet: renesas: rswitch: Add R-Car Gen4 gPTP support Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98e3074-e29c-df7e-f429-cc114f360370@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).