Re: [PATCH 3/9] arm64: dts: qcom: Add initial QCM2290, PM2250 & RB1 device trees

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 4.04.2023 08:06, Krzysztof Kozlowski wrote:
> On 03/04/2023 19:36, Konrad Dybcio wrote:
>> Add initial device trees for the QCM2290 SoC, QC Robotics RB1 board, as
>> well as the bundled PM2250 PMIC.
>>
>> On the SoC part, CA53 compatibles were used, as Qualcomm claims that's
>> what has been implemented, despite the cores reporting a Qualcomm Kryo
>> MIDR_EL1[PART_NUM].
>>
>> To get a successful boot on RB1, run:
>>
>> cat arch/arm64/boot/Image.gz arch/arm64/boot/dts/qcom/qrb2210-rb1.dtb >\
>> .Image.gz-dtb
>>
>> mkbootimg \
>>         --kernel .Image.gz-dtb \
>>         --ramdisk some_initrd \
>>         --output rb1-boot.img \
>>         --pagesize 4096 \
>>         --base 0x8000 \
>>         --cmdline 'some cmdline'
>>
>> fastboot boot rb1-boot.img
>>
>> There's no dtbo or other craziness to worry about.
>> For the best dev experience, you can erase boot and use fastboot boot
>> everytime, so that the bootloader doesn't mess with you.
>>
>> If you have a SoM revision 3 or older (there should be a sticker on it
>> with text like -r00, where r is the revision), you will need to apply
>> this additional diff:
>>
>>         aliases {
>> -               serial0 = &uart0;
>> +               serial0 = &uart4;
>>
>> /* UART connected to the Micro-USB port via a FTDI chip */
>> -&uart0 {
>> +&uart4 {
>>
>> That should however only concern preproduction boards.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
[...]

>> @@ -0,0 +1,63 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
This I think can go BSD3

> 
> Odd license. Unless you based it on 2.0+, please use standard dual-license.

[...]
>> +	pmic@1 {
>> +		compatible = "qcom,pm2250", "qcom,spmi-pmic";
>> +		reg = <0x1 SPMI_USID>;
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +	};
>> +};
>> \ No newline at end of file
> 
> Patch error to fix.
Ack.

> 
>> diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
>> new file mode 100644
>> index 000000000000..27d4742cdb19
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
>> @@ -0,0 +1,848 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> 
> Same concern. Also in DTS.
This was based off of sm6115 dtsi, which is dual-licensed.
I'm not a legal expert, not sure how much flexibility we
can get here.

Konrad
> 
> Best regards,
> Krzysztof
>