From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F517C67871 for ; Mon, 16 Jan 2023 07:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232075AbjAPHxn (ORCPT ); Mon, 16 Jan 2023 02:53:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232139AbjAPHxd (ORCPT ); Mon, 16 Jan 2023 02:53:33 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A26C4113CE for ; Sun, 15 Jan 2023 23:53:30 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id tz11so1666077ejc.0 for ; Sun, 15 Jan 2023 23:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DmseeIxSoeTPNwAIYNdzjE6VKFzUfpsrISNk1TCIZ+w=; b=bThObufnnsl9N/5BExSiFUJZ0MnNBEK6P7AN5C98Dv/hfLATkDTY+MJF870bfHaQc/ q4Qc1cdHSki6H0VGYZ23r9CAJVnzBF7yS3I2+JjGDquoHCZBSLCd2//+2AkObiIDtlEj 3qp9vrolhzGPymZfgjsZkqI0XLqdo0HmzHL+FllsceQqw7SA54FgjLn5wC3Xk+3ARqi5 yjmFIejdpHeFeKFezwQ1TyE6Ns1FXJ4nxVenEVZRM6upeLI0FUSGB4V4mJ4kUrov9NVp tbiAJUKZqpJrKbNl42mIIK+kFJ30oM41wk72KAJBDyXgD+btdUgBZ3InUlP+PdJYfWuH fKwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DmseeIxSoeTPNwAIYNdzjE6VKFzUfpsrISNk1TCIZ+w=; b=cIjTNj/lylXeIGbRn+oOOi7S8D2oFzLn8Gl7bKn53Kd0GrWXbfLXLFt6z4fiYOieEv tuZDeoxrh7pJgoAMM2XVFHJQ3/JHUaZvxTPsy/dPRBa18FVVdB/AYSLT9fzv5/dow+Vj 38RlQE1lqea0hYA0d2NGJz+KH+5FB9ew/hTNc+TcETVST/9b71lIe9wCO3gB7Dnm7Wf5 QoGrhXp/5Fqec9qlbkdwHYW3hg6AB6mroDKpp+Knkd21yRgwWHzn8rAXa9zz/OMJPCxk uqJdwER1lpvusSsCkiOSq67EjqPIIZAVp6YhONLvuZfCGaYz1C/Ls9xkI2gA6f8bkXRJ J5Eg== X-Gm-Message-State: AFqh2kok/0Dl73qt8AEWPlS+HEl2Fkxhl4ojKEdDMTVp7CPz/qfNuNst DJAeuxwHvZKPJrIQQ9L8Roc1dA== X-Google-Smtp-Source: AMrXdXsS61ABxahoG31xtx/AEi2XlUhGE0qIujWZxAIZoNlNlMbdpp8yAH63Loy0hTuZ425CCwdoMQ== X-Received: by 2002:a17:907:6f09:b0:7c1:37:6d5e with SMTP id sy9-20020a1709076f0900b007c100376d5emr58478284ejc.2.1673855609156; Sun, 15 Jan 2023 23:53:29 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id v17-20020a170906293100b007be301a1d51sm11430078ejd.211.2023.01.15.23.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 23:53:28 -0800 (PST) Message-ID: Date: Mon, 16 Jan 2023 08:53:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] dt-bindings: qcom: geni-se: Fix '#address-cells' & '#size-cells' related dt-binding error To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230113201038.267449-1-bhupesh.sharma@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/01/2023 22:33, Bhupesh Sharma wrote: > On Sun, 15 Jan 2023 at 20:57, Krzysztof Kozlowski > wrote: >> >> On 13/01/2023 21:10, Bhupesh Sharma wrote: >>> Fix the following '#address-cells' & '#size-cells' related >>> dt-binding error: >>> >>> $ make dtbs_check >>> >>> From schema: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >>> arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: geniqup@4ac0000: >>> #address-cells:0:0: 2 was expected >>> From schema: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >> >> Don't we want rather to unify the soc address range? > > Well, the assumption in the original dt-bindings was that every reg > variable is 4 * u32 wide (as most new qcom SoCs set #address- and > #size-cells to <2>). However, that is not the case for all of the > SoCs. Hm, which device of that SoC cannot be used with address/size cells 2? > > So, ideally we shouldn't set the "#address-cells" and "#size-cells": > as const: 2 in the bindings. > > See as an example: > https://www.kernel.org/doc/Documentation/devicetree/bindings/usb/usb-device.yaml How USB device - so entirely different device, not MMIO! - is related here? Best regards, Krzysztof