From: Konrad Dybcio <konradybcio@gmail.com>
To: Stephan Gerhold <stephan.gerhold@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <quic_kdybcio@quicinc.com>
Subject: Re: [PATCH 3/4] arm64: dts: qcom: x1e80100: Add UART2
Date: Fri, 9 Aug 2024 12:24:03 +0200 [thread overview]
Message-ID: <b9b02bc4-1abd-4a56-bb6e-ac2c59e8f609@gmail.com> (raw)
In-Reply-To: <ZrXWPQVXfdL-QLnt@linaro.org>
On 9.08.2024 10:41 AM, Stephan Gerhold wrote:
> On Fri, Aug 09, 2024 at 03:43:22AM +0200, Konrad Dybcio wrote:
>> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
>>
>> GENI SE2 within QUP0 is used as UART on some devices, describe it.
>>
>> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
>> ---
[...]
>
> Can you combine these into a single entry, i.e.
>
> pins = "gpio8", "gpio9", "gpio10", "gpio11";
>
> if they are all the same?
Keeping it as-is gives us
a) better hw description
b) an easier ability to add a label and change e.g. the bias
Konrad
next prev parent reply other threads:[~2024-08-09 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 1:43 [PATCH 0/4] X1E Surface Laptop 7 support Konrad Dybcio
2024-08-09 1:43 ` [PATCH 1/4] dt-bindings: arm: qcom: Add Surface Laptop 7 devices Konrad Dybcio
2024-08-09 6:11 ` Krzysztof Kozlowski
2024-08-09 1:43 ` [PATCH 2/4] firmware: qcom: scm: Allow QSEECOM on Surface Laptop 7 models Konrad Dybcio
2024-08-09 1:43 ` [PATCH 3/4] arm64: dts: qcom: x1e80100: Add UART2 Konrad Dybcio
2024-08-09 8:41 ` Stephan Gerhold
2024-08-09 10:24 ` Konrad Dybcio [this message]
2024-08-09 10:27 ` Stephan Gerhold
2024-08-09 1:43 ` [PATCH 4/4] arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices Konrad Dybcio
2024-08-09 9:07 ` Stephan Gerhold
2024-08-09 10:22 ` Konrad Dybcio
2024-08-12 15:09 ` [PATCH 0/4] X1E Surface Laptop 7 support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b02bc4-1abd-4a56-bb6e-ac2c59e8f609@gmail.com \
--to=konradybcio@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_kdybcio@quicinc.com \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).