devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	Jeff Johnson <jjohnson@kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	ath10k@lists.infradead.org, ath11k@lists.infradead.org,
	devicetree@vger.kernel.org, ath12k@lists.infradead.org,
	Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
Subject: Re: [PATCH 2/2] dt-bindings: wireless: ath: Deprecate 'qcom,calibration-variant' property
Date: Fri, 14 Nov 2025 11:47:25 +0100	[thread overview]
Message-ID: <b9b4f1bb-45ef-404e-b75e-962e85a557a2@kernel.org> (raw)
In-Reply-To: <20251114-ath-variant-tbl-v1-2-a9adfc49e3f3@oss.qualcomm.com>

On 14/11/2025 11:22, Manivannan Sadhasivam wrote:
> On devicetree platforms, ath{10k/11k} drivers rely on the presence of the
> 'qcom,calibration-variant' property to select the correct calibration data
> for device variants with colliding IDs.
> 
> But this property based selection has its own downside that it needs to be
> added to the devicetree node of the WLAN device, especially for PCI based
> devices. Currently, the users/vendors are forced to hardcode this property
> in the PCI device node. If a different device need to be attached to the
> slot, then the devicetree node also has to be changed. This approach is not
> scalable and creates a bad user experience.
> 
> So deprecate this property from WLAN devicetree nodes and let the drivers
> do the devicetree model based calibration variant lookup using a static
> table.
> 
> This also warrants removing the property from examples in the binding.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---

The problem - visible in one of the examples here - is that one board
has multiple WiFi chips and they use different calibration-variant
properties. How do you find the right calibration variant for such case
based on board machine match?

Best regards,
Krzysztof

  reply	other threads:[~2025-11-14 10:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 10:22 [PATCH 0/2] wifi: ath: Use static calibration variant table for devicetree platforms Manivannan Sadhasivam
2025-11-14 10:22 ` [PATCH 1/2] " Manivannan Sadhasivam
2025-11-14 10:45   ` Krzysztof Kozlowski
2025-11-14 11:16     ` Manivannan Sadhasivam
2025-11-14 11:24       ` Krzysztof Kozlowski
2025-11-14 11:44         ` Srinivas Kandagatla
2025-11-14 11:48           ` Krzysztof Kozlowski
2025-11-15  9:51   ` kernel test robot
2025-11-14 10:22 ` [PATCH 2/2] dt-bindings: wireless: ath: Deprecate 'qcom,calibration-variant' property Manivannan Sadhasivam
2025-11-14 10:47   ` Krzysztof Kozlowski [this message]
2025-11-14 11:02     ` Manivannan Sadhasivam
2025-11-14 11:04       ` Krzysztof Kozlowski
2025-11-14 11:18         ` Manivannan Sadhasivam
2025-11-14 17:29           ` Jeff Johnson
2025-11-17  9:03             ` Manivannan Sadhasivam
2025-11-17  2:36 ` [PATCH 0/2] wifi: ath: Use static calibration variant table for devicetree platforms Baochen Qiang
2025-11-17  9:00   ` Manivannan Sadhasivam
2025-11-17  9:40     ` Baochen Qiang
2025-11-17 12:45       ` Manivannan Sadhasivam
2025-11-17 17:13         ` Jeff Johnson
2025-11-18  6:53           ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9b4f1bb-45ef-404e-b75e-962e85a557a2@kernel.org \
    --to=krzk@kernel.org \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=miaoqing.pan@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).