From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Pengyu Luo <mitltlatltl@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: add several missing pdc map entries
Date: Mon, 20 Apr 2026 12:21:26 +0200 [thread overview]
Message-ID: <b9b58923-40c0-4d3d-991f-52471b29a813@oss.qualcomm.com> (raw)
In-Reply-To: <CAH2e8h4bMve_hfW6VXynBh--DgwW2v8=XuVpAzUoS8N_73ZEhg@mail.gmail.com>
On 4/20/26 11:53 AM, Pengyu Luo wrote:
> On Mon, Apr 20, 2026 at 4:32 PM Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>> On 4/19/26 7:32 PM, Pengyu Luo wrote:
>>> pdc 215, 256, 257 are missing, but we can find tlmm pin 103, 84, 90
>>> are mapped to them respectively, so add the map entries from pdc to
>>> gic. These entries are reversed from .data section of qcgpio.sys
>>>
>>> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
>>> ---
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> Konrad
>>
>> The below change on top will fully align it with the data in the docs
>> (no functional change)
>>
>
> Glad to know. Could you please help to check the tlmm map too? When I
> was parsing the binary, I found
>
> tlmm 65535 => pdc 70 => gic 520
> tlmm 65535 => pdc 174 => gic 733
> tlmm 65535 => pdc 175 => gic 734
> tlmm 65535 => pdc 176 => gic 735
> tlmm 65535 => pdc 177 => gic 736
> tlmm 65535 => pdc 178 => gic 737
> tlmm 65535 => pdc 184 => gic 743
> tlmm 65535 => pdc 185 => gic 744
> tlmm 65535 => pdc 186 => gic 745
> tlmm 65535 => pdc 187 => gic 746
> tlmm 65535 => pdc 188 => gic 747
> tlmm 65535 => pdc 194 => gic 753
> tlmm 65535 => pdc 195 => gic 754
> tlmm 65535 => pdc 196 => gic 755
> tlmm 65535 => pdc 197 => gic 756
> tlmm 65535 => pdc 198 => gic 757
> tlmm 65535 => pdc 199 => gic 416
> tlmm 65535 => pdc 204 => gic 462
> tlmm 65535 => pdc 205 => gic 264
>
> If 65536 means the pin is missing, I will send v2 to remove the tlmm
> map together with the pdc removal.
These seem to be LPASS/SSC GPIOs
There are missing pairs of:
TLMM 151 -> PDC 264 -> GIC 191
TLMM 143 -> PDC 261 -> GIC 402
and very interestingly, GPIO 190 has two mappings:
PDC 70 -> GIC 552
PDC 178 -> GIC 769
Konrad
next prev parent reply other threads:[~2026-04-20 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 17:32 [PATCH 1/2] arm64: dts: qcom: sc8280xp: add several missing pdc map entries Pengyu Luo
2026-04-19 17:32 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp: gaokun3: correct EC interrupt pin Pengyu Luo
2026-04-20 8:33 ` Konrad Dybcio
2026-04-20 8:32 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp: add several missing pdc map entries Konrad Dybcio
2026-04-20 9:53 ` Pengyu Luo
2026-04-20 10:21 ` Konrad Dybcio [this message]
2026-04-20 10:47 ` Pengyu Luo
2026-04-20 10:58 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b58923-40c0-4d3d-991f-52471b29a813@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitltlatltl@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox