From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B009C48BCF for ; Wed, 9 Jun 2021 11:54:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F72A61249 for ; Wed, 9 Jun 2021 11:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239505AbhFIL4Z (ORCPT ); Wed, 9 Jun 2021 07:56:25 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40519 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239531AbhFIL4Y (ORCPT ); Wed, 9 Jun 2021 07:56:24 -0400 Received: from mail-wm1-f70.google.com ([209.85.128.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lqwmy-0007BU-BS for devicetree@vger.kernel.org; Wed, 09 Jun 2021 11:54:28 +0000 Received: by mail-wm1-f70.google.com with SMTP id 128-20020a1c04860000b0290196f3c0a927so2514507wme.3 for ; Wed, 09 Jun 2021 04:54:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zLhTmNdHd7QsVRSZXglysFm3zyoNBR2RnD/RonHYik0=; b=XsskosnoToocBiq3jjiZVJGzFNt0mmO87GH5oMFO6Kffk0tUuSWLDpb9e+Tx/YpGzH 9RTvjBwuTIotU+ppA/vQGYcA+vXCsRoAbP4H3tRntYS69RSF6nN4OVZWllZM1CclaUyv pupG7l4vOfawLae3hVqHvWqkLiXprQu3e3aE6s8wubpU5VvA2kW2yilNzr20dC2BXAu+ 0qiVlYNta7a66sBo6UzQg9AZE+0hY+YqxlihWmPoP3dC4OicSzqFOEn7m+uABL47YPyZ b6mt5YXxiKAnXR4eLcpFyyVa0PwFSUZHyxu/sT3sMbbi1xuUV1cBqSuCcciZ1eJv7mIB LHHQ== X-Gm-Message-State: AOAM530wA6ESeKqcZAPwGDiwJSXDeKs0w02IH/C0WXds13mJw4shooRf WfgCuouR1FgCbviLISdvhYLCSQtguzyeBgPGKgvGahK2A7dKV7fNqg86ewC+VkUw18OwnjkPoe+ ZcQ7htuGaD/CimZYrUJAgf/mKN6D+E132iMaMjLw= X-Received: by 2002:adf:ee46:: with SMTP id w6mr28653517wro.345.1623239668055; Wed, 09 Jun 2021 04:54:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCt33hywH+M3y1CT+bTXzh8xJ2GJIIBftxRP+jWPUmJmFgjRVOBzLHkNPNuSSYkP5EMOKO/w== X-Received: by 2002:adf:ee46:: with SMTP id w6mr28653501wro.345.1623239667931; Wed, 09 Jun 2021 04:54:27 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id u15sm5852148wmq.48.2021.06.09.04.54.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 04:54:27 -0700 (PDT) Subject: Re: [PATCH v22 12/18] memory: pl353-smc: Let lower level controller drivers handle inits To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org Cc: Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu References: <20210609080112.1753221-1-miquel.raynal@bootlin.com> <20210609080112.1753221-13-miquel.raynal@bootlin.com> From: Krzysztof Kozlowski Message-ID: Date: Wed, 9 Jun 2021 13:54:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609080112.1753221-13-miquel.raynal@bootlin.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/06/2021 10:01, Miquel Raynal wrote: > There is no point in having all these definitions at the SMC bus level, > these are extremely tight to the NAND controller driver implementation, > are not particularly generic, imply more boilerplate than needed, do > not really follow the device model by receiving no argument and some of > them are actually buggy. > > Let's get rid of these right now as there is no current user and keep > this driver at a simple level: only the SMC bare initializations. > > The NAND controller driver which I am going to introduce will take care > of redefining properly all these helpers and using them directly. > > Signed-off-by: Miquel Raynal > --- > drivers/memory/pl353-smc.c | 294 ------------------------------------- > include/linux/pl353-smc.h | 30 ---- > 2 files changed, 324 deletions(-) > delete mode 100644 include/linux/pl353-smc.h > I see you remove here a bunch of code. Are the series still fully bisectable? Best regards, Krzysztof