From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Unnathi Chalicheemala <quic_uchalich@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v3 1/5] dt-bindings: arm: msm: Add llcc Broadcast_AND register
Date: Wed, 28 Feb 2024 08:14:08 +0100 [thread overview]
Message-ID: <b9ed4403-bf3a-4ff4-a92b-22badb845527@linaro.org> (raw)
In-Reply-To: <68a81c2e-8398-441f-b33d-374c37f39e06@quicinc.com>
On 28/02/2024 02:04, Unnathi Chalicheemala wrote:
> On 2/27/2024 7:47 AM, Krzysztof Kozlowski wrote:
>> On 23/02/2024 00:07, Unnathi Chalicheemala wrote:
>>> The LLCC block in SM8450, SM8550 and SM8650 have a new register
>>> space for Broadcast_AND region. This is used to check that all
>>> channels have bit set to "1", mainly in SCID activation/deactivation.
>>>
>>> Previously we were mapping only the Broadcast_OR region assuming
>>> there was only one broadcast register region. Now we also map
>>> Broadcast_AND region.
>>>
>>> Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com>
>>
>> Why did you ignore the tags? Qualcomm upstreaming guide covers this
>> case, so please read it before sending patches.
>>
>
> I was asked to remove the Reviewed-by tag as the previous version of the
> patch gave errors on running 'make DT_CHECKER_FLAGS=-m dt_binding_check',
> that's why I dropped it.
> It was sometime ago, https://lore.kernel.org/all/d78b4bce-7bcd-4ab0-a76b-135cee3ec9b0@linaro.org/
And where is it explained/mentioned? Every tag drop should be documented.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-28 7:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 23:07 [PATCH v3 0/5] LLCC: Support for Broadcast_AND region Unnathi Chalicheemala
2024-02-22 23:07 ` [PATCH v3 1/5] dt-bindings: arm: msm: Add llcc Broadcast_AND register Unnathi Chalicheemala
2024-02-27 15:47 ` Krzysztof Kozlowski
2024-02-28 1:04 ` Unnathi Chalicheemala
2024-02-28 7:14 ` Krzysztof Kozlowski [this message]
2024-02-28 17:54 ` Unnathi Chalicheemala
2024-02-22 23:07 ` [PATCH v3 2/5] soc: qcom: llcc: Add regmap for Broadcast_AND region Unnathi Chalicheemala
2024-03-12 1:05 ` Konrad Dybcio
2024-02-22 23:07 ` [PATCH v3 3/5] arm64: dts: qcom: sm8450: Add mapping to llcc " Unnathi Chalicheemala
2024-02-27 15:48 ` Krzysztof Kozlowski
2024-02-22 23:07 ` [PATCH v3 4/5] arm64: dts: qcom: sm8550: " Unnathi Chalicheemala
2024-02-27 15:49 ` Krzysztof Kozlowski
2024-02-28 1:17 ` Unnathi Chalicheemala
2024-03-02 0:09 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9ed4403-bf3a-4ff4-a92b-22badb845527@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_uchalich@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).