From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 079D2243399; Mon, 30 Jun 2025 09:36:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751276220; cv=none; b=SMYfIEgQOxbHiWRBOh421x9Q6hQ9Rwj7obKic4BtSKVGZYEcSnK//Sd7oNrQSXtFvhwBZyqpaPzymu0WG7tAeGvzWxKl4X/GC7ZHNuyyAD/KS68J0lW4q743lv5ucC1oj9xCOIM0q47IuzIbAwFUbEFWxHpzJmXnqowbY+K8r2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751276220; c=relaxed/simple; bh=zCeSpcyYd4SVvTbB9gO1zsR0I1IothpELY/Ypcw3iM8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RYSrES35ax0+c0aeefywC7MTJrv9kgv2Cy+LPpL3iuRln6d6Kl9Zxwv07jLCG3NAwMwac52L2+bZFVSPNIcK3q+eNBhp3veaYoMzd6CO/SPyXaJP9jajRnvRABKNSmbGjcOKtx2ltiiAQ24zzfMee/W6cYcTZDqvcsw6D0N5cYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pz78Qao2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pz78Qao2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 061F5C4CEE3; Mon, 30 Jun 2025 09:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751276219; bh=zCeSpcyYd4SVvTbB9gO1zsR0I1IothpELY/Ypcw3iM8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pz78Qao26rY//YpOeix6DLWtYmxaMrTv8yg8Q8Z9Nj/6JO5RV1zV8ijcwvEoRuCCH 2j20ff8GyO1wgW6sCgXe/RKkoYTAGS+UU6uqz+vI1y2sQeZx0mvTI+CfeSc6QVSiGj PDHpl7zN8S439Os5c1ojabdUHnrE0sTMp0UtlCE8ZVrcOtHPedVb481/MW48Xeesx6 oTePrkt4/PG7xx1iPOpC41N4MTW598dKjEv/cXlODceSgOtXo+Nv16WhNQsOspjccT LUo6E8IagnW6vEfR9YNSPlBMztMXFQOkr70SRt7PtSRMPiqsKT3dJ00DO4r/lE0/AH nu5EYSWLHJ/Yg== Message-ID: Date: Mon, 30 Jun 2025 11:36:51 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: display: simple-framebuffer: Add interconnects property To: Maxime Ripard Cc: Hans de Goede , Luca Weiss , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Javier Martinez Canillas , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250623-simple-drm-fb-icc-v2-0-f69b86cd3d7d@fairphone.com> <20250623-simple-drm-fb-icc-v2-1-f69b86cd3d7d@fairphone.com> <20250627-mysterious-optimistic-bird-acaafb@krzk-bin> <1129bc60-f9cb-40be-9869-8ffa3b3c9748@kernel.org> <8a3ad930-bfb1-4531-9d34-fdf7d437f352@redhat.com> <85521ded-734d-48e8-8f76-c57739102ded@kernel.org> <20250630-stirring-kiwi-of-adventure-8f22ba@houat> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250630-stirring-kiwi-of-adventure-8f22ba@houat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/06/2025 10:38, Maxime Ripard wrote: > On Mon, Jun 30, 2025 at 10:24:06AM +0200, Krzysztof Kozlowski wrote: >> On 29/06/2025 14:07, Hans de Goede wrote: >>> Hi Krzysztof, >>> >>> On 28-Jun-25 1:49 PM, Krzysztof Kozlowski wrote: >>>> On 27/06/2025 11:48, Luca Weiss wrote: >>>>> Hi Krzysztof, >>>>> >>>>> On Fri Jun 27, 2025 at 10:08 AM CEST, Krzysztof Kozlowski wrote: >>>>>> On Mon, Jun 23, 2025 at 08:44:45AM +0200, Luca Weiss wrote: >>>>>>> Document the interconnects property which is a list of interconnect >>>>>>> paths that is used by the framebuffer and therefore needs to be kept >>>>>>> alive when the framebuffer is being used. >>>>>>> >>>>>>> Acked-by: Thomas Zimmermann >>>>>>> Signed-off-by: Luca Weiss >>>>>>> --- >>>>>>> Documentation/devicetree/bindings/display/simple-framebuffer.yaml | 3 +++ >>>>>>> 1 file changed, 3 insertions(+) >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>>>>>> index 296500f9da05e296dbbeec50ba5186b6b30aaffc..f0fa0ef23d91043dfb2b220c654b80e2e80850cd 100644 >>>>>>> --- a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>>>>>> +++ b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml >>>>>>> @@ -79,6 +79,9 @@ properties: >>>>>>> power-domains: >>>>>>> description: List of power domains used by the framebuffer. >>>>>>> >>>>>>> + interconnects: >>>>>>> + description: List of interconnect paths used by the framebuffer. >>>>>>> + >>>>>> >>>>>> maxItems: 1, or this is not a simple FB anymore. Anything which needs >>>>>> some sort of resources in unknown way is not simple anymore. You need >>>>>> device specific bindings. >>>>> >>>>> The bindings support an arbitrary number of clocks, regulators, >>>>> power-domains. Why should I artificially limit the interconnects to only >>>>> one? >>>> >>>> And IMO they should not. Bindings are not supposed to be generic. >>> >>> The simplefb binding is a binding to allow keeping the firmware, e.g. >>> uboot setup framebuffer alive to e.g. show a boot splash until >>> the native display-engine drive loads. Needing display-engine >>> specific bindings totally contradicts the whole goal of >> >> No, it does not. DT is well designed for that through expressing >> compatibility. I did not say you cannot have generic fallback for simple >> use case. >> >> But this (and previous patchset) grows this into generic binding ONLY >> and that is not correct. > > Can we have a proper definition of what a correct device tree binding is > then? > > It's a bit surprising to have *that* discussion over a binding that is > now well older than a decade now, and while there is definitely some > generic bindings in ePAPR/DT spec, like the CPU ones. Hm? In ARM world at least they are specific, e.g. they have specific compatibles. > > If you don't consider that spec to be correct DT bindings, please > provide a definition of what that is, and / or reasonable alternatives. > > Also, no, a device specific binding isn't reasonable here, because we > *don't* have a device. From a technical standpoint, the firmware creates You touch internal parts of the SoC and you list very specific SoC parts. Interconnect is internal part of the SoC and only specific devices are using it. You define here generic SW construct for something which is opposite of generic: the interconnect connecting two specific, unique components of one, given SoC. > the framebuffer, Linux just uses it. Just like you don't have a > device/platform specific compatible for PSCI, SCPI, et al. They follow some sort of spec and still they do not reference chosen SoC-design-specific properties. Best regards, Krzysztof