From: "André Draszik" <andre.draszik@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: Will McVicker <willmcvicker@google.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v5 1/4] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required
Date: Thu, 20 Nov 2025 10:04:20 +0000 [thread overview]
Message-ID: <b9f4103d8de37574a116164c50ac7e1bd09be80d.camel@linaro.org> (raw)
In-Reply-To: <20251114-automatic-clocks-v5-1-efb9202ffcd7@linaro.org>
On Fri, 2025-11-14 at 14:16 +0000, Peter Griffin wrote:
> Each CMU (with the exception of cmu_top) has a corresponding sysreg bank
> that contains the BUSCOMPONENT_DRCG_EN and optional MEMCLK registers.
> The BUSCOMPONENT_DRCG_EN register enables dynamic root clock gating of
> bus components and MEMCLK gates the sram clock.
>
> Now the clock driver supports automatic clock mode, to fully enable dynamic
> root clock gating it is required to configure these registers. Update the
> bindings documentation so that all CMUs (with the exception of
> gs101-cmu-top) have samsung,sysreg as a required property.
>
> Note this is NOT an ABI break, as if the property isn't specified the
> clock driver will fallback to the current behaviour of not initializing
> the registers. The system still boots, but bus components won't benefit
> from dynamic root clock gating and dynamic power will be higher (which has
> been the case until now anyway).
>
> Additionally update the DT example to included the correct CMU size as
> registers in that region are used for automatic clock mode.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> Changes in v5:
> - Invert the test for google,gs101-cmu-top (Andre)
Reviewed-by: André Draszik <andre.draszik@linaro.org>
next prev parent reply other threads:[~2025-11-20 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 14:16 [PATCH v5 0/4] Implement hardware automatic clock gating (HWACG) for gs101 Peter Griffin
2025-11-14 14:16 ` [PATCH v5 1/4] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required Peter Griffin
2025-11-20 0:10 ` Rob Herring (Arm)
2025-11-20 10:04 ` André Draszik [this message]
2025-11-14 14:16 ` [PATCH v5 2/4] arm64: dts: exynos: gs101: add samsung,sysreg property to CMU nodes Peter Griffin
2025-11-14 14:16 ` [PATCH v5 3/4] clk: samsung: Implement automatic clock gating mode for CMUs Peter Griffin
2025-11-14 14:16 ` [PATCH v5 4/4] clk: samsung: gs101: Enable auto_clock_gate mode for each gs101 CMU Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f4103d8de37574a116164c50ac7e1bd09be80d.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).