From: Michal Simek <michal.simek@xilinx.com>
To: Rob Herring <robh@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
Alexander Graf <agraf@suse.de>, Tejun Heo <tj@kernel.org>,
devicetree@vger.kernel.org, linux-ide@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/9] devicetree: bindings: Add sata port phy config parameters in ahci-ceva
Date: Fri, 11 Aug 2017 14:36:37 +0200 [thread overview]
Message-ID: <b9f44a24-f78b-fd42-f89b-13c04dca04ed@xilinx.com> (raw)
In-Reply-To: <20170810190720.yqeu4qzztylu5slb@rob-hp-laptop>
On 10.8.2017 21:07, Rob Herring wrote:
> On Fri, Aug 04, 2017 at 03:18:10PM +0200, Michal Simek wrote:
>> From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
>>
>> This patch adds device tree bindings for sata port phy parameters
>> in the ahci-ceva.txt file.
>>
>> Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> .../devicetree/bindings/ata/ahci-ceva.txt | 39 ++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> index 7ca8b976c13a..f97546f61444 100644
>> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
>> @@ -5,6 +5,36 @@ Required properties:
>> - compatible: Compatibility string. Must be 'ceva,ahci-1v84'.
>> - clocks: Input clock specifier. Refer to common clock bindings.
>> - interrupts: Interrupt specifier. Refer to interrupt binding.
>> + - ceva,p0-cominit-params: OOB timing value for COMINIT parameter for port 0.
>> + - ceva,p1-cominit-params: OOB timing value for COMINIT parameter for port 1.
>> + The fields for the above parameter must be as shown below:
>> + ceva,phy-cominit-params = /bits/ 8 <CIBGMN CIBGMX CIBGN CINMP>;
>
> phy? Should be pN?
pN will be in v2.
Thanks,
Michal
prev parent reply other threads:[~2017-08-11 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 13:18 [PATCH 0/9] Ata ceva patches Michal Simek
2017-08-04 13:18 ` [PATCH 1/9] devicetree: bindings: Add sata port phy config parameters in ahci-ceva Michal Simek
2017-08-10 19:07 ` Rob Herring
2017-08-11 12:36 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f44a24-f78b-fd42-f89b-13c04dca04ed@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=agraf@suse.de \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=monstr@monstr.eu \
--cc=robh@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).