From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A0CC636D4 for ; Wed, 15 Feb 2023 11:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233258AbjBOLUh (ORCPT ); Wed, 15 Feb 2023 06:20:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233139AbjBOLUd (ORCPT ); Wed, 15 Feb 2023 06:20:33 -0500 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAF78366AE for ; Wed, 15 Feb 2023 03:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1676460027; x=1707996027; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=uXynvbW2CVApjkzjxNlJI6Vd2Zh2nQdtz8jd3YUCg70=; b=aue8fKX3ScqzXrRx0GeUkFPWI8bZeMts5uiDPsMTGBPevZwJgRNEYOmR oeQ5iiMm4riOjRP46ydlRiuqx6vxW/4ewN/GT96OXLqkzEd+X5GLMCK4N 4s8yTLicNbDlkCgpjKyuwccA3Rr/aHgvX2O25PyaGBLSJVUNqp7IFRAlB VuNvO3hBBIEjnEkrZNw+hzOkZ06SRicMWkOeP87RdHji3yMxb5dIGuid7 vGNTP1I+6h6AkyvL1ttfsVRKkIeY12ejwDhovW7kgxn0BCoaz5xWLnNxb i3GX+s2Unj5jyu9s0Ijyuusgo5Oxgsw5krzD+N9iVb7jzOpGwmy9+sevl A==; X-IronPort-AV: E=Sophos;i="5.97,299,1669046400"; d="scan'208";a="327660717" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Feb 2023 19:20:26 +0800 IronPort-SDR: 9JAOoqi/AZbiPDlpINRF7ss7lpZzFI4DWBi8YzHN7zWBl1fyeSbbUdcF7+s0Gwbmn1HB6Ziqx+ 1D1O04YyUA0GgC5hoT3NuWNwI1sKzzTX/a9I2jyEXyreKE2Y6bL3s1p7i+wE7IP5QFwUkt27/O sATGjdhGJ4rv8YwHyjJxrz0NPEh8mTUb4HXs7sy9V+l5XcxEUWnApajbduKSvYm5acETBkFMr+ Qs+OZYnVubTrbKhk725cst1sufth0p43stpIOoHrsoFj2iSvIw2cpCtcvuJAV9uP1SujmsmYJ7 kF0= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 02:37:33 -0800 IronPort-SDR: ZDZ8O6tyqYhZiBebH/cej9sxC/xPwjPNg0mhjIQM2VYsWuzwFETpeCld0szHljoslec/Md0l9R G1LumnkTBVbTjbX2hgf0BfA8lQGFOQA9xO6CfgSrYJ9wm31kszyf6v4FwGuJQrHFBDPbuLwe38 pCS+yQV0mg3BqntLEYoLuNhlRJCe7Bo1dxoP1HAfve5s0znNkp0baWcEGrMfyHjtVQDrWN1xzd Y6jLdZd9DVQcSLl6B7/d6wCRy/8o61102dK3imWJC1GZNWUVX67E5UpV+z+Ooiuo6ZmdPMX7le XJs= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Feb 2023 03:20:26 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4PGwbt2SCdz1RwtC for ; Wed, 15 Feb 2023 03:20:25 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1676460024; x=1679052025; bh=uXynvbW2CVApjkzjxNlJI6Vd2Zh2nQdtz8j d3YUCg70=; b=UbgmN9+gNQFATzWMJ610bUf+/IwX8SDbIoMYaUHqGaDyVoc/qz8 mZZp0LHjP2N8szMljx7OjxcDtHKa3oa9vhaFRwYYkcUVagz531Uye+9sWrSblepz 6K80UZ3YZGRf9Bp2kekGEO+d5ZgfWjQX3tEE8l1kz5iiD9saJNMY7TokwheUiuCz +WToOWnSEUy0PumF3lfXgLY85jp0SkfAsaIfxe+76Cz2MZht7Lt0J8UJQQ5kJWbw g1bPHkvluofdQuhGTpeU+pT0xG7O8ZwVhY4yRxvtWFj862FoWZRZi1x4t2epPRtu khko/SDNARZjM4Yz8VVaFUNeRyJOY93GovA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hRY920xJIvAV for ; Wed, 15 Feb 2023 03:20:24 -0800 (PST) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4PGwbn61f9z1RvLy; Wed, 15 Feb 2023 03:20:21 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 20:20:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 8/9] PCI: rockchip: Use u32 variable to access 32-bit registers Content-Language: en-US To: David Laight , Rick Wertenbroek , "alberto.dassatti@heig-vd.ch" Cc: "xxm@rock-chips.com" , "rick.wertenbroek@heig-vd.ch" , "stable@vger.kernel.org" , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Jani Nikula , Rodrigo Vivi , Mikko Kovanen , Greg Kroah-Hartman , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" References: <20230214140858.1133292-1-rick.wertenbroek@gmail.com> <20230214140858.1133292-9-rick.wertenbroek@gmail.com> <0fa5cef4-7096-7f59-422a-98011d01437c@opensource.wdc.com> <2a80c4e1f1ad42c6849521d1e644b003@AcuMS.aculab.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <2a80c4e1f1ad42c6849521d1e644b003@AcuMS.aculab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2/15/23 19:46, David Laight wrote: > From: Damien Le Moal >> Sent: 15 February 2023 01:34 >> >> On 2/14/23 23:08, Rick Wertenbroek wrote: >>> Previously u16 variables were used to access 32-bit registers, this >>> resulted in not all of the data being read from the registers. Also >>> the left shift of more than 16-bits would result in moving data out >>> of the variable. Use u32 variables to access 32-bit registers >>> >>> Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Rick Wertenbroek >>> --- >>> drivers/pci/controller/pcie-rockchip-ep.c | 10 +++++----- >>> drivers/pci/controller/pcie-rockchip.h | 1 + >>> 2 files changed, 6 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c >>> index ca5b363ba..b7865a94e 100644 >>> --- a/drivers/pci/controller/pcie-rockchip-ep.c >>> +++ b/drivers/pci/controller/pcie-rockchip-ep.c >>> @@ -292,15 +292,15 @@ static int rockchip_pcie_ep_set_msi(struct pci_epc *epc, u8 fn, u8 vfn, >>> { >>> struct rockchip_pcie_ep *ep = epc_get_drvdata(epc); >>> struct rockchip_pcie *rockchip = &ep->rockchip; >>> - u16 flags; >>> + u32 flags; >>> >>> flags = rockchip_pcie_read(rockchip, >>> ROCKCHIP_PCIE_EP_FUNC_BASE(fn) + >>> ROCKCHIP_PCIE_EP_MSI_CTRL_REG); >>> flags &= ~ROCKCHIP_PCIE_EP_MSI_CTRL_MMC_MASK; >>> flags |= >>> - ((multi_msg_cap << 1) << ROCKCHIP_PCIE_EP_MSI_CTRL_MMC_OFFSET) | >>> - PCI_MSI_FLAGS_64BIT; >>> + (multi_msg_cap << ROCKCHIP_PCIE_EP_MSI_CTRL_MMC_OFFSET) | >> >> ROCKCHIP_PCIE_EP_MSI_CTRL_MMC_OFFSET is 17 and multi_msg_cap is a u8... >> Not nice. > > It really doesn't matter. > As soon as you do any arithmetic char and short are promoted to int. OK. Thanks. -- Damien Le Moal Western Digital Research