From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Patrick Rudolph <patrick.rudolph@9elements.com>,
Peter Rosin <peda@axentia.se>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 1/4] dt-bindings: i2c: Correct interrupt support
Date: Mon, 17 Apr 2023 18:56:31 +0200 [thread overview]
Message-ID: <ba0d33b1-9da8-209c-6407-12128d08a4d4@linaro.org> (raw)
In-Reply-To: <20230417104801.808972-2-patrick.rudolph@9elements.com>
On 17/04/2023 12:47, Patrick Rudolph wrote:
> Only some of the PCA954x compatible ICs have interrupt
> capability, but the binding advertises it on all ICs.
Subject: Add proper prefix for the device. You are not correcting
interrupt support in all I2C controllers.
>
> Sync the dt-binding with the driver and only advertise it on:
> - nxp,pca9542
> - nxp,pca9543
> - nxp,pca9544
> - nxp,pca9545
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> ---
> .../bindings/i2c/i2c-mux-pca954x.yaml | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> index 9f1726d0356b..93ffa67d0d9c 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> @@ -63,6 +63,24 @@ required:
> - compatible
> - reg
>
> +allOf:
> + - $ref: /schemas/i2c/i2c-mux.yaml#
Duplicated part.
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-17 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 10:47 [PATCH v12 0/4] Add support for Maxim MAX735x/MAX736x variants Patrick Rudolph
2023-04-17 10:47 ` [PATCH v12 1/4] dt-bindings: i2c: Correct interrupt support Patrick Rudolph
2023-04-17 13:10 ` Rob Herring
2023-04-17 16:56 ` Krzysztof Kozlowski [this message]
2023-04-17 10:47 ` [PATCH v12 2/4] dt-bindings: i2c: Add Maxim MAX735x/MAX736x variants Patrick Rudolph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0d33b1-9da8-209c-6407-12128d08a4d4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).