From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3434EB64DD for ; Thu, 29 Jun 2023 19:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231899AbjF2TTo (ORCPT ); Thu, 29 Jun 2023 15:19:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232016AbjF2TTX (ORCPT ); Thu, 29 Jun 2023 15:19:23 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5874749FA for ; Thu, 29 Jun 2023 12:14:53 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4fafe87c6fbso1673362e87.3 for ; Thu, 29 Jun 2023 12:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688066091; x=1690658091; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Vq+T8lQo74iqCO2gARUksyTq7tukw2uYRbItDc46iw=; b=NGs2k0y7ct9TAeWIg2sXMCaKO1ie2YUvLXJyeU3KSEZgGdU+ZSFrYJPd+GZ8Y0QrXQ snIQmz9Z5dR5Tqgs3/9E/CFKoSJAZyX7A2s2a00Crzbe/yhCuVyJCHtN1ZOV1BQ2sP0z j8Fuhub3WhCWuH9gBRkx8v9HuepD+M2Z5v7oUb1memQGcYPbgQGQDU7vILngB4cx+rPs XzdC0Uj+KVV8vJjNrB/vZn71mmy335Hr1xVYYCSnzOhfivzCeSGT337/xcAz6Cq4ENFw HJgc9Iupi7bCgQwg0MlcgyvpIqq0Uz69eDJJvMLqXx2bd2QC5S2TMSs63YC8EPT1+ay+ Fsyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688066091; x=1690658091; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Vq+T8lQo74iqCO2gARUksyTq7tukw2uYRbItDc46iw=; b=Ra3rH4v4dfAe5AJCo6j6tk3gPDP7ueaXrT9TlnF5d7jWI2/f4W20Ls3/c2SzLh78hD 0LEJcbi51a47HLfQxBo/UKHxip8WC2vmAMPM0/q0zbLfjvV3XICYrymvbuCnRSNbTCKx wDaMZoZIMRZXrXpmPAH5smpo43paxHL0/sS5r2mJ/nhE9HTD8UFyareLJmldPD1dQcch GfVjeVZYll3LgLwgcWexprGpctCFeQgmL5YoeJ+DG3uEvbUylD5UbDemTaM8EUlchKOb coHMrFPDjr+blsq8YQ5B6dabalOnb7jh8r5nKyhyAmb7Pbt3y8+nem7mO+MYIoi8z3zq YJKA== X-Gm-Message-State: ABy/qLbJRdw4jSRuS8wD6kxbox3fJovLC/d+qTCvucxBhDvoWbedWTtj rQdfry8SLW+QE3Krslwq0BSt6w== X-Google-Smtp-Source: APBJJlGBtQm30wveE7QHuHEUoBRPBJ59HzZZOwf8zDUMmBFEmC1w9RT6nElA3dhsxQ7/3LNWzbB9VQ== X-Received: by 2002:a05:6512:3b9c:b0:4ec:9ef9:e3d with SMTP id g28-20020a0565123b9c00b004ec9ef90e3dmr778592lfv.26.1688066091464; Thu, 29 Jun 2023 12:14:51 -0700 (PDT) Received: from [192.168.1.101] (abyk82.neoplus.adsl.tpnet.pl. [83.9.30.82]) by smtp.gmail.com with ESMTPSA id p17-20020a05651238d100b004fb99acbbe7sm401514lft.231.2023.06.29.12.14.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 12:14:50 -0700 (PDT) Message-ID: Date: Thu, 29 Jun 2023 21:14:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock Content-Language: en-US To: Dmitry Baryshkov , Marijn Suijten Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan , Loic Poulain , Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Lux Aliaga References: <20230627-sm6125-dpu-v2-0-03e430a2078c@somainline.org> <20230627-sm6125-dpu-v2-12-03e430a2078c@somainline.org> <84eb1d40-436b-a5b4-a4e3-75a511ad5a90@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29.06.2023 14:26, Dmitry Baryshkov wrote: > On Thu, 29 Jun 2023 at 15:09, Marijn Suijten > wrote: >> >> On 2023-06-29 13:55:28, Dmitry Baryshkov wrote: >>> On 27/06/2023 23:14, Marijn Suijten wrote: >>>> We have a working RPM XO clock; no other driver except rpmcc should be >>>> parenting directly to the fixed-factor xo_board clock nor should it be >>>> reachable by that global name. Remove the name to that effect, so that >>>> every clock relation is explicitly defined in DTS. >>>> >>>> Reviewed-by: Konrad Dybcio >>>> Signed-off-by: Marijn Suijten >>>> --- >>>> arch/arm64/boot/dts/qcom/sm6125.dtsi | 7 ++++--- >>>> 1 file changed, 4 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi >>>> index 722dde560bec..edb03508dba3 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi >>>> @@ -22,7 +22,6 @@ xo_board: xo-board { >>>> compatible = "fixed-clock"; >>>> #clock-cells = <0>; >>>> clock-frequency = <19200000>; >>>> - clock-output-names = "xo_board"; >>> >>> Why? I'd say, leave it. >> >> The exact reason is explained in the commit message. > > Usually we do no not kill the xo_board name for the sake of anybody > still looking for the old name. Weak argument, I know. The only users are (rg -l '"xo_board"' drivers): drivers/clk/qcom/mmcc-msm8974.c drivers/clk/qcom/a53-pll.c drivers/clk/qcom/gcc-msm8974.c drivers/clk/qcom/clk-smd-rpm.c drivers/clk/qcom/mmcc-msm8996.c drivers/clk/qcom/gcc-msm8916.c drivers/clk/qcom/gcc-apq8084.c drivers/clk/qcom/gcc-msm8996.c drivers/clk/qcom/mmcc-apq8084.c drivers/clk/qcom/clk-rpmh.c drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c This platform only binds clk-smd-rpm, but patch 11 provides a direct reference in the DT. Konrad > >> >>> >>> With that fixed: >> >> Hence I don't think it makes sense to "fix" this. >> >> - Marijn >> >>> Reviewed-by: Dmitry Baryshkov > > >