From: <Tudor.Ambarus@microchip.com>
To: <manivannan.sadhasivam@linaro.org>
Cc: <shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
<robh+dt@kernel.org>, <kernel@pengutronix.de>,
<festevam@gmail.com>, <linux-imx@nxp.com>,
<darshak.patel@einfochips.com>, <prajose.john@einfochips.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <marek.vasut@gmail.com>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
Date: Thu, 7 Nov 2019 12:30:05 +0000 [thread overview]
Message-ID: <ba29a5dd-df80-841b-68cd-66cffd6ae7cf@microchip.com> (raw)
In-Reply-To: <20191101160943.GA20347@Mani-XPS-13-9360>
On 11/01/2019 06:09 PM, Manivannan Sadhasivam wrote:
>> On 11/01/2019 04:58 PM, Manivannan Sadhasivam wrote:
>>>>> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
>>>>> supports dual/quad I/O mode with 512 blocks of memory organized in
>>>>> 64KB sectors. In addition to this, there is also small 4KB sectors
>>>>> available for flexibility. The device has been validated using Thor96
>>>>> board.
>>>>>
>>>>> Cc: Marek Vasut <marek.vasut@gmail.com>
>>>>> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
>>>>> Cc: David Woodhouse <dwmw2@infradead.org>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>>>>> Cc: Richard Weinberger <richard@nod.at>
>>>>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>>>>> Cc: linux-mtd@lists.infradead.org
>>>>> Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
>>>>> [Mani: cleaned up for upstream]
>>>> Can we keep Darshak's authorship? We usually change the author if we feel that
>>>> we made a significant change to what was originally published.
>>>>
>>>> If it's just about cosmetics, cleaning or rebase, you can specify what you did
>>>> after the author's S-o-b tag and then add your S-o-b, as you did above.
>>>>
>>> I'd suggest to keep Darshak's authorship since he did the actual change in
>>> the bsp. I have to clean it up before submitting upstream and I mentioned
>>> the same above.
>>>
>> Ok, I'll amend the author when applying, it will be Darshak.
>>
> Ah no. I was saying we should keep both of ours authorship. It shouldn't
> be an issue because we both are involved in the process.
There can be only one author in a patch, and multiple signers if needed:
Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date: Wed Oct 30 14:31:24 2019 +0530
mtd: spi-nor: Add support for w25q256jw
[cut]
Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
[Mani: cleaned up for upstream]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Please read
https://www.kernel.org/doc/html/v5.3/process/submitting-patches.html, paragraph
11), and tell me if you want me to amend the author to keep Darshak's authorship
or you want to keep yours.
next prev parent reply other threads:[~2019-11-07 12:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 9:01 [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 1/4] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
2019-11-05 22:04 ` Rob Herring
2019-10-30 9:01 ` [PATCH v2 2/4] dt-bindings: arm: Add devicetree binding for Thor96 Board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 3/4] arm64: dts: freescale: Add devicetree support for Thor96 board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw Manivannan Sadhasivam
2019-11-01 13:48 ` Tudor.Ambarus
2019-11-01 14:58 ` Manivannan Sadhasivam
2019-11-01 15:55 ` Tudor.Ambarus
2019-11-01 16:09 ` Manivannan Sadhasivam
2019-11-07 12:30 ` Tudor.Ambarus [this message]
2019-11-07 12:40 ` Manivannan Sadhasivam
2019-11-11 19:31 ` Tudor.Ambarus
2020-01-09 3:33 ` [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
2020-01-09 6:39 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba29a5dd-df80-841b-68cd-66cffd6ae7cf@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=computersforpeace@gmail.com \
--cc=darshak.patel@einfochips.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=prajose.john@einfochips.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).