From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1719CC2D0E5 for ; Thu, 26 Mar 2020 20:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECDDA20714 for ; Thu, 26 Mar 2020 20:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728317AbgCZUFi (ORCPT ); Thu, 26 Mar 2020 16:05:38 -0400 Received: from smtprelay0172.hostedemail.com ([216.40.44.172]:37626 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727851AbgCZUFi (ORCPT ); Thu, 26 Mar 2020 16:05:38 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 22899182CF244; Thu, 26 Mar 2020 20:05:37 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ink47_137fca8f2a32c X-Filterd-Recvd-Size: 3482 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Thu, 26 Mar 2020 20:05:33 +0000 (UTC) Message-ID: Subject: Re: [PATCH net-next 7/9] net: phy: enable qoriq backplane support From: Joe Perches To: florinel.iordache@nxp.com, davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kuba@kernel.org, corbet@lwn.net, shawnguo@kernel.org, leoyang.li@nxp.com, madalin.bucur@oss.nxp.com, ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org Date: Thu, 26 Mar 2020 13:03:42 -0700 In-Reply-To: <1585230682-24417-8-git-send-email-florinel.iordache@nxp.com> References: <1585230682-24417-1-git-send-email-florinel.iordache@nxp.com> <1585230682-24417-8-git-send-email-florinel.iordache@nxp.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 2020-03-26 at 15:51 +0200, Florinel Iordache wrote: > Enable backplane support for qoriq family of devices trivial notes: > diff --git a/drivers/net/phy/backplane/qoriq_backplane.c b/drivers/net/phy/backplane/qoriq_backplane.c [] > +static int qoriq_backplane_probe(struct phy_device *bpphy) > +{ > + static bool one_time_action = true; > + > + if (one_time_action) { > + one_time_action = false; > + pr_info("%s: QorIQ Backplane driver version %s\n", > + QORIQ_BACKPLANE_DRIVER_NAME, > + QORIQ_BACKPLANE_DRIVER_VERSION); > + } There is an existing mechanism for this: pr_info_once("%s: ... %s\n", etc...); [] > +static int qoriq_backplane_config_init(struct phy_device *bpphy) > +{ [] > + for (i = 0; i < bp_phy->num_lanes; i++) { [] > + ret = of_address_to_resource(lane_node, 0, &res); > + if (ret) { > + bpdev_err(bpphy, > + "could not obtain lane memory map for index=%d, ret = %d\n", > + i, ret); > + return ret; This could use the new vsprintf %pe extension: bpdev_err(bpphy, "could not obtain lane memory map for index=%d, %pe\n", i, ERR_PTR(ret)); > + ret = of_address_to_resource(serdes_node, 0, &res); > + if (ret) { > + bpdev_err(bpphy, > + "could not obtain serdes memory map, ret = %d\n", > + ret); > + return ret; %pe etc. [] > + for (i = 0; i < comp_no; i++) { > + ret = of_property_read_string_index(serdes_node, "compatible", > + i, &serdes_comp); > + if (ret == 0) { > + if (!strcasecmp(serdes_comp, "serdes-10g")) { > + serdes_type = SERDES_10G; > + break; > + } else if (!strcasecmp(serdes_comp, "serdes-28g")) { > + serdes_type = SERDES_28G; > + break; > + } > + } > + } [] > +static int qoriq_backplane_match_phy_device(struct phy_device *bpphy) > +{ [] > + for (i = 0; i < comp_no; i++) { > + ret = of_property_read_string_index(serdes_node, "compatible", > + i, &serdes_comp); > + if (ret == 0) { > + if (!strcasecmp(serdes_comp, "serdes-10g")) { > + serdes_type = SERDES_10G; > + break; > + } else if (!strcasecmp(serdes_comp, "serdes-28g")) { > + serdes_type = SERDES_28G; > + break; > + } > + } > + } [] Maybe add and use a helper function?