From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5919C23F296; Thu, 3 Apr 2025 08:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743667268; cv=none; b=Vro9oyP7GzgCFzGWZ2uS2TwOTpoTPI+BJ2fQXz/lFZRzArLh+mTpmsNz1YkJW3/crFd9s33MjdelNXU6hxpjKzfkAXKRpo63D5t45+4pNaSuAygrIKCWOkVEkNk9AL98uJ1Ahf7J9lDAs2RZ64PV5jdI6jIYS0J7G+M+1dZuCpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743667268; c=relaxed/simple; bh=5iTwQ2CHLhS07UhYM4odxUwSxPkxU41/IhkP/RM0hX0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lg3hlgO1/2AC6JpwnhSkewyEwKXkPmpEYS42z/NGjXDbry1r8txPh4gk0u4fS8xHXrh9A2zIHezSeLE4UemaBzXL9tN/AviIR5UHH0EMOuNomtzcWWTPRajo0tO2t3umBbhveE65rEtiHZCeK6Rll2yhoLo2v+5oUYRzS2RXSDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dX+70bHi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dX+70bHi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6F6DC4CEE3; Thu, 3 Apr 2025 08:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743667267; bh=5iTwQ2CHLhS07UhYM4odxUwSxPkxU41/IhkP/RM0hX0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dX+70bHi615ZyGyOLQtsOnlS8iiQ1MDFkI86v3B7xq9ECPFnpk8hUtyYewI6avAGQ ODl2n7JJY4x31pfhDAaSNhnHmiOJBWQl8xHZTSzMVpGftHrw/PPveVM/Hkycq9bOGu bcdIL8Flrc+3KaqVl2flQmUwJBjEIkuixQHXkvGJeHRjHqdggXoPtTc2XphRelgpgc Bnw4w6EmP+f61bMFKgYlWIP3rFzHZBMRWc2NBTr+O/zQ9Zqk1DiYkmsrBSZz2NctfA uHjf0/fNOJv3V0UbByNJUtgEajc+DCgEf7+dyfgijvMsYrjRpYs7N+ngvWPS3GjFD4 /m4ewmjqyRPFA== Message-ID: Date: Thu, 3 Apr 2025 10:00:58 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM To: Amit Sunil Dhamne Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Badhri Jagan Sridharan , Sebastian Reichel , Heikki Krogerus , "Rafael J. Wysocki" , Len Brown , Pavel Machek , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, RD Babiera , Kyle Tso References: <20250312-batt_ops-v1-0-88e0bb3129fd@google.com> <20250313-determined-wild-seahorse-f7871a@krzk-bin> <914a0df4-96d0-4cd4-ac87-3826fa9c1440@google.com> <3f65fe16-56f8-4887-bb91-994b181ce5a9@kernel.org> <9852e5a8-843d-48ae-90d0-7991628e93b3@google.com> <442bebf4-4de1-42d1-a14b-2bb509fea12f@kernel.org> <7c7cff17-2c53-4dcd-8760-50c72760de5b@google.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <7c7cff17-2c53-4dcd-8760-50c72760de5b@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/04/2025 05:41, Amit Sunil Dhamne wrote: > > On 3/21/25 12:51 AM, Krzysztof Kozlowski wrote: >> On 20/03/2025 22:11, Amit Sunil Dhamne wrote: >>> On 3/16/25 9:52 AM, Krzysztof Kozlowski wrote: >>>> On 15/03/2025 01:49, Amit Sunil Dhamne wrote: >>>>> Hi Krzysztof, >>>>> >>>>> Thanks for the review! >>>>> >>>>> On 3/13/25 1:50 AM, Krzysztof Kozlowski wrote: >>>>>> On Wed, Mar 12, 2025 at 04:42:00PM -0700, Amit Sunil Dhamne wrote: >>>>>>> Support for Battery Status & Battery Caps messages in response to >>>>>>> Get_Battery_Status & Get_Battery_Cap request is required by USB PD devices >>>>>>> powered by battery, as per "USB PD R3.1 V1.8 Spec", "6.13 Message >>>>>>> Applicability" section. This patchset adds support for these AMSes >>>>>>> to achieve greater compliance with the spec. >>>>>> Which board uses it? I would be happy to see that connection between >>>>>> batteries and USB connector on the schematics of some real device. How >>>>>> does it look like? >>>>> Any board that uses a USB Type-C connector that supplies power into or >>>> If you keep responding like this, you will got nowhere, so let me >>>> re-iterate: >>>> >>>> Which upstream DTS (or upstream supported hardware) is going to use this >>>> binding, so I can see how you are going to implement it there in the >>>> entire system? >>> This is for maxim,max33359 Type-C controller. >> Stop deflecting the questions. max33359 is not a board. I already asked >> two times. >> >> Apparently admitting "no upstream users" is impossible, so let's state >> the obvious: >> >> There are no upstream users of this. > > max33359 controller has an upstream user i.e., gs101-oriole (Pixel 6) > board. Totally agree that at the moment there are no upstream > devices/drivers for the Fuel Gauge (that my patchset has a dependency > on) in gs101-oriole board. gs101-oriole uses max77759 fuel gauge device. > I see that there's an effort for upstreaming it > (https://lore.kernel.org/all/20250102-b4-gs101_max77759_fg-v2-0-87959abeb7ff@uclouvain.be/). > I will mark my patches as dependent on it + demonstrate the relationship > of the devices in the gs101-oriole board. Hope that's okay? Then please send the DTS for GS101 Oriole using this binding. I don't understand the point of adding binding for some user and in the same time not doing anything for that user. Best regards, Krzysztof