From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693BAC4708F for ; Tue, 1 Jun 2021 08:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A44E6138C for ; Tue, 1 Jun 2021 08:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233160AbhFAIu2 (ORCPT ); Tue, 1 Jun 2021 04:50:28 -0400 Received: from foss.arm.com ([217.140.110.172]:43700 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233893AbhFAIuO (ORCPT ); Tue, 1 Jun 2021 04:50:14 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C4F91FB; Tue, 1 Jun 2021 01:48:33 -0700 (PDT) Received: from [10.57.73.64] (unknown [10.57.73.64]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DE3B53F73D; Tue, 1 Jun 2021 01:48:30 -0700 (PDT) Subject: Re: [PATCH 2/2] iommu: Drop unnecessary of_iommu.h includes To: Rob Herring , Joerg Roedel , Will Deacon Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Frank Rowand , iommu@lists.linux-foundation.org, Rob Clark , Marek Szyprowski , Krzysztof Kozlowski , Bjorn Andersson , Yong Wu , Matthias Brugger , Heiko Stuebner , Jean-Philippe Brucker References: <20210527193710.1281746-1-robh@kernel.org> <20210527193710.1281746-2-robh@kernel.org> From: Robin Murphy Message-ID: Date: Tue, 1 Jun 2021 09:48:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210527193710.1281746-2-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021-05-27 20:37, Rob Herring wrote: > The only place of_iommu.h is needed is in drivers/of/device.c. Remove it > from everywhere else. Of course, this was from the OF_IOMMU_DECLARE() business which is all is long gone now. Reviewed-by: Robin Murphy > Cc: Will Deacon > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Rob Clark > Cc: Marek Szyprowski > Cc: Krzysztof Kozlowski > Cc: Bjorn Andersson > Cc: Yong Wu > Cc: Matthias Brugger > Cc: Heiko Stuebner > Cc: Jean-Philippe Brucker > Cc: Frank Rowand > Cc: linux-arm-kernel@lists.infradead.org > Cc: iommu@lists.linux-foundation.org > Signed-off-by: Rob Herring > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 - > drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 - > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 1 - > drivers/iommu/exynos-iommu.c | 1 - > drivers/iommu/ipmmu-vmsa.c | 1 - > drivers/iommu/msm_iommu.c | 1 - > drivers/iommu/mtk_iommu.c | 1 - > drivers/iommu/mtk_iommu_v1.c | 1 - > drivers/iommu/omap-iommu.c | 1 - > drivers/iommu/rockchip-iommu.c | 1 - > drivers/iommu/virtio-iommu.c | 1 - > drivers/of/platform.c | 1 - > 12 files changed, 12 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 54b2f27b81d4..2ddc3cd5a7d1 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -23,7 +23,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c > index 6f72c4d208ca..dba15f312cbd 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c > @@ -31,7 +31,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > index 4294abe389b2..021cf8f65ffc 100644 > --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c > +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > @@ -25,7 +25,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > index 7623d8c371f5..d0fbf1d10e18 100644 > --- a/drivers/iommu/exynos-iommu.c > +++ b/drivers/iommu/exynos-iommu.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > index aaa6a4d59057..51ea6f00db2f 100644 > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -19,7 +19,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c > index 7880f307cb2d..3a38352b603f 100644 > --- a/drivers/iommu/msm_iommu.c > +++ b/drivers/iommu/msm_iommu.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > > #include > #include > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index e06b8a0e2b56..6f7c69688ce2 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -19,7 +19,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c > index 5915d7b38211..778e66f5f1aa 100644 > --- a/drivers/iommu/mtk_iommu_v1.c > +++ b/drivers/iommu/mtk_iommu_v1.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c > index 26e517eb0dd3..91749654fd49 100644 > --- a/drivers/iommu/omap-iommu.c > +++ b/drivers/iommu/omap-iommu.c > @@ -22,7 +22,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c > index 7a2932772fdf..bb50e015b1d5 100644 > --- a/drivers/iommu/rockchip-iommu.c > +++ b/drivers/iommu/rockchip-iommu.c > @@ -21,7 +21,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c > index 7c02481a81b4..d9f46f2c3058 100644 > --- a/drivers/iommu/virtio-iommu.c > +++ b/drivers/iommu/virtio-iommu.c > @@ -14,7 +14,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index 25d448f5af91..74afbb7a4f5e 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > #include > #include >