From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAFC21F09BC for ; Fri, 11 Apr 2025 14:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744381784; cv=none; b=tRn7yCpsUS9Ke6fpmIUW93OLmJAjejkZsbXaKEJycuAk1mhcDQsd4DJSacK7qKy0YkVrYAOlLV5ykPRhlynwBlyT6m/rcWRZwhB69hfmXt7cyXwNQ2J9HoDwtdZ0HsqhoH5Wz7FdHG67RMXcqYW5Z4/MUXYVpj6xUYHJQunJzeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744381784; c=relaxed/simple; bh=/iEDuG2zIehPz6KVZMTx7mu4Lm71sDlFq0jr0v8mSrU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mCwAKmtv6T9EIO2/Bgn3gs0CiP4UVQ7v3UgVQUaIfXX0EKaCj0OWRardbyiYGAg+o9fPNNDSzTD2fvFezx31B3PKS5Tmp6pcyChaI0JXbxvPry6IGnzFjXXF/sVam0V3XtLY5RyUMWHxt3yBeVozcFIzTFi1oy+pggKcXEzEyXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=X/vMj+OO; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="X/vMj+OO" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso16065125e9.3 for ; Fri, 11 Apr 2025 07:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1744381779; x=1744986579; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8hqxBUyC0ns9eaPvESS3za+oYCsUAFhI9e/U4xWblAI=; b=X/vMj+OOQEiTDPWARbkN6qmjFHOTPup+RI/3K1768rfPWYChq3rq7WxEXoxlZrZthR D1y+9V6oFFRnC91LkARWcmPWY/oBgBpVkFays1KTPWMxoDrqPQX2slz8B5s3X2yD/GIw mioDMXySt0X96eHnDw6ES3ZlMh5yh3djw8XoylmHo/DODkoNLJ5XgsqPL7VqI2WvfBwr e7oCDqkvMjlTUXvQ4V2QLmejR9fCQsiybSkWmFMDko912iHUqjRakZaxniKsgmWYo7dK DSJ05D4vS9GsMZJrr5mJ1EzSwwXasJI0gm9UmPD2rib19wD6sRq+DBodrsXWldnAEanQ tq/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744381779; x=1744986579; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8hqxBUyC0ns9eaPvESS3za+oYCsUAFhI9e/U4xWblAI=; b=TQmbnUlZlXW7zh1dsZg8vsyj8Doten5ywinyo1i0ETG2wj9B5VZfJ5tufSEwh23CEn tyMPITlaHZBkDf8Ak/qVK5qbXn4zmtYCm1E6C0mv/CmWjMBjwtWVejO8J0LCT4/lVHFs On/rL3AqLXJB8oHZuvrNvwLrnNA5YSHzCCWPcvocDdefU2kd0yYAUZpo03JhUSLZESBF vfdEK4z4wxW2sUKiYfRkSE3Jowj73fMLg8InzV0DQN6KLPJNL82sOVyQpfSXriNApDjl 1l7xXlXFN+hKj9I2HEDcTS3ENpA06E+UtjGwlWsLo8UfGvBBNRKcZlq4Iav5CnMJ8hAA zUgg== X-Forwarded-Encrypted: i=1; AJvYcCUPxxznoMY7B6dY/OnOJEHc5bt9Fufw93zm4g+KMWRcE7UKLWej43ZgcHztbuFnyETOpAOZheV5u5Pn@vger.kernel.org X-Gm-Message-State: AOJu0YwaW+k8X9uUiYNFR+ChnY+VydNbP0MvJePjqlL1F6CRxP5rjXiE pgv26PKM6mSXpFOAGT7/+kMafJr6ivKN8VgxWPNiaKKl6PDlJb3g/o+50HsuABOdLb5a8gqKDm9 L X-Gm-Gg: ASbGnctMZSVQOUnZVC8dwrnHaWaxbezSBSO6kotCJIdkxJ2d8G+mvrBZopjEEAM7DxA li/+L602Yi7jt41dQYj17qnujKQT/zGupVkBaI3YxU2ecXrW7P/f3s0YgJHnB4aUo7r8WeD/KJu SECU5Z4DdpZfz/AuzXdhqq1VPNldXhaHLBiplX/ioG99g5bhM1mp3hSHCVGoTVM1675FtTTPYjG OemO5GmIdCZU13lBt1UflS5ddug81yV/zinCqL/rinVlWWgONlndynPduJ5ttHlRzAaiTfM1ZpI YxW1yKzn156rgZFpXMpLOnMxLjCovAUgoe0YeiYk5jsQYv9t X-Google-Smtp-Source: AGHT+IHD7Cas+STyP0l4SArtn2i6scRGDrYYRpRyE7WLAnpJy9q9S7ex/ksN5K6SfcSK5n+MPRT4DA== X-Received: by 2002:a5d:59ad:0:b0:397:8f09:5f6 with SMTP id ffacd0b85a97d-39eaaebed00mr2197064f8f.47.1744381779046; Fri, 11 Apr 2025 07:29:39 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.57]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae977a7fsm2151767f8f.45.2025.04.11.07.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 07:29:38 -0700 (PDT) Message-ID: Date: Fri, 11 Apr 2025 17:29:37 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] ARM: dts: microchip: sama7d65: Enable GMAC interface To: Ryan.Wanner@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, onor+dt@kernel.org, alexandre.belloni@bootlin.com Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Ryan, On 01.04.2025 19:13, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner > > Enable GMAC0 interface for sama7d65_curiosity board. > > Signed-off-by: Ryan Wanner > --- > .../dts/microchip/at91-sama7d65_curiosity.dts | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts > index 30fdc4f55a3b..441370dbb4c2 100644 > --- a/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts > +++ b/arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts > @@ -105,7 +105,58 @@ &main_xtal { > clock-frequency = <24000000>; > }; > > +&gmac0 { Please keep nodes alphanumerically sorted. > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gmac0_default > + &pinctrl_gmac0_mdio_default > + &pinctrl_gmac0_txck_default > + &pinctrl_gmac0_phy_irq>; > + phy-mode = "rgmii-id"; > + status = "okay"; > + > + ethernet-phy@7 { > + reg = <0x7>; > + interrupt-parent = <&pioa>; > + interrupts = ; > + status = "okay"; No need for status here, default is okay. > + }; > +}; Missing blank line here. As this are mainly cosmetics I will adjust while applying. Thank you, Claudiu > &pioa { > + pinctrl_gmac0_default: gmac0-default { > + pinmux = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + slew-rate = <0>; > + bias-disable; > + }; > + > + pinctrl_gmac0_mdio_default: gmac0-mdio-default { > + pinmux = , > + ; > + bias-disable; > + }; > + > + pinctrl_gmac0_phy_irq: gmac0-phy-irq { > + pinmux = ; > + bias-disable; > + }; > + > + pinctrl_gmac0_txck_default: gmac0-txck-default { > + pinmux = ; > + slew-rate = <0>; > + bias-pull-up; > + }; > + > pinctrl_i2c10_default: i2c10-default{ > pinmux = , > ;