devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084
@ 2025-10-07 11:15 Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 1/6] iio: adc: ad4080: fix chip identification Antoniu Miclaus
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Antoniu Miclaus @ 2025-10-07 11:15 UTC (permalink / raw)
  To: jic23, robh, conor+dt, linux-iio, linux-kernel, devicetree
  Cc: Antoniu Miclaus

Add support for AD4081 (16-bit, 4 LVDS CNV clock max) and AD4084
(18-bit, 6 LVDS CNV clock max) ADC variants to the existing AD4080
driver.

Changes:
 - Update device tree bindings to include AD4081 and AD4084
 - Add chip_info entries for AD4081 and AD4084 with appropriate
   resolution and LVDS CNV clock count
 - Modify channel definitions to accommodate different resolutions
 - Ensure backward compatibility with existing AD4080 functionality

Antoniu Miclaus (6):
  iio: adc: ad4080: fix chip identification
  iio: adc: ad4080: prepare driver for multi-part support
  dt-bindings: iio: adc: adi,ad4080: add support for AD4084
  iio: adc: ad4080: add support for AD4084
  dt-bindings: iio: adc: adi,ad4080: add support for AD4081
  iio: adc: ad4080: add support for AD4081

 .../bindings/iio/adc/adi,ad4080.yaml          |  2 +
 drivers/iio/adc/ad4080.c                      | 80 ++++++++++++++-----
 2 files changed, 60 insertions(+), 22 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v3 1/6] iio: adc: ad4080: fix chip identification
  2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
@ 2025-10-07 11:15 ` Antoniu Miclaus
  2025-10-07 14:41   ` Nuno Sá
  2025-10-07 11:15 ` [PATCH v3 2/6] iio: adc: ad4080: prepare driver for multi-part support Antoniu Miclaus
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 10+ messages in thread
From: Antoniu Miclaus @ 2025-10-07 11:15 UTC (permalink / raw)
  To: jic23, robh, conor+dt, linux-iio, linux-kernel, devicetree
  Cc: Antoniu Miclaus

Fix AD4080 chip identification by using the correct 16-bit product ID
(0x0050) instead of GENMASK(2, 0). Update the chip reading logic to
use regmap_bulk_read to read both PRODUCT_ID_L and PRODUCT_ID_H
registers and combine them into a 16-bit value.

The original implementation was incorrectly reading only 3 bits,
which would not correctly identify the AD4080 chip.

Fixes: 6b31ba1811b6 ("iio: adc: ad4080: add driver support")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
changes in v3:
 - use le16_to_cpu to convert the read little-endian value to CPU endianness
 drivers/iio/adc/ad4080.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index 6e61787ed321..ae5a975a47a5 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -125,7 +125,7 @@
 
 /* Miscellaneous Definitions */
 #define AD4080_SPI_READ						BIT(7)
-#define AD4080_CHIP_ID						GENMASK(2, 0)
+#define AD4080_CHIP_ID						0x0050
 
 #define AD4080_LVDS_CNV_CLK_CNT_MAX				7
 
@@ -445,7 +445,8 @@ static int ad4080_setup(struct iio_dev *indio_dev)
 {
 	struct ad4080_state *st = iio_priv(indio_dev);
 	struct device *dev = regmap_get_device(st->regmap);
-	unsigned int id;
+	__le16 id_le;
+	u16 id;
 	int ret;
 
 	ret = regmap_write(st->regmap, AD4080_REG_INTERFACE_CONFIG_A,
@@ -458,10 +459,11 @@ static int ad4080_setup(struct iio_dev *indio_dev)
 	if (ret)
 		return ret;
 
-	ret = regmap_read(st->regmap, AD4080_REG_CHIP_TYPE, &id);
+	ret = regmap_bulk_read(st->regmap, AD4080_REG_PRODUCT_ID_L, &id_le, 2);
 	if (ret)
 		return ret;
 
+	id = le16_to_cpu(id_le);
 	if (id != AD4080_CHIP_ID)
 		dev_info(dev, "Unrecognized CHIP_ID 0x%X\n", id);
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 2/6] iio: adc: ad4080: prepare driver for multi-part support
  2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 1/6] iio: adc: ad4080: fix chip identification Antoniu Miclaus
@ 2025-10-07 11:15 ` Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4084 Antoniu Miclaus
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Antoniu Miclaus @ 2025-10-07 11:15 UTC (permalink / raw)
  To: jic23, robh, conor+dt, linux-iio, linux-kernel, devicetree
  Cc: Antoniu Miclaus, Nuno Sá

Refactor the ad4080 driver to support multiple ADC variants with
different resolution bits and LVDS CNV clock count maximums.

Changes:
- Add lvds_cnv_clk_cnt_max field to chip_info structure
- Create AD4080_CHANNEL_DEFINE macro for variable resolution/storage bits
- Make LVDS CNV clock count configurable per chip variant
- Use chip_info->product_id for chip identification comparison

This prepares the infrastructure for adding support for additional
ADC parts with different specifications while maintaining backward
compatibility with existing AD4080 functionality.

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/adc/ad4080.c | 42 ++++++++++++++++++++++------------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index ae5a975a47a5..7231b93821cd 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -167,6 +167,7 @@ struct ad4080_chip_info {
 	const unsigned int (*scale_table)[2];
 	const struct iio_chan_spec *channels;
 	unsigned int num_channels;
+	unsigned int lvds_cnv_clk_cnt_max;
 };
 
 struct ad4080_state {
@@ -414,23 +415,25 @@ static struct iio_chan_spec_ext_info ad4080_ext_info[] = {
 	{ }
 };
 
-static const struct iio_chan_spec ad4080_channel = {
-	.type = IIO_VOLTAGE,
-	.indexed = 1,
-	.channel = 0,
-	.info_mask_separate = BIT(IIO_CHAN_INFO_SCALE),
-	.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ) |
-			BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
-	.info_mask_shared_by_all_available =
-			BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),
-	.ext_info = ad4080_ext_info,
-	.scan_index = 0,
-	.scan_type = {
-		.sign = 's',
-		.realbits = 20,
-		.storagebits = 32,
-	},
-};
+#define AD4080_CHANNEL_DEFINE(bits, storage) {				\
+	.type = IIO_VOLTAGE,						\
+	.indexed = 1,							\
+	.channel = 0,							\
+	.info_mask_separate = BIT(IIO_CHAN_INFO_SCALE),			\
+	.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ) |	\
+			BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),		\
+	.info_mask_shared_by_all_available =				\
+			BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO),		\
+	.ext_info = ad4080_ext_info,					\
+	.scan_index = 0,						\
+	.scan_type = {							\
+		.sign = 's',						\
+		.realbits = (bits),					\
+		.storagebits = (storage),				\
+	},								\
+}
+
+static const struct iio_chan_spec ad4080_channel = AD4080_CHANNEL_DEFINE(20, 32);
 
 static const struct ad4080_chip_info ad4080_chip_info = {
 	.name = "ad4080",
@@ -439,6 +442,7 @@ static const struct ad4080_chip_info ad4080_chip_info = {
 	.num_scales = ARRAY_SIZE(ad4080_scale_table),
 	.num_channels = 1,
 	.channels = &ad4080_channel,
+	.lvds_cnv_clk_cnt_max = AD4080_LVDS_CNV_CLK_CNT_MAX,
 };
 
 static int ad4080_setup(struct iio_dev *indio_dev)
@@ -464,7 +468,7 @@ static int ad4080_setup(struct iio_dev *indio_dev)
 		return ret;
 
 	id = le16_to_cpu(id_le);
-	if (id != AD4080_CHIP_ID)
+	if (id != st->info->product_id)
 		dev_info(dev, "Unrecognized CHIP_ID 0x%X\n", id);
 
 	ret = regmap_set_bits(st->regmap, AD4080_REG_GPIO_CONFIG_A,
@@ -490,7 +494,7 @@ static int ad4080_setup(struct iio_dev *indio_dev)
 				 AD4080_REG_ADC_DATA_INTF_CONFIG_B,
 				 AD4080_ADC_DATA_INTF_CONFIG_B_LVDS_CNV_CLK_CNT_MSK,
 				 FIELD_PREP(AD4080_ADC_DATA_INTF_CONFIG_B_LVDS_CNV_CLK_CNT_MSK,
-					    AD4080_LVDS_CNV_CLK_CNT_MAX));
+					    st->info->lvds_cnv_clk_cnt_max));
 	if (ret)
 		return ret;
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4084
  2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 1/6] iio: adc: ad4080: fix chip identification Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 2/6] iio: adc: ad4080: prepare driver for multi-part support Antoniu Miclaus
@ 2025-10-07 11:15 ` Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 4/6] iio: adc: ad4080: " Antoniu Miclaus
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Antoniu Miclaus @ 2025-10-07 11:15 UTC (permalink / raw)
  To: jic23, robh, conor+dt, linux-iio, linux-kernel, devicetree
  Cc: Antoniu Miclaus, Conor Dooley

Add device tree binding support for the AD4084 16-bit SAR ADC.
Add adi,ad4084 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the
AD4084 has different resolution (16-bit vs 20-bit) and LVDS CNV clock
count maximum (2 vs 7), requiring different driver configuration.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
index ed849ba1b77b..c4c5d208f502 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
@@ -26,6 +26,7 @@ properties:
   compatible:
     enum:
       - adi,ad4080
+      - adi,ad4084
 
   reg:
     maxItems: 1
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 4/6] iio: adc: ad4080: add support for AD4084
  2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
                   ` (2 preceding siblings ...)
  2025-10-07 11:15 ` [PATCH v3 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4084 Antoniu Miclaus
@ 2025-10-07 11:15 ` Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4081 Antoniu Miclaus
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 10+ messages in thread
From: Antoniu Miclaus @ 2025-10-07 11:15 UTC (permalink / raw)
  To: jic23, robh, conor+dt, linux-iio, linux-kernel, devicetree
  Cc: Antoniu Miclaus, Nuno Sá

Add support for AD4084 16-bit SAR ADC. The AD4084 differs from
AD4080 in resolution (16-bit vs 20-bit) and LVDS CNV clock count
maximum (2 vs 7).

Changes:
- Add AD4084_CHIP_ID definition (0x0054)
- Create ad4084_channel with 16-bit resolution and storage
- Add ad4084_chip_info with appropriate configuration
- Register AD4084 in device ID and OF match tables

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/adc/ad4080.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index 7231b93821cd..740176e86657 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -126,6 +126,7 @@
 /* Miscellaneous Definitions */
 #define AD4080_SPI_READ						BIT(7)
 #define AD4080_CHIP_ID						0x0050
+#define AD4084_CHIP_ID						0x0054
 
 #define AD4080_LVDS_CNV_CLK_CNT_MAX				7
 
@@ -435,6 +436,8 @@ static struct iio_chan_spec_ext_info ad4080_ext_info[] = {
 
 static const struct iio_chan_spec ad4080_channel = AD4080_CHANNEL_DEFINE(20, 32);
 
+static const struct iio_chan_spec ad4084_channel = AD4080_CHANNEL_DEFINE(16, 16);
+
 static const struct ad4080_chip_info ad4080_chip_info = {
 	.name = "ad4080",
 	.product_id = AD4080_CHIP_ID,
@@ -445,6 +448,16 @@ static const struct ad4080_chip_info ad4080_chip_info = {
 	.lvds_cnv_clk_cnt_max = AD4080_LVDS_CNV_CLK_CNT_MAX,
 };
 
+static const struct ad4080_chip_info ad4084_chip_info = {
+	.name = "ad4084",
+	.product_id = AD4084_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4084_channel,
+	.lvds_cnv_clk_cnt_max = 2,
+};
+
 static int ad4080_setup(struct iio_dev *indio_dev)
 {
 	struct ad4080_state *st = iio_priv(indio_dev);
@@ -599,12 +612,14 @@ static int ad4080_probe(struct spi_device *spi)
 
 static const struct spi_device_id ad4080_id[] = {
 	{ "ad4080", (kernel_ulong_t)&ad4080_chip_info },
+	{ "ad4084", (kernel_ulong_t)&ad4084_chip_info },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ad4080_id);
 
 static const struct of_device_id ad4080_of_match[] = {
 	{ .compatible = "adi,ad4080", &ad4080_chip_info },
+	{ .compatible = "adi,ad4084", &ad4084_chip_info },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ad4080_of_match);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4081
  2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
                   ` (3 preceding siblings ...)
  2025-10-07 11:15 ` [PATCH v3 4/6] iio: adc: ad4080: " Antoniu Miclaus
@ 2025-10-07 11:15 ` Antoniu Miclaus
  2025-10-07 11:15 ` [PATCH v3 6/6] iio: adc: ad4080: " Antoniu Miclaus
  2025-10-12 18:11 ` [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Jonathan Cameron
  6 siblings, 0 replies; 10+ messages in thread
From: Antoniu Miclaus @ 2025-10-07 11:15 UTC (permalink / raw)
  To: jic23, robh, conor+dt, linux-iio, linux-kernel, devicetree
  Cc: Antoniu Miclaus, Conor Dooley

Add device tree binding support for the AD4081 20-bit SAR ADC.
Add adi,ad4081 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the
AD4081 has a different LVDS CNV clock count maximum (2 vs 7), requiring
different driver configuration.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
index c4c5d208f502..a9fa068189ea 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
@@ -26,6 +26,7 @@ properties:
   compatible:
     enum:
       - adi,ad4080
+      - adi,ad4081
       - adi,ad4084
 
   reg:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 6/6] iio: adc: ad4080: add support for AD4081
  2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
                   ` (4 preceding siblings ...)
  2025-10-07 11:15 ` [PATCH v3 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4081 Antoniu Miclaus
@ 2025-10-07 11:15 ` Antoniu Miclaus
  2025-10-12 18:11 ` [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Jonathan Cameron
  6 siblings, 0 replies; 10+ messages in thread
From: Antoniu Miclaus @ 2025-10-07 11:15 UTC (permalink / raw)
  To: jic23, robh, conor+dt, linux-iio, linux-kernel, devicetree
  Cc: Antoniu Miclaus, Nuno Sá

Add support for AD4081 20-bit SAR ADC. The AD4081 has the same
resolution as AD4080 (20-bit) but differs in LVDS CNV clock count
maximum (2 vs 7).

Changes:
- Add AD4081_CHIP_ID definition (0x0051)
- Create ad4081_channel with 20-bit resolution and 32-bit storage
- Add ad4081_chip_info with lvds_cnv_clk_cnt_max = 2
- Register AD4081 in device ID and OF match tables

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/adc/ad4080.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
index 740176e86657..6398106da335 100644
--- a/drivers/iio/adc/ad4080.c
+++ b/drivers/iio/adc/ad4080.c
@@ -126,6 +126,7 @@
 /* Miscellaneous Definitions */
 #define AD4080_SPI_READ						BIT(7)
 #define AD4080_CHIP_ID						0x0050
+#define AD4081_CHIP_ID						0x0051
 #define AD4084_CHIP_ID						0x0054
 
 #define AD4080_LVDS_CNV_CLK_CNT_MAX				7
@@ -436,6 +437,8 @@ static struct iio_chan_spec_ext_info ad4080_ext_info[] = {
 
 static const struct iio_chan_spec ad4080_channel = AD4080_CHANNEL_DEFINE(20, 32);
 
+static const struct iio_chan_spec ad4081_channel = AD4080_CHANNEL_DEFINE(20, 32);
+
 static const struct iio_chan_spec ad4084_channel = AD4080_CHANNEL_DEFINE(16, 16);
 
 static const struct ad4080_chip_info ad4080_chip_info = {
@@ -448,6 +451,16 @@ static const struct ad4080_chip_info ad4080_chip_info = {
 	.lvds_cnv_clk_cnt_max = AD4080_LVDS_CNV_CLK_CNT_MAX,
 };
 
+static const struct ad4080_chip_info ad4081_chip_info = {
+	.name = "ad4081",
+	.product_id = AD4081_CHIP_ID,
+	.scale_table = ad4080_scale_table,
+	.num_scales = ARRAY_SIZE(ad4080_scale_table),
+	.num_channels = 1,
+	.channels = &ad4081_channel,
+	.lvds_cnv_clk_cnt_max = 2,
+};
+
 static const struct ad4080_chip_info ad4084_chip_info = {
 	.name = "ad4084",
 	.product_id = AD4084_CHIP_ID,
@@ -612,6 +625,7 @@ static int ad4080_probe(struct spi_device *spi)
 
 static const struct spi_device_id ad4080_id[] = {
 	{ "ad4080", (kernel_ulong_t)&ad4080_chip_info },
+	{ "ad4081", (kernel_ulong_t)&ad4081_chip_info },
 	{ "ad4084", (kernel_ulong_t)&ad4084_chip_info },
 	{ }
 };
@@ -619,6 +633,7 @@ MODULE_DEVICE_TABLE(spi, ad4080_id);
 
 static const struct of_device_id ad4080_of_match[] = {
 	{ .compatible = "adi,ad4080", &ad4080_chip_info },
+	{ .compatible = "adi,ad4081", &ad4081_chip_info },
 	{ .compatible = "adi,ad4084", &ad4084_chip_info },
 	{ }
 };
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 1/6] iio: adc: ad4080: fix chip identification
  2025-10-07 11:15 ` [PATCH v3 1/6] iio: adc: ad4080: fix chip identification Antoniu Miclaus
@ 2025-10-07 14:41   ` Nuno Sá
  2025-10-12 18:10     ` Jonathan Cameron
  0 siblings, 1 reply; 10+ messages in thread
From: Nuno Sá @ 2025-10-07 14:41 UTC (permalink / raw)
  To: Antoniu Miclaus, jic23, robh, conor+dt, linux-iio, linux-kernel,
	devicetree

On Tue, 2025-10-07 at 11:15 +0000, Antoniu Miclaus wrote:
> Fix AD4080 chip identification by using the correct 16-bit product ID
> (0x0050) instead of GENMASK(2, 0). Update the chip reading logic to
> use regmap_bulk_read to read both PRODUCT_ID_L and PRODUCT_ID_H
> registers and combine them into a 16-bit value.
> 
> The original implementation was incorrectly reading only 3 bits,
> which would not correctly identify the AD4080 chip.
> 
> Fixes: 6b31ba1811b6 ("iio: adc: ad4080: add driver support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---

Small nitpick below that Jonathan might tweak if he thinks it's worth it.
Anyways,

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> changes in v3:
>  - use le16_to_cpu to convert the read little-endian value to CPU endianness
>  drivers/iio/adc/ad4080.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> index 6e61787ed321..ae5a975a47a5 100644
> --- a/drivers/iio/adc/ad4080.c
> +++ b/drivers/iio/adc/ad4080.c
> @@ -125,7 +125,7 @@
>  
>  /* Miscellaneous Definitions */
>  #define
> AD4080_SPI_READ						BIT(7)
> -#define AD4080_CHIP_ID						GENMASK(2, 0)
> +#define AD4080_CHIP_ID						0x0050
>  
>  #define AD4080_LVDS_CNV_CLK_CNT_MAX				7
>  
> @@ -445,7 +445,8 @@ static int ad4080_setup(struct iio_dev *indio_dev)
>  {
>  	struct ad4080_state *st = iio_priv(indio_dev);
>  	struct device *dev = regmap_get_device(st->regmap);
> -	unsigned int id;
> +	__le16 id_le;
> +	u16 id;
>  	int ret;
>  
>  	ret = regmap_write(st->regmap, AD4080_REG_INTERFACE_CONFIG_A,
> @@ -458,10 +459,11 @@ static int ad4080_setup(struct iio_dev *indio_dev)
>  	if (ret)
>  		return ret;
>  
> -	ret = regmap_read(st->regmap, AD4080_REG_CHIP_TYPE, &id);
> +	ret = regmap_bulk_read(st->regmap, AD4080_REG_PRODUCT_ID_L, &id_le,
> 2);

sizeof(id_le)

>  	if (ret)
>  		return ret;
>  
> +	id = le16_to_cpu(id_le);
>  	if (id != AD4080_CHIP_ID)
>  		dev_info(dev, "Unrecognized CHIP_ID 0x%X\n", id);
>  

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 1/6] iio: adc: ad4080: fix chip identification
  2025-10-07 14:41   ` Nuno Sá
@ 2025-10-12 18:10     ` Jonathan Cameron
  0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2025-10-12 18:10 UTC (permalink / raw)
  To: Nuno Sá
  Cc: Antoniu Miclaus, robh, conor+dt, linux-iio, linux-kernel,
	devicetree

On Tue, 07 Oct 2025 15:41:02 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Tue, 2025-10-07 at 11:15 +0000, Antoniu Miclaus wrote:
> > Fix AD4080 chip identification by using the correct 16-bit product ID
> > (0x0050) instead of GENMASK(2, 0). Update the chip reading logic to
> > use regmap_bulk_read to read both PRODUCT_ID_L and PRODUCT_ID_H
> > registers and combine them into a 16-bit value.
> > 
> > The original implementation was incorrectly reading only 3 bits,
> > which would not correctly identify the AD4080 chip.
> > 
> > Fixes: 6b31ba1811b6 ("iio: adc: ad4080: add driver support")
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---  
> 
> Small nitpick below that Jonathan might tweak if he thinks it's worth it.
> Anyways,
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>

I'll tidy that up.

I'm currently taking a possibly controversial route with this patch.

Given I think we just get a false warning message without it, I'm going
to assume this isn't critical and queue it up for next merge window.
The advantage is I don't have to deal with tracking this patch going upstream
before I can apply the others in the series...

Shout if you'd prefer the harder route that gets this upstream faster.

Jonathan

> 
> > changes in v3:
> >  - use le16_to_cpu to convert the read little-endian value to CPU endianness
> >  drivers/iio/adc/ad4080.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> > index 6e61787ed321..ae5a975a47a5 100644
> > --- a/drivers/iio/adc/ad4080.c
> > +++ b/drivers/iio/adc/ad4080.c
> > @@ -125,7 +125,7 @@
> >  
> >  /* Miscellaneous Definitions */
> >  #define
> > AD4080_SPI_READ						BIT(7)
> > -#define AD4080_CHIP_ID						GENMASK(2, 0)
> > +#define AD4080_CHIP_ID						0x0050
> >  
> >  #define AD4080_LVDS_CNV_CLK_CNT_MAX				7
> >  
> > @@ -445,7 +445,8 @@ static int ad4080_setup(struct iio_dev *indio_dev)
> >  {
> >  	struct ad4080_state *st = iio_priv(indio_dev);
> >  	struct device *dev = regmap_get_device(st->regmap);
> > -	unsigned int id;
> > +	__le16 id_le;
> > +	u16 id;
> >  	int ret;
> >  
> >  	ret = regmap_write(st->regmap, AD4080_REG_INTERFACE_CONFIG_A,
> > @@ -458,10 +459,11 @@ static int ad4080_setup(struct iio_dev *indio_dev)
> >  	if (ret)
> >  		return ret;
> >  
> > -	ret = regmap_read(st->regmap, AD4080_REG_CHIP_TYPE, &id);
> > +	ret = regmap_bulk_read(st->regmap, AD4080_REG_PRODUCT_ID_L, &id_le,
> > 2);  
> 
> sizeof(id_le)
> 
> >  	if (ret)
> >  		return ret;
> >  
> > +	id = le16_to_cpu(id_le);
> >  	if (id != AD4080_CHIP_ID)
> >  		dev_info(dev, "Unrecognized CHIP_ID 0x%X\n", id);
> >    


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084
  2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
                   ` (5 preceding siblings ...)
  2025-10-07 11:15 ` [PATCH v3 6/6] iio: adc: ad4080: " Antoniu Miclaus
@ 2025-10-12 18:11 ` Jonathan Cameron
  6 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2025-10-12 18:11 UTC (permalink / raw)
  To: Antoniu Miclaus; +Cc: robh, conor+dt, linux-iio, linux-kernel, devicetree

On Tue, 7 Oct 2025 11:15:19 +0000
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Add support for AD4081 (16-bit, 4 LVDS CNV clock max) and AD4084
> (18-bit, 6 LVDS CNV clock max) ADC variants to the existing AD4080
> driver.
> 
> Changes:
>  - Update device tree bindings to include AD4081 and AD4084
>  - Add chip_info entries for AD4081 and AD4084 with appropriate
>    resolution and LVDS CNV clock count
>  - Modify channel definitions to accommodate different resolutions
>  - Ensure backward compatibility with existing AD4080 functionality
> 
> Antoniu Miclaus (6):
>   iio: adc: ad4080: fix chip identification
>   iio: adc: ad4080: prepare driver for multi-part support
>   dt-bindings: iio: adc: adi,ad4080: add support for AD4084
>   iio: adc: ad4080: add support for AD4084
>   dt-bindings: iio: adc: adi,ad4080: add support for AD4081
>   iio: adc: ad4080: add support for AD4081
> 
>  .../bindings/iio/adc/adi,ad4080.yaml          |  2 +
>  drivers/iio/adc/ad4080.c                      | 80 ++++++++++++++-----
>  2 files changed, 60 insertions(+), 22 deletions(-)
> 

Series applied to the testing branch of iio.git.  I marked patch 1
for stable. See that patch discussion for why I did things this way.

thanks

Jonathan

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-10-12 18:11 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-07 11:15 [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Antoniu Miclaus
2025-10-07 11:15 ` [PATCH v3 1/6] iio: adc: ad4080: fix chip identification Antoniu Miclaus
2025-10-07 14:41   ` Nuno Sá
2025-10-12 18:10     ` Jonathan Cameron
2025-10-07 11:15 ` [PATCH v3 2/6] iio: adc: ad4080: prepare driver for multi-part support Antoniu Miclaus
2025-10-07 11:15 ` [PATCH v3 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4084 Antoniu Miclaus
2025-10-07 11:15 ` [PATCH v3 4/6] iio: adc: ad4080: " Antoniu Miclaus
2025-10-07 11:15 ` [PATCH v3 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4081 Antoniu Miclaus
2025-10-07 11:15 ` [PATCH v3 6/6] iio: adc: ad4080: " Antoniu Miclaus
2025-10-12 18:11 ` [PATCH v3 0/6] iio: adc: ad4080: add support for AD4081 and AD4084 Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).