Re: [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller

[neil.armstrong@linaro.org]

Hi,

On 22/08/2023 13:11, Zelong Dong wrote:
> 
> 
> 在 2023/3/2 17:24, Neil Armstrong 写道:
>> On 02/03/2023 07:34, zelong dong wrote:
>>> From: Zelong Dong <zelong.dong@amlogic.com>
>>>
>>> Add new compatible for Amlogic's Meson-S4 IR Controller
>>>
>>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>>> ---
>>>   Documentation/devicetree/bindings/media/meson-ir.txt | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/meson-ir.txt b/Documentation/devicetree/bindings/media/meson-ir.txt
>>> index efd9d29a8f10..2a6662edd04d 100644
>>> --- a/Documentation/devicetree/bindings/media/meson-ir.txt
>>> +++ b/Documentation/devicetree/bindings/media/meson-ir.txt
>>> @@ -5,11 +5,14 @@ Required properties:
>>>             - "amlogic,meson6-ir"
>>>             - "amlogic,meson8b-ir"
>>>             - "amlogic,meson-gxbb-ir"
>>> +          - "amlogic,meson-s4-ir"
>>>    - reg        : physical base address and length of the device registers
>>>    - interrupts    : a single specifier for the interrupt from the device
>>>   Optional properties:
>>>    - linux,rc-map-name:    see rc.txt file in the same directory.
>>> + - amlogic,ir-support-hw-decode: enable hardware IR Decoder, and register
>>> +                 rc driver as type RC_DRIVER_SCANCODE
>>
>> AFAIK this is a software parameter since the HW is capable of decoding,
>> if you want to make the HW decoding a runtime option, please use another way.
> 
> Part 1 patch for HW IR Decoder was queued, now I'm preparing part 2.
> I add a new property "amlogic,ir-support-hw-decode" because I think rc driver don't support change the driver type (enum rc_driver_type) dynamically, it need to declare the type in DTS.
> Am I right?

DT should not have software parameters, it's ok to enable the HW decoding for a specific compatible for example.

Neil

>>
>>>   Example:
>>
>> Please base changes on top of https://lore.kernel.org/all/20221117-b4-amlogic-bindings-convert-v3-4-e28dd31e3bed@linaro.org/
>>
>> Thanks,
>> Neil
>>