From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E912C433FE for ; Wed, 13 Apr 2022 15:25:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231797AbiDMP14 (ORCPT ); Wed, 13 Apr 2022 11:27:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233139AbiDMP1z (ORCPT ); Wed, 13 Apr 2022 11:27:55 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4199B5DA4A for ; Wed, 13 Apr 2022 08:25:33 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id ks6so4728644ejb.1 for ; Wed, 13 Apr 2022 08:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=E/KosFpseT7IWJRZQCnSiS447R6ssnKcrthoESTGiCY=; b=Vh4Nsq/68C5HjeI3A+yT1TCrzlxkKT0sfz8S3WArS7wXqU2HMY1kjSoZ15QEZmFtM6 OFYv1iWTnr+tlMIiILChInAOK+egjDR+MtIwNLJlFgSPS0IaHvcSB/B8FcrmDr+ZyIDg IiiQB3pNO94TEGvLWtXS/CjPEk0O7T7J0MsTPVtfkCt+WO4kRbnT4evsF7X3kPB8ayF4 5J/XJAFVO/Wopdl0EmW8QilO0Iz/XWwoNMkPhoQJPNm2KavV8w9DXemGntKKxv+uKR1E Mxe3ylpT7zTGScy4KM865rbxBZMJ4K0dj47qLEXSEyh6zUTCCLXrC6xnjkDTbvcgjPHW 96/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=E/KosFpseT7IWJRZQCnSiS447R6ssnKcrthoESTGiCY=; b=b+lEDMcTGBtggWcX/rgLS3eG2YpJWzAA+yOj/OkuKZDIh68r+cS82EiDyaXbXQ3vgI 7aZmgprZXZX6lCxjGHsYDYC8DZDHbYIIZjfuu1ct4xhKZCpKWn0zI1Z2M09Fp2s2yBS6 h3sz2AZDHTM1SUEe1Sl8Dcip8dcrCVS85tjLwOV9ozYZQ//JaRFJmdQo4q135gCuov/o k0j6GGdJyM8CQVviUcmIdv3z/c0bm+ca7hKx1TKeR8Yk0ukvgCxULUMARpA6WlOwEJsN JdSTSSQuYxD7BJTsXU67L4/ZnQldUXkrHcls2s9WkncMes/6+Ug1JXJzaYVxkcFuY2Zt rZCQ== X-Gm-Message-State: AOAM533MU7bK0qffCStrH04IS9kYHTLbowvJcg5scicnnttRv1KLOZon iP3GCj1vvhquZjGVhyUFYnkVww== X-Google-Smtp-Source: ABdhPJy/Caleobpyz0qcwl3NnfHCSIKGS22hcXQsHSSVLfDURXci+05UMvKVZOUGgl9LtMNCuV3Fuw== X-Received: by 2002:a17:907:2d27:b0:6e8:3ea6:7645 with SMTP id gs39-20020a1709072d2700b006e83ea67645mr28970048ejc.727.1649863531801; Wed, 13 Apr 2022 08:25:31 -0700 (PDT) Received: from [192.168.0.205] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id h7-20020a1709060f4700b006e8d0746969sm83440ejj.222.2022.04.13.08.25.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 08:25:30 -0700 (PDT) Message-ID: Date: Wed, 13 Apr 2022 17:25:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 10/14] dt-bindings: pinctrl: rt2880: fix binding name, pin groups and functions Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Sergio Paracuellos , Luiz Angelo Daros de Luca , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Thomas Bogendoerfer , Matthias Brugger Cc: erkin.bozoglu@xeront.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org References: <20220413060729.27639-1-arinc.unal@arinc9.com> <20220413060729.27639-11-arinc.unal@arinc9.com> From: Krzysztof Kozlowski In-Reply-To: <20220413060729.27639-11-arinc.unal@arinc9.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/04/2022 08:07, Arınç ÜNAL wrote: > Change binding name from ralink,rt2880-pinmux to ralink,rt2880-pinctrl. > This is the binding for the Ralink RT2880 pinctrl subdriver. What I don't see here is why you are doing this. pinmux/pinctrl have the same meaning, I guess? > > Current pin group and function bindings are for MT7621. Put bindings for > RT2880 instead. > > Signed-off-by: Arınç ÜNAL > --- > ...pinmux.yaml => ralink,rt2880-pinctrl.yaml} | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > rename Documentation/devicetree/bindings/pinctrl/{ralink,rt2880-pinmux.yaml => ralink,rt2880-pinctrl.yaml} (56%) > > diff --git a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml > similarity index 56% > rename from Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml > rename to Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml > index 9de8b0c075e2..c657bbf9fdda 100644 > --- a/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinmux.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/ralink,rt2880-pinctrl.yaml > @@ -1,21 +1,23 @@ > # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/pinctrl/ralink,rt2880-pinmux.yaml# > +$id: http://devicetree.org/schemas/pinctrl/ralink,rt2880-pinctrl.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Ralink rt2880 pinmux controller > +title: Ralink RT2880 Pin Controller > > maintainers: > + - Arınç ÜNAL Mention this in commit msg. > - Sergio Paracuellos > > description: > - The rt2880 pinmux can only set the muxing of pin groups. Muxing indiviual pins > + Ralink RT2880 pin controller for RT2880 SoC. > + The pin controller can only set the muxing of pin groups. Muxing indiviual pins > is not supported. There is no pinconf support. > > properties: > compatible: > - const: ralink,rt2880-pinmux > + const: ralink,rt2880-pinctrl you need to deprecate old property and add a new one. > > patternProperties: > '-pins$': > @@ -28,14 +30,12 @@ patternProperties: > > properties: > groups: > - description: Name of the pin group to use for the functions. > - enum: [i2c, jtag, mdio, pcie, rgmii1, rgmii2, sdhci, spi, > - uart1, uart2, uart3, wdt] > + description: The pin group to select. > + enum: [i2c, spi, uartlite, jtag, mdio, sdram, pci] > + > function: > - description: The mux function to select > - enum: [gpio, i2c, i2s, jtag, mdio, nand1, nand2, pcie refclk, > - pcie rst, pcm, rgmii1, rgmii2, sdhci, spdif2, spdif3, > - spi, uart1, uart2, uart3, wdt refclk, wdt rst] > + description: The mux function to select. > + enum: [gpio, i2c, spi, uartlite, jtag, mdio, sdram, pci] > These were all incorrect for rt2880, I understand? Best regards, Krzysztof