From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EEFEE49A5 for ; Sat, 19 Aug 2023 12:47:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232544AbjHSMrq (ORCPT ); Sat, 19 Aug 2023 08:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232488AbjHSMrq (ORCPT ); Sat, 19 Aug 2023 08:47:46 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01DB22A2D for ; Sat, 19 Aug 2023 05:46:21 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99bcf2de59cso226402966b.0 for ; Sat, 19 Aug 2023 05:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692449180; x=1693053980; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pgQakRG+/IxAgG5KIp0blnFHhBf98jcw1gjHSQfAMhU=; b=jE2j+v1yEXxx3S80AV52Kr3yHs9VM3DK5N74eEpRUvemTJbE97usvhvzZkidP/knw/ GbyEDu4481wlUYvRWLFvXXq9BchZnFk+W4NVDyxKHG0tUoITrUaINNQiRRiSbP2USbQk Kb+ezDyXT5vcYxR1RU3KtJmpySq9LkNXKsQJWj69oiWbAkDAy8QpmyEVp5jKjef8b75r gAMnACYx7ALLcdxXIoZrcpyP3qGH6Xy0yFMoIHdOns5JkQQjS/pMeeKAq8DsAp0UcxKG 6BvXe9pwyQWW9K/GHyLlT529WF8dFc4hQFBQeKP90MbeNNudDEUTidHo8KWIblX8/PFp rgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692449180; x=1693053980; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pgQakRG+/IxAgG5KIp0blnFHhBf98jcw1gjHSQfAMhU=; b=fZeJMc5E7ZaSnl2P5tv0dVsL/kKLujUMqyqhRQbVsTwaJZGJbkh0cAh+cRlKMuawPh wAiyL/qDcwl/gnliZsJG6twZZb3dqquFjsLOOP4Nu5Em+728yimORaC0aPWDl4C+KN41 GbfhkDrQLYHbqOSAIxhOBwaWf8tQqQjF4nxFXUvo/cr3d7YPykhdK7PBD0B7uCuu3CLA E/fBjlzOWKL7yG81PnQKUiSVFPtGua2TS8lrHgw+aFvSA1cAsObE9D4NNBgwO+7+foBy wUpeZbOwZ4aD5cwRwNSozfzB/wqV5sEaqjbbPKY3ZVcsMYsSUO0ip6UB//lXJvzJDFb3 eqpg== X-Gm-Message-State: AOJu0Yx/syXqjiroNoiTXIw0uEvBWRjDzkabvkOOX7KcAfgG1OpORaRY 4eGAt+4qogU4rKaSBLkCn4+Lyw== X-Google-Smtp-Source: AGHT+IFUJWEjwf2m+gKo06Pbl83FhgotKSlIy3Dwb8z92hYw7hrFGxTP7ZiYBAOODXX9MAotF1AsLw== X-Received: by 2002:a17:906:7698:b0:973:ff8d:2a46 with SMTP id o24-20020a170906769800b00973ff8d2a46mr1422612ejm.3.1692449179880; Sat, 19 Aug 2023 05:46:19 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id qq12-20020a17090720cc00b0099d0c0bb92bsm2610166ejb.80.2023.08.19.05.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Aug 2023 05:46:19 -0700 (PDT) Message-ID: Date: Sat, 19 Aug 2023 14:46:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] dt-bindings: usb: Add ti,tps25750 Content-Language: en-US To: Abdel Alkuor , devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Abdel Alkuor References: <20230818153015.513053-1-alkuor@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230818153015.513053-1-alkuor@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/08/2023 17:30, Abdel Alkuor wrote: > From: Abdel Alkuor > > TPS25750 provides power negotiation and capabilities management > for USB Type-C applications. > > Signed-off-by: Abdel Alkuor > --- > v2: git format-patch -v2 -1 > - Remove redundant word 'binding' from Subject > - Add new line before reg property > - Remove unused description in interrupts property > - Drop interrupt-names property > - Add maxItems to firmware-name property > - Use generic node name 'typec' instead of 'tps25750' > --- > .../devicetree/bindings/usb/ti,tps25750.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ti,tps25750.yaml > > diff --git a/Documentation/devicetree/bindings/usb/ti,tps25750.yaml b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml > new file mode 100644 > index 000000000000..d98c34df340d > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/ti,tps25750.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments 25750 Type-C Port Switch and Power Delivery controller > + > +maintainers: > + - Abdel Alkuor > + > +description: | > + Texas Instruments 25750 Type-C Port Switch and Power Delivery controller > + > +properties: > + compatible: > + enum: > + - ti,tps25750 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + firmware-name: > + description: | > + Should contain the name of the default patch binary > + file located on the firmware search path which is > + used to switch the controller into APP mode > + maxItems: 1 > + > + connector: > + type: object > + $ref: ../connector/usb-connector.yaml# > + description: > + Properties for usb c connector. > + required: > + - data-role > + > +required: > + - compatible > + - reg > + - interrupts > + - connector > + > +additionalProperties: true > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + typec: tps25750@21 { Nothing improved in node name. Drop the label "typec", because it is not used. I still wait for the user, as I wrote in your v1. Best regards, Krzysztof