From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Caleb Connolly <caleb.connolly@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: Amit Pundir <amit.pundir@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH 2/6] arm64: dts: qcom: pmi8998: add smb2 node
Date: Sat, 2 Apr 2022 16:40:26 +0200 [thread overview]
Message-ID: <ba93d501-56db-143c-164a-333ae573d9f0@linaro.org> (raw)
In-Reply-To: <20220401202643.877609-3-caleb.connolly@linaro.org>
On 01/04/2022 22:26, Caleb Connolly wrote:
> Add a node for the smb2 charger hardware found on the pmi8998.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index da10668c361d..b98dad166a0b 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -9,6 +9,21 @@ pmi8998_lsid0: pmic@2 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pmi8998_smb2: smb2@1000 {
Generic node name please, so "charger". Have in mind that PMIC
(parent's) schema might require it.
If it exists (I did not check), it should reference also your charger's
schema.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-02 14:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 20:26 [PATCH 0/6] power: supply: introduce the Qualcomm smb2 Caleb Connolly
2022-04-01 20:26 ` [PATCH 1/6] power: supply: add Qualcomm SMB2 driver Caleb Connolly
2022-04-01 22:53 ` Sebastian Reichel
2022-04-02 15:45 ` Caleb Connolly
2022-04-04 13:11 ` Bjorn Andersson
2022-04-01 20:26 ` [PATCH 2/6] arm64: dts: qcom: pmi8998: add smb2 node Caleb Connolly
2022-04-02 14:40 ` Krzysztof Kozlowski [this message]
2022-04-01 20:26 ` [PATCH 3/6] arm64: dts: sdm845-oneplus: enable smb2 Caleb Connolly
2022-04-01 20:26 ` [PATCH 4/6] arm64: dts: qcom: sdm845-db845c: " Caleb Connolly
2022-04-01 20:26 ` [PATCH 5/6] arm64: dts: qcom: sdm845-xiaomi-beryllium " Caleb Connolly
2022-04-01 20:26 ` [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver Caleb Connolly
2022-04-01 23:03 ` Sebastian Reichel
2022-04-02 15:44 ` Caleb Connolly
2022-04-02 14:22 ` Krzysztof Kozlowski
2022-04-02 15:50 ` Caleb Connolly
2022-04-03 7:14 ` Kuldeep Singh
2022-04-03 7:56 ` Krzysztof Kozlowski
2022-04-03 13:31 ` Kuldeep Singh
2022-04-03 15:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba93d501-56db-143c-164a-333ae573d9f0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).