From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>,
Sander Vanheule <sander@svanheule.net>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rustam Adilov <adilov@disroot.org>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: realtek,otto-wdt: Add fallback compatible
Date: Thu, 14 May 2026 18:08:38 +0200 [thread overview]
Message-ID: <ba9c6745-47e0-4964-a568-a76e5447d2d6@kernel.org> (raw)
In-Reply-To: <1be8c11b-a020-44d6-86ef-109418e1d968@roeck-us.net>
On 14/05/2026 02:20, Guenter Roeck wrote:
>> + oneOf:
>> + - items:
>> + - enum:
>> + - realtek,rtl8380-wdt
>> + - realtek,rtl8390-wdt
>> + - realtek,rtl9300-wdt
>> + - realtek,rtl9310-wdt
>> + - const: realtek,otto-wdt
>
> For the Apple watchdog driver, the generic property "apple,wdt" is
> considered to be bad and is not supposed to be used for newer chips.
> For this watchdog driver, a generic property is introduced.
>
> What is the overall logic ? Is there some rule when a generic property
> such as "realtek,otto-wdt" is appropriate and preferred, and when it isn't
> (as in "apple,wdt") ?
Except what Rob said, it is also documented:
https://elixir.bootlin.com/linux/v7.1-rc3/source/Documentation/devicetree/bindings/writing-bindings.rst#L60
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-14 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 20:48 [PATCH v2 0/2] watchdog: realtek-otto: add fallback compatible Sander Vanheule
2026-05-12 20:48 ` [PATCH v2 1/2] dt-bindings: watchdog: realtek,otto-wdt: Add " Sander Vanheule
2026-05-14 0:20 ` Guenter Roeck
2026-05-14 16:03 ` Rob Herring
2026-05-14 16:08 ` Krzysztof Kozlowski [this message]
2026-05-12 20:48 ` [PATCH v2 2/2] watchdog: realtek-otto: add " Sander Vanheule
2026-05-14 16:10 ` [PATCH v2 0/2] " Rob Herring
2026-05-14 16:25 ` Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9c6745-47e0-4964-a568-a76e5447d2d6@kernel.org \
--to=krzk@kernel.org \
--cc=adilov@disroot.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox