* [PATCH linux-next v6 01/13] dt-bindings: Add a document of PECI subsystem
2018-06-21 19:37 [PATCH linux-next v6 00/13] PECI device driver introduction Jae Hyun Yoo
@ 2018-06-21 19:39 ` Jae Hyun Yoo
2018-07-03 16:47 ` Rob Herring
2018-06-21 19:40 ` [PATCH linux-next v6 04/13] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs Jae Hyun Yoo
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-06-21 19:39 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, devicetree, linux-kernel, openbmc
Cc: Jae Hyun Yoo, Andrew Jeffery, Joel Stanley
This commit adds a document of generic PECI bus, adapter and client
driver.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Reviewed-by: James Feist <james.feist@linux.intel.com>
Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Joel Stanley <joel@jms.id.au>
---
.../devicetree/bindings/peci/peci.txt | 60 +++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/peci/peci.txt
diff --git a/Documentation/devicetree/bindings/peci/peci.txt b/Documentation/devicetree/bindings/peci/peci.txt
new file mode 100644
index 000000000000..5583aa80b78a
--- /dev/null
+++ b/Documentation/devicetree/bindings/peci/peci.txt
@@ -0,0 +1,60 @@
+Generic device tree configuration for PECI buses
+================================================
+
+Required properties:
+- compatible : Should be "simple-bus".
+- #address-cells : Should be present if the device has sub-nodes.
+- #size-cells : Should be present if the device has sub-nodes.
+- ranges : Should contain PECI controller registers ranges.
+
+Example:
+ peci: peci@10000000 {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x10000000 0x1000>;
+ };
+
+Generic device tree configuration for PECI adapters
+===================================================
+
+Required properties:
+- #address-cells : Should be <1>. Read more about client addresses below.
+- #size-cells : Should be <0>. Read more about client addresses below.
+
+The cells properties above define that an address of CPU clients of a PECI bus
+are described by a single value.
+
+Example:
+ peci0: peci-bus@0 {
+ compatible = "vendor,soc-peci";
+ reg = <0x0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+Generic device tree configuration for PECI clients
+==================================================
+
+Required properties:
+- compatible : Should contain name of PECI client.
+- reg : Should contain address of a client CPU. Address range of CPU
+ clients starts from 0x30 based on PECI specification.
+
+Example:
+ peci-bus@0 {
+ compatible = "vendor,soc-peci";
+ reg = <0x0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ peci-client@30 {
+ compatible = "vendor,peci-client";
+ reg = <0x30>;
+ };
+
+ peci-client@31 {
+ compatible = "vendor,peci-client";
+ reg = <0x31>;
+ };
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH linux-next v6 01/13] dt-bindings: Add a document of PECI subsystem
2018-06-21 19:39 ` [PATCH linux-next v6 01/13] dt-bindings: Add a document of PECI subsystem Jae Hyun Yoo
@ 2018-07-03 16:47 ` Rob Herring
2018-07-03 16:58 ` Jae Hyun Yoo
0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2018-07-03 16:47 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Mark Rutland, devicetree, linux-kernel, openbmc, Andrew Jeffery,
Joel Stanley
On Thu, Jun 21, 2018 at 12:39:47PM -0700, Jae Hyun Yoo wrote:
> This commit adds a document of generic PECI bus, adapter and client
> driver.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> Reviewed-by: James Feist <james.feist@linux.intel.com>
> Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> ---
> .../devicetree/bindings/peci/peci.txt | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/peci/peci.txt
>
> diff --git a/Documentation/devicetree/bindings/peci/peci.txt b/Documentation/devicetree/bindings/peci/peci.txt
> new file mode 100644
> index 000000000000..5583aa80b78a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/peci/peci.txt
> @@ -0,0 +1,60 @@
> +Generic device tree configuration for PECI buses
> +================================================
> +
> +Required properties:
> +- compatible : Should be "simple-bus".
> +- #address-cells : Should be present if the device has sub-nodes.
> +- #size-cells : Should be present if the device has sub-nodes.
> +- ranges : Should contain PECI controller registers ranges.
> +
> +Example:
> + peci: peci@10000000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x10000000 0x1000>;
> + };
I don't think you need this section. It's just the parent of the
controller, right?
> +
> +Generic device tree configuration for PECI adapters
> +===================================================
> +
> +Required properties:
> +- #address-cells : Should be <1>. Read more about client addresses below.
> +- #size-cells : Should be <0>. Read more about client addresses below.
> +
> +The cells properties above define that an address of CPU clients of a PECI bus
> +are described by a single value.
> +
> +Example:
> + peci0: peci-bus@0 {
> + compatible = "vendor,soc-peci";
> + reg = <0x0 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> +Generic device tree configuration for PECI clients
> +==================================================
> +
> +Required properties:
> +- compatible : Should contain name of PECI client.
> +- reg : Should contain address of a client CPU. Address range of CPU
> + clients starts from 0x30 based on PECI specification.
> +
> +Example:
> + peci-bus@0 {
> + compatible = "vendor,soc-peci";
> + reg = <0x0 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + peci-client@30 {
> + compatible = "vendor,peci-client";
> + reg = <0x30>;
> + };
> +
> + peci-client@31 {
> + compatible = "vendor,peci-client";
> + reg = <0x31>;
> + };
> + };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH linux-next v6 01/13] dt-bindings: Add a document of PECI subsystem
2018-07-03 16:47 ` Rob Herring
@ 2018-07-03 16:58 ` Jae Hyun Yoo
0 siblings, 0 replies; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-07-03 16:58 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, devicetree, linux-kernel, openbmc, Andrew Jeffery,
Joel Stanley
Hi Rob,
Thanks for the review. Please see my inline answer.
On 7/3/2018 9:47 AM, Rob Herring wrote:
> On Thu, Jun 21, 2018 at 12:39:47PM -0700, Jae Hyun Yoo wrote:
>> This commit adds a document of generic PECI bus, adapter and client
>> driver.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>> Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
>> Reviewed-by: James Feist <james.feist@linux.intel.com>
>> Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
>> Cc: Andrew Jeffery <andrew@aj.id.au>
>> Cc: Joel Stanley <joel@jms.id.au>
>> ---
>> .../devicetree/bindings/peci/peci.txt | 60 +++++++++++++++++++
>> 1 file changed, 60 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/peci/peci.txt
>>
>> diff --git a/Documentation/devicetree/bindings/peci/peci.txt b/Documentation/devicetree/bindings/peci/peci.txt
>> new file mode 100644
>> index 000000000000..5583aa80b78a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/peci/peci.txt
>> @@ -0,0 +1,60 @@
>> +Generic device tree configuration for PECI buses
>> +================================================
>> +
>> +Required properties:
>> +- compatible : Should be "simple-bus".
>> +- #address-cells : Should be present if the device has sub-nodes.
>> +- #size-cells : Should be present if the device has sub-nodes.
>> +- ranges : Should contain PECI controller registers ranges.
>> +
>> +Example:
>> + peci: peci@10000000 {
>> + compatible = "simple-bus";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x10000000 0x1000>;
>> + };
>
> I don't think you need this section. It's just the parent of the
> controller, right?
>
Right. I'll drop this section out.
Thanks a lot,
Jae
>> +
>> +Generic device tree configuration for PECI adapters
>> +===================================================
>> +
>> +Required properties:
>> +- #address-cells : Should be <1>. Read more about client addresses below.
>> +- #size-cells : Should be <0>. Read more about client addresses below.
>> +
>> +The cells properties above define that an address of CPU clients of a PECI bus
>> +are described by a single value.
>> +
>> +Example:
>> + peci0: peci-bus@0 {
>> + compatible = "vendor,soc-peci";
>> + reg = <0x0 0x1000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>> +
>> +Generic device tree configuration for PECI clients
>> +==================================================
>> +
>> +Required properties:
>> +- compatible : Should contain name of PECI client.
>> +- reg : Should contain address of a client CPU. Address range of CPU
>> + clients starts from 0x30 based on PECI specification.
>> +
>> +Example:
>> + peci-bus@0 {
>> + compatible = "vendor,soc-peci";
>> + reg = <0x0 0x1000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + peci-client@30 {
>> + compatible = "vendor,peci-client";
>> + reg = <0x30>;
>> + };
>> +
>> + peci-client@31 {
>> + compatible = "vendor,peci-client";
>> + reg = <0x31>;
>> + };
>> + };
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH linux-next v6 04/13] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs
2018-06-21 19:37 [PATCH linux-next v6 00/13] PECI device driver introduction Jae Hyun Yoo
2018-06-21 19:39 ` [PATCH linux-next v6 01/13] dt-bindings: Add a document of PECI subsystem Jae Hyun Yoo
@ 2018-06-21 19:40 ` Jae Hyun Yoo
2018-07-03 16:51 ` Rob Herring
2018-06-21 19:40 ` [PATCH linux-next v6 05/13] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
` (2 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-06-21 19:40 UTC (permalink / raw)
To: Jason M Biils, Rob Herring, Mark Rutland, Joel Stanley,
Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed,
linux-kernel, openbmc
Cc: Jae Hyun Yoo, Benjamin Herrenschmidt, Greg KH, Milton Miller II,
Pavel Machek, Robin Murphy, Ryan Chen
This commit adds a dt-bindings document of PECI adapter driver for ASPEED
AST24xx/25xx SoCs.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Reviewed-by: James Feist <james.feist@linux.intel.com>
Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Jason M Biils <jason.m.bills@linux.intel.com>
Cc: Milton Miller II <miltonm@us.ibm.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>
---
.../devicetree/bindings/peci/peci-aspeed.txt | 57 +++++++++++++++++++
1 file changed, 57 insertions(+)
create mode 100644 Documentation/devicetree/bindings/peci/peci-aspeed.txt
diff --git a/Documentation/devicetree/bindings/peci/peci-aspeed.txt b/Documentation/devicetree/bindings/peci/peci-aspeed.txt
new file mode 100644
index 000000000000..8c35f905589d
--- /dev/null
+++ b/Documentation/devicetree/bindings/peci/peci-aspeed.txt
@@ -0,0 +1,57 @@
+Device tree configuration for PECI buses on the AST24XX and AST25XX SoCs.
+
+Required properties:
+- compatible : Should be "aspeed,ast2400-peci" or "aspeed,ast2500-peci"
+ - aspeed,ast2400-peci: ASPEED AST2400 family PECI
+ controller
+ - aspeed,ast2500-peci: ASPEED AST2500 family PECI
+ controller
+- reg : Should contain PECI controller registers location and
+ length.
+- #address-cells : Should be <1> required to define a client address.
+- #size-cells : Should be <0> required to define a client address.
+- interrupts : Should contain PECI controller interrupt.
+- clocks : Should contain clock source for PECI controller. Should
+ reference the external oscillator clock in the second
+ cell.
+- resets : Should contain phandle to reset controller with the reset
+ number in the second cell.
+- clock-frequency : Should contain the operation frequency of PECI controller
+ in units of Hz.
+ 187500 ~ 24000000
+
+Optional properties:
+- msg-timing : Message timing negotiation period. This value will
+ determine the period of message timing negotiation to be
+ issued by PECI controller. The unit of the programmed
+ value is four times of PECI clock period.
+ 0 ~ 255 (default: 1)
+- addr-timing : Address timing negotiation period. This value will
+ determine the period of address timing negotiation to be
+ issued by PECI controller. The unit of the programmed
+ value is four times of PECI clock period.
+ 0 ~ 255 (default: 1)
+- rd-sampling-point : Read sampling point selection. The whole period of a bit
+ time will be divided into 16 time frames. This value will
+ determine the time frame in which the controller will
+ sample PECI signal for data read back. Usually in the
+ middle of a bit time is the best.
+ 0 ~ 15 (default: 8)
+- cmd-timeout-ms : Command timeout in units of ms.
+ 1 ~ 60000 (default: 1000)
+
+Example:
+ peci0: peci-bus@0 {
+ compatible = "aspeed,ast2500-peci";
+ reg = <0x0 0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <15>;
+ clocks = <&syscon ASPEED_CLK_GATE_REFCLK>;
+ resets = <&syscon ASPEED_RESET_PECI>;
+ clock-frequency = <24000000>;
+ msg-timing = <1>;
+ addr-timing = <1>;
+ rd-sampling-point = <8>;
+ cmd-timeout-ms = <1000>;
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH linux-next v6 04/13] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs
2018-06-21 19:40 ` [PATCH linux-next v6 04/13] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs Jae Hyun Yoo
@ 2018-07-03 16:51 ` Rob Herring
2018-07-03 17:01 ` Jae Hyun Yoo
0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2018-07-03 16:51 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Jason M Biils, Mark Rutland, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, openbmc,
Benjamin Herrenschmidt, Greg KH, Milton Miller II, Pavel Machek,
Robin Murphy, Ryan Chen
On Thu, Jun 21, 2018 at 12:40:24PM -0700, Jae Hyun Yoo wrote:
> This commit adds a dt-bindings document of PECI adapter driver for ASPEED
> AST24xx/25xx SoCs.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
> Reviewed-by: James Feist <james.feist@linux.intel.com>
> Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: Jason M Biils <jason.m.bills@linux.intel.com>
> Cc: Milton Miller II <miltonm@us.ibm.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
> .../devicetree/bindings/peci/peci-aspeed.txt | 57 +++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/peci/peci-aspeed.txt
>
> diff --git a/Documentation/devicetree/bindings/peci/peci-aspeed.txt b/Documentation/devicetree/bindings/peci/peci-aspeed.txt
> new file mode 100644
> index 000000000000..8c35f905589d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/peci/peci-aspeed.txt
> @@ -0,0 +1,57 @@
> +Device tree configuration for PECI buses on the AST24XX and AST25XX SoCs.
> +
> +Required properties:
> +- compatible : Should be "aspeed,ast2400-peci" or "aspeed,ast2500-peci"
> + - aspeed,ast2400-peci: ASPEED AST2400 family PECI
> + controller
> + - aspeed,ast2500-peci: ASPEED AST2500 family PECI
> + controller
Just this is sufficient:
Should be one of:
"aspeed,ast2400-peci"
"aspeed,ast2500-peci"
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> +- reg : Should contain PECI controller registers location and
> + length.
> +- #address-cells : Should be <1> required to define a client address.
> +- #size-cells : Should be <0> required to define a client address.
> +- interrupts : Should contain PECI controller interrupt.
> +- clocks : Should contain clock source for PECI controller. Should
> + reference the external oscillator clock in the second
> + cell.
> +- resets : Should contain phandle to reset controller with the reset
> + number in the second cell.
> +- clock-frequency : Should contain the operation frequency of PECI controller
> + in units of Hz.
> + 187500 ~ 24000000
> +
> +Optional properties:
> +- msg-timing : Message timing negotiation period. This value will
> + determine the period of message timing negotiation to be
> + issued by PECI controller. The unit of the programmed
> + value is four times of PECI clock period.
> + 0 ~ 255 (default: 1)
> +- addr-timing : Address timing negotiation period. This value will
> + determine the period of address timing negotiation to be
> + issued by PECI controller. The unit of the programmed
> + value is four times of PECI clock period.
> + 0 ~ 255 (default: 1)
> +- rd-sampling-point : Read sampling point selection. The whole period of a bit
> + time will be divided into 16 time frames. This value will
> + determine the time frame in which the controller will
> + sample PECI signal for data read back. Usually in the
> + middle of a bit time is the best.
> + 0 ~ 15 (default: 8)
> +- cmd-timeout-ms : Command timeout in units of ms.
> + 1 ~ 60000 (default: 1000)
> +
> +Example:
> + peci0: peci-bus@0 {
> + compatible = "aspeed,ast2500-peci";
> + reg = <0x0 0x60>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupts = <15>;
> + clocks = <&syscon ASPEED_CLK_GATE_REFCLK>;
> + resets = <&syscon ASPEED_RESET_PECI>;
> + clock-frequency = <24000000>;
> + msg-timing = <1>;
> + addr-timing = <1>;
> + rd-sampling-point = <8>;
> + cmd-timeout-ms = <1000>;
> + };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH linux-next v6 04/13] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs
2018-07-03 16:51 ` Rob Herring
@ 2018-07-03 17:01 ` Jae Hyun Yoo
0 siblings, 0 replies; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-07-03 17:01 UTC (permalink / raw)
To: Rob Herring
Cc: Jason M Biils, Mark Rutland, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, openbmc,
Benjamin Herrenschmidt, Greg KH, Milton Miller II, Pavel Machek,
Robin Murphy, Ryan Chen
Hi Rob,
Thanks a lot for the review. Please check my inline answer.
On 7/3/2018 9:51 AM, Rob Herring wrote:
> On Thu, Jun 21, 2018 at 12:40:24PM -0700, Jae Hyun Yoo wrote:
>> This commit adds a dt-bindings document of PECI adapter driver for ASPEED
>> AST24xx/25xx SoCs.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>> Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
>> Reviewed-by: James Feist <james.feist@linux.intel.com>
>> Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Cc: Greg KH <gregkh@linuxfoundation.org>
>> Cc: Jason M Biils <jason.m.bills@linux.intel.com>
>> Cc: Milton Miller II <miltonm@us.ibm.com>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Robin Murphy <robin.murphy@arm.com>
>> Cc: Ryan Chen <ryan_chen@aspeedtech.com>
>> ---
>> .../devicetree/bindings/peci/peci-aspeed.txt | 57 +++++++++++++++++++
>> 1 file changed, 57 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/peci/peci-aspeed.txt
>>
>> diff --git a/Documentation/devicetree/bindings/peci/peci-aspeed.txt b/Documentation/devicetree/bindings/peci/peci-aspeed.txt
>> new file mode 100644
>> index 000000000000..8c35f905589d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/peci/peci-aspeed.txt
>> @@ -0,0 +1,57 @@
>> +Device tree configuration for PECI buses on the AST24XX and AST25XX SoCs.
>> +
>> +Required properties:
>> +- compatible : Should be "aspeed,ast2400-peci" or "aspeed,ast2500-peci"
>> + - aspeed,ast2400-peci: ASPEED AST2400 family PECI
>> + controller
>> + - aspeed,ast2500-peci: ASPEED AST2500 family PECI
>> + controller
>
> Just this is sufficient:
>
> Should be one of:
> "aspeed,ast2400-peci"
> "aspeed,ast2500-peci"
>
> With that,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Thanks! I'll change it as you commented out.
Jae
>> +- reg : Should contain PECI controller registers location and
>> + length.
>> +- #address-cells : Should be <1> required to define a client address.
>> +- #size-cells : Should be <0> required to define a client address.
>> +- interrupts : Should contain PECI controller interrupt.
>> +- clocks : Should contain clock source for PECI controller. Should
>> + reference the external oscillator clock in the second
>> + cell.
>> +- resets : Should contain phandle to reset controller with the reset
>> + number in the second cell.
>> +- clock-frequency : Should contain the operation frequency of PECI controller
>> + in units of Hz.
>> + 187500 ~ 24000000
>> +
>> +Optional properties:
>> +- msg-timing : Message timing negotiation period. This value will
>> + determine the period of message timing negotiation to be
>> + issued by PECI controller. The unit of the programmed
>> + value is four times of PECI clock period.
>> + 0 ~ 255 (default: 1)
>> +- addr-timing : Address timing negotiation period. This value will
>> + determine the period of address timing negotiation to be
>> + issued by PECI controller. The unit of the programmed
>> + value is four times of PECI clock period.
>> + 0 ~ 255 (default: 1)
>> +- rd-sampling-point : Read sampling point selection. The whole period of a bit
>> + time will be divided into 16 time frames. This value will
>> + determine the time frame in which the controller will
>> + sample PECI signal for data read back. Usually in the
>> + middle of a bit time is the best.
>> + 0 ~ 15 (default: 8)
>> +- cmd-timeout-ms : Command timeout in units of ms.
>> + 1 ~ 60000 (default: 1000)
>> +
>> +Example:
>> + peci0: peci-bus@0 {
>> + compatible = "aspeed,ast2500-peci";
>> + reg = <0x0 0x60>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + interrupts = <15>;
>> + clocks = <&syscon ASPEED_CLK_GATE_REFCLK>;
>> + resets = <&syscon ASPEED_RESET_PECI>;
>> + clock-frequency = <24000000>;
>> + msg-timing = <1>;
>> + addr-timing = <1>;
>> + rd-sampling-point = <8>;
>> + cmd-timeout-ms = <1000>;
>> + };
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH linux-next v6 05/13] ARM: dts: aspeed: peci: Add PECI node
2018-06-21 19:37 [PATCH linux-next v6 00/13] PECI device driver introduction Jae Hyun Yoo
2018-06-21 19:39 ` [PATCH linux-next v6 01/13] dt-bindings: Add a document of PECI subsystem Jae Hyun Yoo
2018-06-21 19:40 ` [PATCH linux-next v6 04/13] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs Jae Hyun Yoo
@ 2018-06-21 19:40 ` Jae Hyun Yoo
2018-06-21 19:40 ` [PATCH linux-next v6 07/13] dt-bindings: mfd: Add a document for PECI client MFD Jae Hyun Yoo
2018-06-21 19:41 ` [PATCH linux-next v6 09/13] dt-bindings: hwmon: Add documents for PECI hwmon client drivers Jae Hyun Yoo
4 siblings, 0 replies; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-06-21 19:40 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Joel Stanley, Andrew Jeffery,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, openbmc
Cc: Jae Hyun Yoo, Jason M Biils, Ryan Chen
This commit adds PECI bus/adapter node of AST24xx/AST25xx into
aspeed-g4 and aspeed-g5.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Reviewed-by: James Feist <james.feist@linux.intel.com>
Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Cc: Jason M Biils <jason.m.bills@linux.intel.com>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>
---
arch/arm/boot/dts/aspeed-g4.dtsi | 26 ++++++++++++++++++++++++++
arch/arm/boot/dts/aspeed-g5.dtsi | 26 ++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index 75df1573380e..f7b83298e25f 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -29,6 +29,7 @@
serial3 = &uart4;
serial4 = &uart5;
serial5 = &vuart;
+ peci0 = &peci0;
};
cpus {
@@ -295,6 +296,13 @@
};
};
+ peci: peci@1e78b000 {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x1e78b000 0x60>;
+ };
+
uart2: serial@1e78d000 {
compatible = "ns16550a";
reg = <0x1e78d000 0x20>;
@@ -338,6 +346,24 @@
};
};
+&peci {
+ peci0: peci-bus@0 {
+ compatible = "aspeed,ast2400-peci";
+ reg = <0x0 0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <15>;
+ clocks = <&syscon ASPEED_CLK_GATE_REFCLK>;
+ resets = <&syscon ASPEED_RESET_PECI>;
+ clock-frequency = <24000000>;
+ msg-timing = <1>;
+ addr-timing = <1>;
+ rd-sampling-point = <8>;
+ cmd-timeout-ms = <1000>;
+ status = "disabled";
+ };
+};
+
&i2c {
i2c_ic: interrupt-controller@0 {
#interrupt-cells = <1>;
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 17f2714d18a7..f8eccdaacedc 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -29,6 +29,7 @@
serial3 = &uart4;
serial4 = &uart5;
serial5 = &vuart;
+ peci0 = &peci0;
};
cpus {
@@ -352,6 +353,13 @@
};
};
+ peci: peci@1e78b000 {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x1e78b000 0x60>;
+ };
+
uart2: serial@1e78d000 {
compatible = "ns16550a";
reg = <0x1e78d000 0x20>;
@@ -395,6 +403,24 @@
};
};
+&peci {
+ peci0: peci-bus@0 {
+ compatible = "aspeed,ast2500-peci";
+ reg = <0x0 0x60>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <15>;
+ clocks = <&syscon ASPEED_CLK_GATE_REFCLK>;
+ resets = <&syscon ASPEED_RESET_PECI>;
+ clock-frequency = <24000000>;
+ msg-timing = <1>;
+ addr-timing = <1>;
+ rd-sampling-point = <8>;
+ cmd-timeout-ms = <1000>;
+ status = "disabled";
+ };
+};
+
&i2c {
i2c_ic: interrupt-controller@0 {
#interrupt-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH linux-next v6 07/13] dt-bindings: mfd: Add a document for PECI client MFD
2018-06-21 19:37 [PATCH linux-next v6 00/13] PECI device driver introduction Jae Hyun Yoo
` (2 preceding siblings ...)
2018-06-21 19:40 ` [PATCH linux-next v6 05/13] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
@ 2018-06-21 19:40 ` Jae Hyun Yoo
2018-07-03 16:58 ` Rob Herring
2018-06-21 19:41 ` [PATCH linux-next v6 09/13] dt-bindings: hwmon: Add documents for PECI hwmon client drivers Jae Hyun Yoo
4 siblings, 1 reply; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-06-21 19:40 UTC (permalink / raw)
To: Lee Jones, Mark Rutland, Rob Herring, devicetree, linux-kernel,
openbmc
Cc: Jae Hyun Yoo, Andrew Jeffery, James Feist, Jason M Biils,
Joel Stanley, Vernon Mauery
This commit adds a dt-bindings document for PECI client MFD.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: James Feist <james.feist@linux.intel.com>
Cc: Jason M Biils <jason.m.bills@linux.intel.com>
Cc: Joel Stanley <joel@jms.id.au>
Cc: Vernon Mauery <vernon.mauery@linux.intel.com>
---
.../bindings/mfd/intel-peci-client.txt | 34 +++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/intel-peci-client.txt
diff --git a/Documentation/devicetree/bindings/mfd/intel-peci-client.txt b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt
new file mode 100644
index 000000000000..cb341e363add
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt
@@ -0,0 +1,34 @@
+* Intel PECI client bindings
+
+PECI (Platform Environment Control Interface) is a one-wire bus interface that
+provides a communication channel from PECI clients in Intel processors and
+chipset components to external monitoring or control devices. PECI is designed
+to support the following sideband functions:
+
+- Processor and DRAM thermal management
+- Platform Manageability
+- Processor Interface Tuning and Diagnostics
+- Failure Analysis
+
+Required properties:
+- compatible : Should be "intel,peci-client".
+- reg : Should contain address of a client CPU. Address range of CPU
+ clients starts from 0x30 based on PECI specification.
+
+Example:
+ peci-bus@0 {
+ compatible = "vendor,soc-peci";
+ reg = <0x0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ peci-client@30 {
+ compatible = "intel,peci-client";
+ reg = <0x30>;
+ };
+
+ peci-client@31 {
+ compatible = "intel,peci-client";
+ reg = <0x31>;
+ };
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH linux-next v6 07/13] dt-bindings: mfd: Add a document for PECI client MFD
2018-06-21 19:40 ` [PATCH linux-next v6 07/13] dt-bindings: mfd: Add a document for PECI client MFD Jae Hyun Yoo
@ 2018-07-03 16:58 ` Rob Herring
2018-07-03 17:21 ` Jae Hyun Yoo
0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2018-07-03 16:58 UTC (permalink / raw)
To: Jae Hyun Yoo
Cc: Lee Jones, Mark Rutland, devicetree, linux-kernel, openbmc,
Andrew Jeffery, James Feist, Jason M Biils, Joel Stanley,
Vernon Mauery
On Thu, Jun 21, 2018 at 12:40:54PM -0700, Jae Hyun Yoo wrote:
> This commit adds a dt-bindings document for PECI client MFD.
This and the next patch still have the same issues I've outlined in at
least 2 prior versions.
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: James Feist <james.feist@linux.intel.com>
> Cc: Jason M Biils <jason.m.bills@linux.intel.com>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Vernon Mauery <vernon.mauery@linux.intel.com>
> ---
> .../bindings/mfd/intel-peci-client.txt | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/intel-peci-client.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/intel-peci-client.txt b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt
> new file mode 100644
> index 000000000000..cb341e363add
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt
> @@ -0,0 +1,34 @@
> +* Intel PECI client bindings
> +
> +PECI (Platform Environment Control Interface) is a one-wire bus interface that
> +provides a communication channel from PECI clients in Intel processors and
> +chipset components to external monitoring or control devices. PECI is designed
> +to support the following sideband functions:
> +
> +- Processor and DRAM thermal management
> +- Platform Manageability
> +- Processor Interface Tuning and Diagnostics
> +- Failure Analysis
> +
> +Required properties:
> +- compatible : Should be "intel,peci-client".
> +- reg : Should contain address of a client CPU. Address range of CPU
> + clients starts from 0x30 based on PECI specification.
> +
> +Example:
> + peci-bus@0 {
> + compatible = "vendor,soc-peci";
> + reg = <0x0 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + peci-client@30 {
> + compatible = "intel,peci-client";
> + reg = <0x30>;
> + };
> +
> + peci-client@31 {
> + compatible = "intel,peci-client";
> + reg = <0x31>;
> + };
> + };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH linux-next v6 07/13] dt-bindings: mfd: Add a document for PECI client MFD
2018-07-03 16:58 ` Rob Herring
@ 2018-07-03 17:21 ` Jae Hyun Yoo
0 siblings, 0 replies; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-07-03 17:21 UTC (permalink / raw)
To: Rob Herring
Cc: Lee Jones, Mark Rutland, devicetree, linux-kernel, openbmc,
Andrew Jeffery, James Feist, Jason M Biils, Joel Stanley,
Vernon Mauery
Hi Rob,
Thanks for the review. Please see my inline answer.
On 7/3/2018 9:58 AM, Rob Herring wrote:
> On Thu, Jun 21, 2018 at 12:40:54PM -0700, Jae Hyun Yoo wrote:
>> This commit adds a dt-bindings document for PECI client MFD.
>
> This and the next patch still have the same issues I've outlined in at
> least 2 prior versions.
>
Okay. I think the next patch (9/13) for hwmon dt-bindings document
is not needed anymore because those were already added in MFD driver
implementation in the patch 8/13. Please correct me if it's not
you pointed.
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>> Cc: Andrew Jeffery <andrew@aj.id.au>
>> Cc: James Feist <james.feist@linux.intel.com>
>> Cc: Jason M Biils <jason.m.bills@linux.intel.com>
>> Cc: Joel Stanley <joel@jms.id.au>
>> Cc: Vernon Mauery <vernon.mauery@linux.intel.com>
>> ---
>> .../bindings/mfd/intel-peci-client.txt | 34 +++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/intel-peci-client.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/intel-peci-client.txt b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt
>> new file mode 100644
>> index 000000000000..cb341e363add
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt
>> @@ -0,0 +1,34 @@
>> +* Intel PECI client bindings
>> +
>> +PECI (Platform Environment Control Interface) is a one-wire bus interface that
>> +provides a communication channel from PECI clients in Intel processors and
>> +chipset components to external monitoring or control devices. PECI is designed
>> +to support the following sideband functions:
>> +
>> +- Processor and DRAM thermal management
>> +- Platform Manageability
>> +- Processor Interface Tuning and Diagnostics
>> +- Failure Analysis
>> +
>> +Required properties:
>> +- compatible : Should be "intel,peci-client".
>> +- reg : Should contain address of a client CPU. Address range of CPU
>> + clients starts from 0x30 based on PECI specification.
>> +
>> +Example:
>> + peci-bus@0 {
>> + compatible = "vendor,soc-peci";
>> + reg = <0x0 0x1000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + peci-client@30 {
>> + compatible = "intel,peci-client";
>> + reg = <0x30>;
>> + };
>> +
>> + peci-client@31 {
>> + compatible = "intel,peci-client";
>> + reg = <0x31>;
>> + };
>> + };
>> --
>> 2.17.1
>>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH linux-next v6 09/13] dt-bindings: hwmon: Add documents for PECI hwmon client drivers
2018-06-21 19:37 [PATCH linux-next v6 00/13] PECI device driver introduction Jae Hyun Yoo
` (3 preceding siblings ...)
2018-06-21 19:40 ` [PATCH linux-next v6 07/13] dt-bindings: mfd: Add a document for PECI client MFD Jae Hyun Yoo
@ 2018-06-21 19:41 ` Jae Hyun Yoo
4 siblings, 0 replies; 12+ messages in thread
From: Jae Hyun Yoo @ 2018-06-21 19:41 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Haiyue Wang, Vernon Mauery,
James Feist, devicetree, linux-kernel, openbmc
Cc: Jae Hyun Yoo, Andrew Jeffery, Arnd Bergmann, Jason M Biils,
Joel Stanley
This commit adds dt-bindings documents for PECI hwmon client drivers.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Reviewed-by: James Feist <james.feist@linux.intel.com>
Reviewed-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Jason M Biils <jason.m.bills@linux.intel.com>
Cc: Joel Stanley <joel@jms.id.au>
---
.../devicetree/bindings/hwmon/peci-cputemp.txt | 11 +++++++++++
.../devicetree/bindings/hwmon/peci-dimmtemp.txt | 12 ++++++++++++
2 files changed, 23 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
create mode 100644 Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
diff --git a/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
new file mode 100644
index 000000000000..19c7da57deab
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
@@ -0,0 +1,11 @@
+Bindings for Intel PECI (Platform Environment Control Interface) cputemp driver.
+
+Required properties:
+- compatible : Should be "intel,peci-cputemp".
+
+This node is a subnode of the PECI client MFD.
+
+Example:
+ peci-cputemp {
+ compatible = "intel,peci-cputemp";
+ };
diff --git a/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
new file mode 100644
index 000000000000..08ce163ba831
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
@@ -0,0 +1,12 @@
+Bindings for Intel PECI (Platform Environment Control Interface) dimmtemp
+driver.
+
+Required properties:
+- compatible : Should be "intel,peci-dimmtemp".
+
+This node is a subnode of the PECI client MFD.
+
+Example:
+ peci-dimmtemp@30 {
+ compatible = "intel,peci-dimmtemp";
+ };
\ No newline at end of file
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread