From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akhila YS <akhilayalmati@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema
Date: Fri, 2 Jan 2026 11:18:49 +0100 [thread overview]
Message-ID: <baa3ff2a-6569-4b36-aed1-651f83fa175b@kernel.org> (raw)
In-Reply-To: <0363ac61-0872-42da-91b8-78966a2537ce@gmail.com>
On 02/01/2026 09:17, Akhila YS wrote:
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - microchip,mchp23k256
>>> + - microchip,mchp23lcv1024
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + "#address-cells":
>>> + const: 1
>>> +
>>> + "#size-cells":
>>> + const: 1
>> Pretty incomplete. Old binding and above cells claim there can be child
>> nodes, so please add them and test. Works? No. Shall work? Yes... so
>> either old binding was incorrect or new binding is incomplete. I did not
>> check the driver, though.
>
>
> Size cells and Address cells are not required as there is no child node
Then what is the point of address/size cells if you do not have children?
Anyway, read carefully old binding and the driver code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-02 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 12:49 [PATCH] dt-bindings: mtd: microchip,mchp23k256: convert to DT schema Akhila YS
2025-12-30 12:32 ` Krzysztof Kozlowski
[not found] ` <0363ac61-0872-42da-91b8-78966a2537ce@gmail.com>
2026-01-02 10:08 ` Akhila YS
2026-01-02 10:19 ` Krzysztof Kozlowski
2026-01-02 10:18 ` Krzysztof Kozlowski [this message]
2026-01-02 10:31 ` Akhila YS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baa3ff2a-6569-4b36-aed1-651f83fa175b@kernel.org \
--to=krzk@kernel.org \
--cc=akhilayalmati@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).