From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4655EC6FA8B for ; Mon, 5 Sep 2022 10:10:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236982AbiIEKK0 (ORCPT ); Mon, 5 Sep 2022 06:10:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237034AbiIEKKZ (ORCPT ); Mon, 5 Sep 2022 06:10:25 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13AEB2C655 for ; Mon, 5 Sep 2022 03:10:22 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id p7so12448324lfu.3 for ; Mon, 05 Sep 2022 03:10:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=9iZUJ2C+XzNkKLqBt28HLIylkiN68ZpTZ2fgZQtMBpU=; b=g075S5okKrDHmJNtm8Ec66J8SgI+LW/7dkJPUaLVxLUIdCMZ7mkZ0uP6vLvlWxfGY3 GSUj7p9ZQsjq1Liw8ZLR0G3LGJDB8hgK1ItCJL4z40Ai0Z3RlFfsi2nTw9XDVAPSFQBO nx3xh9rJN0Vr1VyajPjDDIfxmKvg4tUSm36bdVQy1dMe9JG4yFh2T87fbnpVKflQ/ROp N4auuALgoy4s2xWcRD4eVsqjGRHiYcUlFtKZUcH3XH1fVvFHbHbim2J9xrgn/nAAOCeR maPHym/1hVHv/AS1eEu/ipimDkb/yAg/mc8e0vAXc4bRxyQLkbSPnqMlPSijxb0mMPjP UfoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=9iZUJ2C+XzNkKLqBt28HLIylkiN68ZpTZ2fgZQtMBpU=; b=ajPM5PfOQ0G55ByaCioaxwby1by+2Dgk4SV0ydx0/eV3BSeAZGwMS/37Tl6gqmv6RU RhsQm/P0ns4s6ZVviUb322kLP+lZ5+ixBIZWYJSMRVceySX+w8T7OLeAQQcW0nYumnAp Zf4+ejXrgbG12BsM0StRySp7dPtV5x66hplCMOCd5erMc88NqcrpV9EQKgbpOEF+hzAe dNZn2uaG5WdmO1RdDS7KaSbXpLzk0bpI/ie8ZuOb6ij1e/pWvpC3RChK0N5Kp0YeYOFw 7GvXBZbF2kbElFXq3q1kUw88YA33jfMclts2jEqgoyikAEA9NmSOE43HQ3r/41+KuVV0 TlMQ== X-Gm-Message-State: ACgBeo01xS/6AkLYfU/fP/ahTPp5QCO6TQEP7X++eGOwXjwqYut6BD30 jXEhpwauU/nnQs4e8JoSt7c/Vw== X-Google-Smtp-Source: AA6agR54xygcg8U5xob0simsg/0TJd3c+/Trm5Wr5mH6lOfqkDvRVfkz6Tv/7SEAHfrH+2elmOMrXw== X-Received: by 2002:a05:6512:12c4:b0:494:8373:5678 with SMTP id p4-20020a05651212c400b0049483735678mr8899913lfg.577.1662372620382; Mon, 05 Sep 2022 03:10:20 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 9-20020ac25f09000000b0048b365176d9sm1135613lfq.286.2022.09.05.03.10.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 03:10:19 -0700 (PDT) Message-ID: Date: Mon, 5 Sep 2022 12:10:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema Content-Language: en-US To: Eugen.Hristev@microchip.com, Sergiu.Moga@microchip.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com, radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, admin@hifiphile.com, Kavyasree.Kotagiri@microchip.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org References: <20220817075517.49575-1-sergiu.moga@microchip.com> <20220817075517.49575-3-sergiu.moga@microchip.com> <942accc5-70aa-3bb2-63dd-306a39ee5ea4@linaro.org> <0aba8906-ed30-786e-cff4-6cb70d6e73c5@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/09/2022 13:31, Eugen.Hristev@microchip.com wrote: >>>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml >>>>>> new file mode 100644 >>>>>> index 000000000000..cf15d73fa1e8 >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml >>>>> One more thing - I think this should be in serial directory, not mfd, >>>>> even though it includes SPI. MFD is just a Linux naming/wrapper device. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> >>>> I would rather keep it in this directory, since its corresponding driver >>>> is also in the mfd directory. >>> >>> Sorry, but that's poor argument. Driver subsystems match Linux >>> convention, not necessarily hardware type/naming. Bindings directories >>> match hardware. MFD bindings are only for MFD wrapper drivers and this >>> is a serial interface. Not a MFD. You even do not add MFD devices in the >>> driver but add *always one* device depending on serial feature you want. >>> This is not even MFD device but regular platform device with children. >>> >>> You put it in SoC, though, because all other SoCs store it there... >> >> The last one should be: >> >> You could put it in SoC, though, because all other SoCs store it there... > > Hi, > > If it this is only a conversion to yaml, why do you want it moved to > another dir ? > Perhaps if you consider SoC or serial as a better place, it should be > done through a different patch. > > Also, disputing whether this is really a MFD or not, is not in the scope > of this patch. > Because you are converting - thus renaming - the bindings, so this is the place to put them in proper place. The conversion to DT Schema comes pretty often with small fixups, so proper location is one of them. That's quite common case. Best regards, Krzysztof